)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cba5e6f46311e8a94eca20d8ef79e80bd4333488","unresolved":false,"context_lines":[{"line_number":10,"context_line":"method. However, probe tests will run even if we cannot use the resetswift"},{"line_number":11,"context_line":"script for some reasons (e.g. not permitted, the script not found) and"},{"line_number":12,"context_line":"probably the probe tests will fail after a long time passed for the"},{"line_number":13,"context_line":"exection."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To prevent such an unfortunate situation and also to find the reason"},{"line_number":16,"context_line":"easily, this patch adds the exit code check for \"resetswift\" and if it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_52c41a5e","line":13,"updated":"2016-08-16 09:21:53.000000000","message":"s/exection/execution/","commit_id":"5f5ee4cd734f98b96a29ffb639cdf22e4833fa36"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cba5e6f46311e8a94eca20d8ef79e80bd4333488","unresolved":false,"context_lines":[{"line_number":15,"context_line":"To prevent such an unfortunate situation and also to find the reason"},{"line_number":16,"context_line":"easily, this patch adds the exit code check for \"resetswift\" and if it"},{"line_number":17,"context_line":"failed, the test will raise AssertionError with the stdout and stderr to"},{"line_number":18,"context_line":"make us easy to find the reason."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id80d56ab6b71402ead4fe22c120064d78c1e74ac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_12910253","line":18,"updated":"2016-08-16 09:21:53.000000000","message":"s/us/it/","commit_id":"5f5ee4cd734f98b96a29ffb639cdf22e4833fa36"}],"test/probe/common.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cba5e6f46311e8a94eca20d8ef79e80bd4333488","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    if p.returncode:"},{"line_number":270,"context_line":"        raise AssertionError("},{"line_number":271,"context_line":"            \u0027Cleanup with \"resetswift\" failed: stdout: %s, stderr: %s\u0027"},{"line_number":272,"context_line":"            % (stdout, _stderr))"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    print(stdout)"},{"line_number":275,"context_line":"    Manager([\u0027all\u0027]).stop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_32fa3ebe","line":272,"updated":"2016-08-16 09:21:53.000000000","message":"nit: maybe one of the subprocess helper methods would replace these lines e.g. check_output. But IMO this is ok, and works. There may be a reason for the explicit use of communicate() or it may be that we have this because check_output() was new in python2.7.","commit_id":"5f5ee4cd734f98b96a29ffb639cdf22e4833fa36"}]}