)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f412d80f08b4c3a3fac9a72fab7fd99d7af8ab3d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct swift reraising of exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an exception was caught and rethrown, it should call \u0027raise\u0027 without any arguments because it shows the place where an exception occured initially instead of place where the exception re-raised."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I783a2a65f3e38a23ba49b6ae5a2f56a5fdaac2fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_fe3465df","line":9,"updated":"2016-08-26 09:59:54.000000000","message":"Please break this line that each line has less than 72 characters. See [1] for more info about openstack standard commit message structure.\n\n1: https://wiki.openstack.org/wiki/GitCommitMessages?%22Summary%20of%20Git%20commit%20message%20structure%22#Summary_of_Git_commit_message_structure","commit_id":"5b8b5947c113181a5ae107f4d8cbc4af036a0d80"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f412d80f08b4c3a3fac9a72fab7fd99d7af8ab3d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Correct swift reraising of exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an exception was caught and rethrown, it should call \u0027raise\u0027 without any arguments because it shows the place where an exception occured initially instead of place where the exception re-raised."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I783a2a65f3e38a23ba49b6ae5a2f56a5fdaac2fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_3eb6cddc","line":10,"updated":"2016-08-26 09:59:54.000000000","message":"Looking at branch name, \"bug/10010024\", it seems that you want to address a bug reported in launchpad, right? However, \nit looks like no bug report exists with 10010024. Am I missing something?\n\nIf the bug report exists, please make a tag, \"Closes-Bug: #\u003cbug number\u003e\" in the commit message to make a link in gerrit review system.","commit_id":"5b8b5947c113181a5ae107f4d8cbc4af036a0d80"}],"swift/common/middleware/x_profile/html_viewer.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"310f27b437303add6c700a0dbe6389e8d8350782","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                data \u003d stats.print_stats()"},{"line_number":388,"context_line":"            return data, [(\u0027content-type\u0027, self.format_dict[output_format])]"},{"line_number":389,"context_line":"        except ODFLIBNotInstalled:"},{"line_number":390,"context_line":"            raise"},{"line_number":391,"context_line":"        except Exception as ex:"},{"line_number":392,"context_line":"            raise ProfileException(_(\u0027Data download error: %s\u0027) % ex)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_c4c9677a","line":390,"updated":"2016-08-26 20:27:10.000000000","message":"again?","commit_id":"5b8b5947c113181a5ae107f4d8cbc4af036a0d80"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fcb8b3617b62e3dd622b95d3cbb10fa53f4306f7","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                data \u003d stats.print_stats()"},{"line_number":388,"context_line":"            return data, [(\u0027content-type\u0027, self.format_dict[output_format])]"},{"line_number":389,"context_line":"        except ODFLIBNotInstalled:"},{"line_number":390,"context_line":"            raise"},{"line_number":391,"context_line":"        except Exception as ex:"},{"line_number":392,"context_line":"            raise ProfileException(_(\u0027Data download error: %s\u0027) % ex)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_fa37e6ad","line":390,"in_reply_to":"fa7ab95a_3a6f8ec6","updated":"2016-08-26 20:56:58.000000000","message":"oh yeah of course, the good \u0027ol \"except everything except\" pattern - thanks","commit_id":"5b8b5947c113181a5ae107f4d8cbc4af036a0d80"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5804c472da00f595608712c72686e0211699eccc","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                data \u003d stats.print_stats()"},{"line_number":388,"context_line":"            return data, [(\u0027content-type\u0027, self.format_dict[output_format])]"},{"line_number":389,"context_line":"        except ODFLIBNotInstalled:"},{"line_number":390,"context_line":"            raise"},{"line_number":391,"context_line":"        except Exception as ex:"},{"line_number":392,"context_line":"            raise ProfileException(_(\u0027Data download error: %s\u0027) % ex)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_3a6f8ec6","line":390,"in_reply_to":"fa7ab95a_c4c9677a","updated":"2016-08-26 20:55:11.000000000","message":"This one makes some sense; we want to avoid the\n\n except Exception as ex:\n\nbelow and keep it as an ODFLIBNotInstalled error instead of a ProfileException.","commit_id":"5b8b5947c113181a5ae107f4d8cbc4af036a0d80"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9e1d19c25ffeae5ea849215f906c549b531ca579","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                data \u003d stats.print_stats()"},{"line_number":388,"context_line":"            return data, [(\u0027content-type\u0027, self.format_dict[output_format])]"},{"line_number":389,"context_line":"        except ODFLIBNotInstalled:"},{"line_number":390,"context_line":"            raise"},{"line_number":391,"context_line":"        except Exception as ex:"},{"line_number":392,"context_line":"            raise ProfileException(_(\u0027Data download error: %s\u0027) % ex)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_8faa0c18","line":390,"updated":"2016-09-01 06:26:11.000000000","message":"ok. as Tim described in patch set 1, this one avoid to catch  ODFLIBNotInstalled as a general Exception and to translate ProfileException. That makes me sense.","commit_id":"671254224a4a4710e7556535ee68bd999536ab8d"}],"swift/container/sync.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9e593b3248ecfafea3d44e69c26b3f2d9b9d7162","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                        sync_stage_time \u003d time()"},{"line_number":430,"context_line":"                    self.container_syncs +\u003d 1"},{"line_number":431,"context_line":"                    self.logger.increment(\u0027syncs\u0027)"},{"line_number":432,"context_line":"                except Exception:"},{"line_number":433,"context_line":"                    raise"},{"line_number":434,"context_line":"                finally:"},{"line_number":435,"context_line":"                    self.container_report(start_at, sync_stage_time,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_c016baf0","line":432,"updated":"2016-08-26 17:58:28.000000000","message":"Can we just remove this block? What purpose does it serve?","commit_id":"5b8b5947c113181a5ae107f4d8cbc4af036a0d80"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"01bd6bf13c35576d5d960c850eefc20dff110358","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                        sync_stage_time \u003d time()"},{"line_number":430,"context_line":"                    self.container_syncs +\u003d 1"},{"line_number":431,"context_line":"                    self.logger.increment(\u0027syncs\u0027)"},{"line_number":432,"context_line":"                except Exception:"},{"line_number":433,"context_line":"                    raise"},{"line_number":434,"context_line":"                finally:"},{"line_number":435,"context_line":"                    self.container_report(start_at, sync_stage_time,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_e73db4bc","line":432,"in_reply_to":"fa7ab95a_04bb4fe6","updated":"2016-08-31 12:21:49.000000000","message":"Oh yes, please!","commit_id":"5b8b5947c113181a5ae107f4d8cbc4af036a0d80"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"310f27b437303add6c700a0dbe6389e8d8350782","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                        sync_stage_time \u003d time()"},{"line_number":430,"context_line":"                    self.container_syncs +\u003d 1"},{"line_number":431,"context_line":"                    self.logger.increment(\u0027syncs\u0027)"},{"line_number":432,"context_line":"                except Exception:"},{"line_number":433,"context_line":"                    raise"},{"line_number":434,"context_line":"                finally:"},{"line_number":435,"context_line":"                    self.container_report(start_at, sync_stage_time,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_04bb4fe6","line":432,"in_reply_to":"fa7ab95a_c016baf0","updated":"2016-08-26 20:27:10.000000000","message":"lol","commit_id":"5b8b5947c113181a5ae107f4d8cbc4af036a0d80"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9e1d19c25ffeae5ea849215f906c549b531ca579","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                        broker.set_x_container_sync_points(sync_point1, None)"},{"line_number":429,"context_line":"                        sync_stage_time \u003d time()"},{"line_number":430,"context_line":"                    self.container_syncs +\u003d 1"},{"line_number":431,"context_line":"                    self.logger.increment(\u0027syncs\u0027)"},{"line_number":432,"context_line":"                finally:"},{"line_number":433,"context_line":"                    self.container_report(start_at, sync_stage_time,"},{"line_number":434,"context_line":"                                          sync_point1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_0f6d1c04","line":431,"updated":"2016-09-01 06:26:11.000000000","message":"And then, this general except Exception is unnecessary.","commit_id":"671254224a4a4710e7556535ee68bd999536ab8d"}]}