)]}'
{"swift/obj/server.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"afcee1c91afc2f1ae7f5de268edd81f88ec786ca","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        :param extension: extension to be used when making the file"},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        if not self.tmppath:"},{"line_number":144,"context_line":"            raise ValueError(\"An unexpected value of temppath: %s\" %"},{"line_number":145,"context_line":"                             self.tmppath)"},{"line_number":146,"context_line":"        timestamp \u003d normalize_timestamp(metadata[\u0027X-Timestamp\u0027])"},{"line_number":147,"context_line":"        metadata[\u0027name\u0027] \u003d self.disk_file.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F19c%3D","line":144,"updated":"2013-07-10 15:02:51.000000000","message":"I don\u0027t like the printout. Since tmppath evaluated to False, it\u0027s either None or empty. I don\u0027t foresee a lot of help trying to print it, but in case of empty the printout is going to look dumb with the trailing colon. Please consider printing \"temppath is unusable\" or something to that effect instead.","commit_id":"6153ce4c50b01f8b2aa0a950da5e5382f3436d85"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"236c1cf26c41cb8e64432c97555cd558e99061f5","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        :param extension: extension to be used when making the file"},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        if not self.tmppath:"},{"line_number":144,"context_line":"            raise ValueError(\"An unexpected value of temppath: %s\" %"},{"line_number":145,"context_line":"                             self.tmppath)"},{"line_number":146,"context_line":"        timestamp \u003d normalize_timestamp(metadata[\u0027X-Timestamp\u0027])"},{"line_number":147,"context_line":"        metadata[\u0027name\u0027] \u003d self.disk_file.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F100%3D","line":144,"in_reply_to":"AAAAP3%2F%2F18E%3D","updated":"2013-07-10 15:37:49.000000000","message":"I think the intent of the assert was to make sure someone isn\u0027t calling when class is not set up for writing. Peter Portante\u0027s work in this area pulls all this away into a new class \"DiskWriter\", which makes the assert unnecessary (not a stateful class like here). In view of that, the meaningful part is to detect None.","commit_id":"6153ce4c50b01f8b2aa0a950da5e5382f3436d85"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"859a72404bfadd75894a0de530f9b6557191d9c5","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        :param extension: extension to be used when making the file"},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        if not self.tmppath:"},{"line_number":144,"context_line":"            raise ValueError(\"An unexpected value of temppath: %s\" %"},{"line_number":145,"context_line":"                             self.tmppath)"},{"line_number":146,"context_line":"        timestamp \u003d normalize_timestamp(metadata[\u0027X-Timestamp\u0027])"},{"line_number":147,"context_line":"        metadata[\u0027name\u0027] \u003d self.disk_file.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F18E%3D","line":144,"in_reply_to":"AAAAP3%2F%2F19c%3D","updated":"2013-07-10 15:08:13.000000000","message":"thx, what about remove the \u0027assert\u0027 line? If temppath is invaluable, traceback of following error would seem easy to debug.","commit_id":"6153ce4c50b01f8b2aa0a950da5e5382f3436d85"}]}