)]}'
{"swift/common/swob.py":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"e8d832fc7f4f3692135e95da9dc3c4fe87ee769d","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    \"\"\""},{"line_number":469,"context_line":"    def __init__(self, headerval):"},{"line_number":470,"context_line":"        if not headerval:"},{"line_number":471,"context_line":"            raise ValueError(\u0027Invalid Range header: %s\u0027 % str(headerval))"},{"line_number":472,"context_line":"        headerval \u003d headerval.replace(\u0027 \u0027, \u0027\u0027)"},{"line_number":473,"context_line":"        if not headerval.lower().startswith(\u0027bytes\u003d\u0027):"},{"line_number":474,"context_line":"            raise ValueError(\u0027Invalid Range header: %s\u0027 % headerval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_37dbba50","line":471,"updated":"2016-09-07 16:47:44.000000000","message":"Since None is one expected value of headerval, and since an empty string will be caught too, how would you feel about %r instead of %s and casting to str()? This would avoid messages like \"Invalid Range header: \"","commit_id":"dbd6f8bacdf3e21f985b74659ad6c176350f3e6f"},{"author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"change_message_id":"41b21efdb072be4671c55c4ae8582da12d346781","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    \"\"\""},{"line_number":469,"context_line":"    def __init__(self, headerval):"},{"line_number":470,"context_line":"        if not headerval:"},{"line_number":471,"context_line":"            raise ValueError(\u0027Invalid Range header: %s\u0027 % str(headerval))"},{"line_number":472,"context_line":"        headerval \u003d headerval.replace(\u0027 \u0027, \u0027\u0027)"},{"line_number":473,"context_line":"        if not headerval.lower().startswith(\u0027bytes\u003d\u0027):"},{"line_number":474,"context_line":"            raise ValueError(\u0027Invalid Range header: %s\u0027 % headerval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_4a088bda","line":471,"in_reply_to":"9a89bdaa_37dbba50","updated":"2016-09-07 21:01:10.000000000","message":"Done","commit_id":"dbd6f8bacdf3e21f985b74659ad6c176350f3e6f"}],"swift/proxy/controllers/base.py":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"2821a389eb9b3e915b1e44c2cf676617d3e2b9f0","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"            if req_range and len(req_range.ranges) \u003d\u003d 1:"},{"line_number":1070,"context_line":"                begin, end \u003d req_range.ranges[0]"},{"line_number":1071,"context_line":"                if end !\u003d None and begin !\u003d None:"},{"line_number":1072,"context_line":"                    if end - begin + 1 \u003d\u003d self.bytes_used_from_backend:"},{"line_number":1073,"context_line":"                        warn \u003d False"},{"line_number":1074,"context_line":"            if not req.environ.get(\u0027swift.non_client_disconnect\u0027) and warn:"},{"line_number":1075,"context_line":"                self.app.logger.warning(_(\u0027Client disconnected on read\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_c9714578","line":1072,"updated":"2016-09-07 01:02:31.000000000","message":"You could, if you wanted, collapse these two into a single if. I don\u0027t feel strongly about it, though.","commit_id":"dbd6f8bacdf3e21f985b74659ad6c176350f3e6f"},{"author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"change_message_id":"41b21efdb072be4671c55c4ae8582da12d346781","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"            if req_range and len(req_range.ranges) \u003d\u003d 1:"},{"line_number":1070,"context_line":"                begin, end \u003d req_range.ranges[0]"},{"line_number":1071,"context_line":"                if end !\u003d None and begin !\u003d None:"},{"line_number":1072,"context_line":"                    if end - begin + 1 \u003d\u003d self.bytes_used_from_backend:"},{"line_number":1073,"context_line":"                        warn \u003d False"},{"line_number":1074,"context_line":"            if not req.environ.get(\u0027swift.non_client_disconnect\u0027) and warn:"},{"line_number":1075,"context_line":"                self.app.logger.warning(_(\u0027Client disconnected on read\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_cafc9bba","line":1072,"in_reply_to":"9a89bdaa_c9714578","updated":"2016-09-07 21:01:10.000000000","message":"I\u0027m gonna leave it as is.","commit_id":"dbd6f8bacdf3e21f985b74659ad6c176350f3e6f"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"2821a389eb9b3e915b1e44c2cf676617d3e2b9f0","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"                        warn \u003d False"},{"line_number":1074,"context_line":"            if not req.environ.get(\u0027swift.non_client_disconnect\u0027) and warn:"},{"line_number":1075,"context_line":"                self.app.logger.warning(_(\u0027Client disconnected on read\u0027))"},{"line_number":1076,"context_line":"            raise e"},{"line_number":1077,"context_line":"        except Exception:"},{"line_number":1078,"context_line":"            self.app.logger.exception(_(\u0027Trying to send to client\u0027))"},{"line_number":1079,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_e95369e0","line":1076,"updated":"2016-09-07 01:02:31.000000000","message":"Use six.reraise() here so we don\u0027t lose the stack trace, please.","commit_id":"dbd6f8bacdf3e21f985b74659ad6c176350f3e6f"},{"author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"change_message_id":"41b21efdb072be4671c55c4ae8582da12d346781","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"                        warn \u003d False"},{"line_number":1074,"context_line":"            if not req.environ.get(\u0027swift.non_client_disconnect\u0027) and warn:"},{"line_number":1075,"context_line":"                self.app.logger.warning(_(\u0027Client disconnected on read\u0027))"},{"line_number":1076,"context_line":"            raise e"},{"line_number":1077,"context_line":"        except Exception:"},{"line_number":1078,"context_line":"            self.app.logger.exception(_(\u0027Trying to send to client\u0027))"},{"line_number":1079,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_0a03e3b8","line":1076,"in_reply_to":"9a89bdaa_e95369e0","updated":"2016-09-07 21:01:10.000000000","message":"Done","commit_id":"dbd6f8bacdf3e21f985b74659ad6c176350f3e6f"}]}