)]}'
{"test/unit/common/test_db.py":[{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"2f16d3f0d4de77d8202807160be60be3be4492d4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"class TestDatabaseAlreadyExists(unittest.TestCase):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_str(self):"},{"line_number":68,"context_line":"        exists \u003d DatabaseAlreadyExists(\u0027:memory\u0027)"},{"line_number":69,"context_line":"        self.assertEqual(\u0027DB :memory already exists\u0027, str(exists))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_1bd9d883","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":14},"updated":"2016-12-09 12:21:21.000000000","message":"\u0027exists\u0027 is bad variable name, because I think variable name should be a noun which means \"what kind of value will be assigned\".\nFor example, \u0027err\u0027 would be nice, because \u0027DatabaseAlreadyExists\u0027 is the kind of error.","commit_id":"117905a651cba25f585ea5dc106504916eb63464"},{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"2f16d3f0d4de77d8202807160be60be3be4492d4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"class TestDatabaseAlreadyExists(unittest.TestCase):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_str(self):"},{"line_number":68,"context_line":"        exists \u003d DatabaseAlreadyExists(\u0027:memory\u0027)"},{"line_number":69,"context_line":"        self.assertEqual(\u0027DB :memory already exists\u0027, str(exists))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_db120009","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":48},"updated":"2016-12-09 12:21:21.000000000","message":"Constructor of DatabaseAlreadyExists expects a file path string.\nTherefore, IMO, \u0027:memory\u0027 is not good.","commit_id":"117905a651cba25f585ea5dc106504916eb63464"},{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"2f16d3f0d4de77d8202807160be60be3be4492d4","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        self.assertEqual(broker.db_file, db_file)"},{"line_number":618,"context_line":"        self.assertTrue(broker.conn is None)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def test_init(self):"},{"line_number":621,"context_line":"        info \u003d {\u0027db_file\u0027: \u0027:memory\u0027,"},{"line_number":622,"context_line":"                \u0027timeout\u0027: 20,"},{"line_number":623,"context_line":"                \u0027logger\u0027: \u0027logger\u0027,"},{"line_number":624,"context_line":"                \u0027account\u0027: \u0027a\u0027,"},{"line_number":625,"context_line":"                \u0027container\u0027: \u0027c\u0027,"},{"line_number":626,"context_line":"                \u0027pending_timeout\u0027: 30,"},{"line_number":627,"context_line":"                \u0027stale_reads_ok\u0027: True}"},{"line_number":628,"context_line":"        broker \u003d DatabaseBroker(info[\u0027db_file\u0027], timeout\u003dinfo[\u0027timeout\u0027],"},{"line_number":629,"context_line":"                                logger\u003dinfo[\u0027logger\u0027], account\u003dinfo[\u0027account\u0027],"},{"line_number":630,"context_line":"                                container\u003dinfo[\u0027container\u0027],"},{"line_number":631,"context_line":"                                pending_timeout\u003dinfo[\u0027pending_timeout\u0027],"},{"line_number":632,"context_line":"                                stale_reads_ok\u003dinfo[\u0027stale_reads_ok\u0027])"},{"line_number":633,"context_line":"        self.assertIsNone(broker.conn)"},{"line_number":634,"context_line":"        self.assertEqual(broker.db_file, info[\u0027db_file\u0027])"},{"line_number":635,"context_line":"        self.assertEqual(broker.pending_file, info[\u0027db_file\u0027] + \u0027.pending\u0027)"},{"line_number":636,"context_line":"        self.assertEqual(broker.pending_timeout, info[\u0027pending_timeout\u0027])"},{"line_number":637,"context_line":"        self.assertEqual(broker.stale_reads_ok, info[\u0027stale_reads_ok\u0027])"},{"line_number":638,"context_line":"        db_dir \u003d os.path.dirname(info[\u0027db_file\u0027])"},{"line_number":639,"context_line":"        self.assertEqual(broker.db_dir, db_dir)"},{"line_number":640,"context_line":"        self.assertEqual(broker.timeout, info[\u0027timeout\u0027])"},{"line_number":641,"context_line":"        self.assertEqual(broker.logger, info[\u0027logger\u0027])"},{"line_number":642,"context_line":"        self.assertEqual(broker.account, info[\u0027account\u0027])"},{"line_number":643,"context_line":"        self.assertEqual(broker.container, info[\u0027container\u0027])"},{"line_number":644,"context_line":"        self.assertEqual(broker._db_version, -1)"},{"line_number":645,"context_line":"        # default parameters"},{"line_number":646,"context_line":"        broker \u003d DatabaseBroker(\u0027:memory\u0027)"},{"line_number":647,"context_line":"        self.assertIsNone(broker.conn)"},{"line_number":648,"context_line":"        self.assertEqual(broker.db_file, \u0027:memory\u0027)"},{"line_number":649,"context_line":"        self.assertEqual(broker.pending_file, \u0027:memory\u0027 + \u0027.pending\u0027)"},{"line_number":650,"context_line":"        self.assertEqual(broker.pending_timeout, 10)"},{"line_number":651,"context_line":"        self.assertFalse(broker.stale_reads_ok)"},{"line_number":652,"context_line":"        db_dir \u003d os.path.dirname(\u0027:memory\u0027)"},{"line_number":653,"context_line":"        self.assertEqual(broker.db_dir, db_dir)"},{"line_number":654,"context_line":"        self.assertEqual(broker.timeout, BROKER_TIMEOUT)"},{"line_number":655,"context_line":"        self.assertEqual(broker.logger, logging.getLogger())"},{"line_number":656,"context_line":"        self.assertIsNone(broker.account)"},{"line_number":657,"context_line":"        self.assertIsNone(broker.container)"},{"line_number":658,"context_line":"        self.assertEqual(broker._db_version, -1)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def test_disk_preallocate(self):"},{"line_number":661,"context_line":"        test_size \u003d [-1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_9b3408fc","line":658,"range":{"start_line":620,"start_character":0,"end_line":658,"end_character":48},"updated":"2016-12-09 12:21:21.000000000","message":"Is this test necessary?\nI think this test asserts only that argument values of the constructor are assigned to the broker\u0027s member.","commit_id":"117905a651cba25f585ea5dc106504916eb63464"}]}