)]}'
{"test/unit/common/test_header_key_dict.py":[{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"32f1d42f62800ab0760a059f627f8c8e434c09a5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_del_contains(self):"},{"line_number":48,"context_line":"        headers \u003d HeaderKeyDict()"},{"line_number":49,"context_line":"        headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":50,"context_line":"        self.assertTrue(\u0027Content-Length\u0027 in headers)"},{"line_number":51,"context_line":"        del headers[\u0027Content-Length\u0027]"},{"line_number":52,"context_line":"        self.assertTrue(\u0027Content-Length\u0027 not in headers)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_00098931","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":52},"updated":"2016-09-09 19:58:19.000000000","message":"Could you change these asserts to specific assert ?\n\nself.assertIn(\u0027Content-Length\u0027, headers)","commit_id":"df75e5c36c3e795040a87180366deef28fba57c3"},{"author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"change_message_id":"719998b002c2939ac97836c4a837abab4034cbbb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_del_contains(self):"},{"line_number":48,"context_line":"        headers \u003d HeaderKeyDict()"},{"line_number":49,"context_line":"        headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":50,"context_line":"        self.assertTrue(\u0027Content-Length\u0027 in headers)"},{"line_number":51,"context_line":"        del headers[\u0027Content-Length\u0027]"},{"line_number":52,"context_line":"        self.assertTrue(\u0027Content-Length\u0027 not in headers)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_32c40c91","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":52},"in_reply_to":"9a89bdaa_00098931","updated":"2016-09-11 02:33:39.000000000","message":"Done","commit_id":"df75e5c36c3e795040a87180366deef28fba57c3"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"32f1d42f62800ab0760a059f627f8c8e434c09a5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":50,"context_line":"        self.assertTrue(\u0027Content-Length\u0027 in headers)"},{"line_number":51,"context_line":"        del headers[\u0027Content-Length\u0027]"},{"line_number":52,"context_line":"        self.assertTrue(\u0027Content-Length\u0027 not in headers)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_update(self):"},{"line_number":55,"context_line":"        headers \u003d HeaderKeyDict()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_db123058","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":56},"updated":"2016-09-09 19:58:19.000000000","message":"Ditto.\n\nself.assertNotIn(\u0027Content-Length\u0027, headers)","commit_id":"df75e5c36c3e795040a87180366deef28fba57c3"},{"author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"change_message_id":"719998b002c2939ac97836c4a837abab4034cbbb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":50,"context_line":"        self.assertTrue(\u0027Content-Length\u0027 in headers)"},{"line_number":51,"context_line":"        del headers[\u0027Content-Length\u0027]"},{"line_number":52,"context_line":"        self.assertTrue(\u0027Content-Length\u0027 not in headers)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_update(self):"},{"line_number":55,"context_line":"        headers \u003d HeaderKeyDict()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_72be9400","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":56},"in_reply_to":"9a89bdaa_db123058","updated":"2016-09-11 02:33:39.000000000","message":"Done","commit_id":"df75e5c36c3e795040a87180366deef28fba57c3"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"32f1d42f62800ab0760a059f627f8c8e434c09a5","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_pop(self):"},{"line_number":78,"context_line":"        headers \u003d HeaderKeyDict()"},{"line_number":79,"context_line":"        headers[\u0027cOntent-length\u0027] \u003d 20"},{"line_number":80,"context_line":"        headers[\u0027content-Type\u0027] \u003d \u0027text/plain\u0027"},{"line_number":81,"context_line":"        self.assertEqual(headers.pop(\u0027content-Length\u0027), \u002720\u0027)"},{"line_number":82,"context_line":"        self.assertEqual(headers.pop(\u0027Content-Type\u0027), \u0027text/plain\u0027)"},{"line_number":83,"context_line":"        self.assertEqual(headers.pop(\u0027Something-Else\u0027, \u0027somevalue\u0027),"},{"line_number":84,"context_line":"                         \u0027somevalue\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_5b5f0075","line":81,"range":{"start_line":79,"start_character":7,"end_line":81,"end_character":61},"updated":"2016-09-09 19:58:19.000000000","message":"maintain consistency among all methods:\n\nline 79: headers[\u0027content-length\u0027] \u003d 20\nline 80: headers[\u0027cOntent-tYpe\u0027] \u003d \u0027text/plain\u0027\nline 81: self.assertEqual(headers.pop(\u0027content-Length\u0027), \u002720\u0027)","commit_id":"df75e5c36c3e795040a87180366deef28fba57c3"},{"author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"change_message_id":"719998b002c2939ac97836c4a837abab4034cbbb","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_pop(self):"},{"line_number":78,"context_line":"        headers \u003d HeaderKeyDict()"},{"line_number":79,"context_line":"        headers[\u0027cOntent-length\u0027] \u003d 20"},{"line_number":80,"context_line":"        headers[\u0027content-Type\u0027] \u003d \u0027text/plain\u0027"},{"line_number":81,"context_line":"        self.assertEqual(headers.pop(\u0027content-Length\u0027), \u002720\u0027)"},{"line_number":82,"context_line":"        self.assertEqual(headers.pop(\u0027Content-Type\u0027), \u0027text/plain\u0027)"},{"line_number":83,"context_line":"        self.assertEqual(headers.pop(\u0027Something-Else\u0027, \u0027somevalue\u0027),"},{"line_number":84,"context_line":"                         \u0027somevalue\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_d23920a5","line":81,"range":{"start_line":79,"start_character":7,"end_line":81,"end_character":61},"in_reply_to":"9a89bdaa_5b5f0075","updated":"2016-09-11 02:33:39.000000000","message":"Done","commit_id":"df75e5c36c3e795040a87180366deef28fba57c3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"5852a76ec4642b741b480c6253b8e49c9c6da196","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        headers[\u0027Content-Length\u0027] \u003d 0"},{"line_number":50,"context_line":"        self.assertIn(\u0027Content-Length\u0027, headers)"},{"line_number":51,"context_line":"        del headers[\u0027Content-Length\u0027]"},{"line_number":52,"context_line":"        self.assertNotIn(\u0027Content-Length\u0027, headers)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_update(self):"},{"line_number":55,"context_line":"        headers \u003d HeaderKeyDict()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_65111e52","line":52,"updated":"2016-09-13 07:12:35.000000000","message":"I don\u0027t mind a simple drive by fix like this, but when you do you should mention it in the commit message. Only because this is outside the scope of the change, and if it did effect something we find out later then it would help pinpoint it. (noting when it lands we\u0027d only have commit message [and git bisect I guess]) to go by.\n\nBut this is a small trival drive by so great :)","commit_id":"3f2a4b2d89d66daa64cd3cf9bf31efd25702a0a9"}]}