)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1fea40fd30b68cb975c3c41355b84ea4a81c0b79","unresolved":false,"context_lines":[{"line_number":3010,"context_line":"        \"\"\""},{"line_number":3011,"context_line":"        if not super(ECDiskFileManager, self)._verify_ondisk_files("},{"line_number":3012,"context_line":"                results, **kwargs):"},{"line_number":3013,"context_line":"            return False"},{"line_number":3014,"context_line":""},{"line_number":3015,"context_line":"        have_data_file \u003d results[\u0027data_file\u0027] is not None"},{"line_number":3016,"context_line":"        have_durable \u003d results.get(\u0027durable_frag_set\u0027) is not None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_6830939f","line":3013,"updated":"2016-09-19 23:31:42.000000000","message":"i like this guard return here to de-dent the rest.","commit_id":"9c513f0ce909182ef63454fd7eff809d43405bef"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1fea40fd30b68cb975c3c41355b84ea4a81c0b79","unresolved":false,"context_lines":[{"line_number":3018,"context_line":"            return False"},{"line_number":3019,"context_line":"        if have_data_file and not have_durable and frag_prefs is None:"},{"line_number":3020,"context_line":"            return False"},{"line_number":3021,"context_line":"        return True"},{"line_number":3022,"context_line":""},{"line_number":3023,"context_line":"    def _update_suffix_hashes(self, hashes, ondisk_info):"},{"line_number":3024,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_2bb6853d","line":3021,"updated":"2016-09-19 23:31:42.000000000","message":"yeah, that\u0027s probably better\n\nHere I try to simplify further; I cut the problem in half to begin with; then never have a boolean logic statement with more than two terms:\n\n        have_data_file \u003d results[\u0027data_file\u0027] is not None\n        have_durable \u003d results.get(\u0027durable_frag_set\u0027) is not None\n        have_frag_prefs \u003d frag_prefs is not None\n        if have_data_file:\n            # data_file should be durable unless frag_prefs are specified\n            return have_durable or have_frag_prefs\n        else:\n            # no data_file better not have a durable\n            return not have_durable\n\nmeh?","commit_id":"9c513f0ce909182ef63454fd7eff809d43405bef"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"5737a0d21113d60b1aced67430a1b87156fa860d","unresolved":false,"context_lines":[{"line_number":3018,"context_line":"            return False"},{"line_number":3019,"context_line":"        if have_data_file and not have_durable and frag_prefs is None:"},{"line_number":3020,"context_line":"            return False"},{"line_number":3021,"context_line":"        return True"},{"line_number":3022,"context_line":""},{"line_number":3023,"context_line":"    def _update_suffix_hashes(self, hashes, ondisk_info):"},{"line_number":3024,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d30b0c7c","line":3021,"in_reply_to":"7a8ec9b2_2bb6853d","updated":"2016-09-20 08:42:50.000000000","message":"I\u0027m wondering if we can just\n\n if frag_prefs is None:\n    have_data_file \u003d results[\u0027data_file\u0027] is None\n    have_durable \u003d results.get(\u0027durable_frag_set\u0027) is None\n    # return True only if that is durable data file or no durable/data file\n    return have_data_file \u003d\u003d have_durable\n else:\n    return True\n\n???\n\nActually, this works and I\u0027m curious, actually, if we need some extra verification on frag_prefs is not None case.","commit_id":"9c513f0ce909182ef63454fd7eff809d43405bef"}]}