)]}'
{"test/unit/common/middleware/crypto/test_encrypter.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"7b5c4fc2f19091e593547520b73fba8816cbadb3","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from six.moves.urllib import parse"},{"line_number":25,"context_line":"from swift.common.middleware.crypto import encrypter"},{"line_number":26,"context_line":"from swift.common.middleware.crypto.crypto_utils import ("},{"line_number":27,"context_line":"    CRYPTO_KEY_CALLBACK, Crypto)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_ca1fdb07","line":24,"range":{"start_line":24,"start_character":29,"end_line":24,"end_character":34},"updated":"2016-09-28 09:30:24.000000000","message":"I suggest to use \"... import parse as urllib_parse\", because \"parse\" is a generic name which can be confusing.\n\nOr better: \"from six.moves import urllib\" and then use \"urllib.parse\" ;-)","commit_id":"3a448ae0683c8e6f5a71cf979e3f3a8f2ce913d5"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"7349172c3fae6ebb37fd23d7ecb5f004e1c7931b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from six.moves.urllib import parse"},{"line_number":25,"context_line":"from swift.common.middleware.crypto import encrypter"},{"line_number":26,"context_line":"from swift.common.middleware.crypto.crypto_utils import ("},{"line_number":27,"context_line":"    CRYPTO_KEY_CALLBACK, Crypto)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_ea92d2f5","line":24,"range":{"start_line":24,"start_character":29,"end_line":24,"end_character":34},"in_reply_to":"5a8bc5a2_ca1fdb07","updated":"2016-09-28 11:01:42.000000000","message":"Thanks for you advice. I will use urlparse as alias\nlike other modules of the project.","commit_id":"3a448ae0683c8e6f5a71cf979e3f3a8f2ce913d5"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e7e66318d6b5db147464ba383ccf419bafc9646b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from six.moves.urllib import parse as urlparse"},{"line_number":25,"context_line":"from swift.common.middleware.crypto import encrypter"},{"line_number":26,"context_line":"from swift.common.middleware.crypto.crypto_utils import ("},{"line_number":27,"context_line":"    CRYPTO_KEY_CALLBACK, Crypto)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_7ee684e9","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":14},"updated":"2016-09-28 12:33:29.000000000","message":"Oh, since it\u0027s a third party import, the import should be moved after mock: http://docs.openstack.org/developer/hacking/#imports","commit_id":"52473ea39277f6b3d8e7d77564189da6b1aec7c3"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"17fcaeb196b0e276c448a4c88d95dd1b71bdc33f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from six.moves.urllib import parse as urlparse"},{"line_number":25,"context_line":"from swift.common.middleware.crypto import encrypter"},{"line_number":26,"context_line":"from swift.common.middleware.crypto.crypto_utils import ("},{"line_number":27,"context_line":"    CRYPTO_KEY_CALLBACK, Crypto)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_bf2f53f5","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":14},"in_reply_to":"5a8bc5a2_7ee684e9","updated":"2016-09-28 12:48:08.000000000","message":"I use it as a module and it follows the guideline. So I think it doesn\u0027t matter to write like this.","commit_id":"52473ea39277f6b3d8e7d77564189da6b1aec7c3"}]}