)]}'
{"test/unit/common/test_db_replicator.py":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"0d39a86f4ca50448bff9f3b5df58bf615c428e29","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"            # Shows that rmdir was called with no db files, but with and"},{"line_number":1264,"context_line":"            # existing file in place, and the exception was handled"},{"line_number":1265,"context_line":"            self.assertEqual("},{"line_number":1266,"context_line":"                rmdir_calls, [dir_with_existing_file])"},{"line_number":1267,"context_line":"        finally:"},{"line_number":1268,"context_line":"            db_replicator.os.listdir \u003d orig_listdir"},{"line_number":1269,"context_line":"            db_replicator.os.path.isdir \u003d orig_isdir"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_282ed0fa","line":1266,"updated":"2016-10-10 11:11:35.000000000","message":"This is happening because dir_with_existing_file does not have a .db file, which the new code checks. I already make this assertion the parent patch to this: https://review.openstack.org/#/c/331601","commit_id":"74244861d6b974fe5592db4e3de3d4073edac5a3"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"9c3e0680666f20221a75a41618928e30679731e8","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"            # Shows that rmdir was called with no db files, but with and"},{"line_number":1264,"context_line":"            # existing file in place, and the exception was handled"},{"line_number":1265,"context_line":"            self.assertEqual("},{"line_number":1266,"context_line":"                rmdir_calls, [dir_with_existing_file])"},{"line_number":1267,"context_line":"        finally:"},{"line_number":1268,"context_line":"            db_replicator.os.listdir \u003d orig_listdir"},{"line_number":1269,"context_line":"            db_replicator.os.path.isdir \u003d orig_isdir"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_53c81655","line":1266,"in_reply_to":"1a95cdbc_282ed0fa","updated":"2016-10-10 18:21:58.000000000","message":"correct.  It was also useful here to verify that the rmdir was indeed called for the case that was to be tested.  Knowing it was called, and the fact that the test would fail if the rmdir didn\u0027t raise both verify that we attempted to remove a directory but it was non-empty, and then handled.","commit_id":"74244861d6b974fe5592db4e3de3d4073edac5a3"}]}