)]}'
{"test/probe/test_object_metadata_replication.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"32bd3a9ec1e6cf0b671a4ce2fa3206f187b349da","unresolved":false,"context_lines":[{"line_number":851,"context_line":"        #               t1.data: non_manifest"},{"line_number":852,"context_line":"        #               t2.meta"},{"line_number":853,"context_line":"        #           (without X-Static-Large-Object)"},{"line_number":854,"context_line":"        self.int_client \u003d self.make_internal_client("},{"line_number":855,"context_line":"            object_post_as_copy\u003dFalse, pipelines\u003d[\u0027slo\u0027], filters\u003d[\"\"\""},{"line_number":856,"context_line":"            [filter:slo]"},{"line_number":857,"context_line":"            use \u003d egg:swift#slo"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_6f51230e","line":854,"range":{"start_line":854,"start_character":8,"end_line":854,"end_character":13},"updated":"2016-11-25 08:34:43.000000000","message":"nits) since make_internal_client is a member method of this test class, we don\u0027t have to assign the internal client to self.","commit_id":"9bd96daf9ac7311098d253299fc5f764637b6031"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"32bd3a9ec1e6cf0b671a4ce2fa3206f187b349da","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        #               t2.meta"},{"line_number":853,"context_line":"        #           (without X-Static-Large-Object)"},{"line_number":854,"context_line":"        self.int_client \u003d self.make_internal_client("},{"line_number":855,"context_line":"            object_post_as_copy\u003dFalse, pipelines\u003d[\u0027slo\u0027], filters\u003d[\"\"\""},{"line_number":856,"context_line":"            [filter:slo]"},{"line_number":857,"context_line":"            use \u003d egg:swift#slo"},{"line_number":858,"context_line":"            \"\"\"])"},{"line_number":859,"context_line":"        segment_object_name \u003d \u0027object-%s\u0027 % uuid.uuid4()"},{"line_number":860,"context_line":"        self.brain.put_container(policy_index\u003dint(self.policy))"},{"line_number":861,"context_line":"        self.int_client.upload_object(StringIO(u\u0027segment\u0027), self.account,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_0fbb4f28","line":858,"range":{"start_line":855,"start_character":12,"end_line":858,"end_character":17},"updated":"2016-11-25 08:34:43.000000000","message":"Why not using swiftclient instead of mangling internal client setting?\n\nPlease checkout https://gist.github.com/bloodeagle40234/386488450a831a01a62c000ce8ff4239\n\nthat works without the change in test/probe/common.py","commit_id":"9bd96daf9ac7311098d253299fc5f764637b6031"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"32bd3a9ec1e6cf0b671a4ce2fa3206f187b349da","unresolved":false,"context_lines":[{"line_number":867,"context_line":"            self.account, self.container_name, self.object_name)"},{"line_number":868,"context_line":"        self.int_client.make_request("},{"line_number":869,"context_line":"            \u0027PUT\u0027, manifest_path + \u0027?multipart-manifest\u003dput\u0027, {"},{"line_number":870,"context_line":"                \u0027Transfer-Encoding\u0027: \u0027chunked\u0027"},{"line_number":871,"context_line":"            }, (2,), manifest_body)"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        self.brain.stop_primary_half()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_afb89be6","line":870,"range":{"start_line":870,"start_character":16,"end_line":870,"end_character":46},"updated":"2016-11-25 08:34:43.000000000","message":"To be concrete testing, it\u0027s worth to make the request with content-length rather than transfar-encoding chunked. And if we are using swiftclient instead, we don\u0027t need it anyway.","commit_id":"9bd96daf9ac7311098d253299fc5f764637b6031"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"32bd3a9ec1e6cf0b671a4ce2fa3206f187b349da","unresolved":false,"context_lines":[{"line_number":875,"context_line":"        self.brain.start_primary_half()"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"        self.brain.stop_handoff_half()"},{"line_number":878,"context_line":"        self._post_object({})"},{"line_number":879,"context_line":"        self.brain.start_handoff_half()"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        # run replicator"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_0ff34fd7","line":878,"range":{"start_line":878,"start_character":7,"end_line":878,"end_character":29},"updated":"2016-11-25 08:34:43.000000000","message":"Is it worth to add some metadata as t2 and to assert the metadata will be in the get response at L884.\n\nAnd it seems also worth that older metadata won\u0027t appear there.","commit_id":"9bd96daf9ac7311098d253299fc5f764637b6031"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"32bd3a9ec1e6cf0b671a4ce2fa3206f187b349da","unresolved":false,"context_lines":[{"line_number":883,"context_line":""},{"line_number":884,"context_line":"        _, headers, app_iter \u003d self._get_object()"},{"line_number":885,"context_line":"        self.assertNotIn(\u0027x-static-large-object\u0027, headers)"},{"line_number":886,"context_line":"        self.assertEqual(u\u0027new_obj\u0027, [i for i in app_iter][0])"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_2f172bee","line":886,"range":{"start_line":886,"start_character":36,"end_line":886,"end_character":61},"updated":"2016-11-25 08:34:43.000000000","message":"Probably it should be\n\n \u0027\u0027.join(chunk for chunk in app_iter)\n\nto assert no other content included in the response body.","commit_id":"9bd96daf9ac7311098d253299fc5f764637b6031"}]}