)]}'
{"etc/proxy-server.conf-sample":[{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"4c61d90e4c556e2a0f2cb8a2376ed48e313a4452","unresolved":false,"context_lines":[{"line_number":141,"context_line":"# \u0027false\u0027 no one, even authorized, can."},{"line_number":142,"context_line":"# allow_account_management \u003d false"},{"line_number":143,"context_line":"#"},{"line_number":144,"context_line":"# If set to \u0027true\u0027 authorized accounts that do not yet exist within the Swift"},{"line_number":145,"context_line":"# cluster will be automatically created."},{"line_number":146,"context_line":"# account_autocreate \u003d true"},{"line_number":147,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa6399be_3ae9fde6","line":144,"updated":"2016-10-14 04:18:22.000000000","message":"change the comment to address setting to \u0027false\u0027 instead.  Seems like the pattern in this file is for the comments to explain what would happen if you changed the value away from default.","commit_id":"361779147175bbc723e25abee4f83953ef13c39b"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"4c6f827a77dbddb54f43b305c931f4d9b397f307","unresolved":false,"context_lines":[{"line_number":7800,"context_line":"        with save_globals():"},{"line_number":7801,"context_line":"            controller \u003d proxy_server.AccountController(self.app, \u0027a\u0027)"},{"line_number":7802,"context_line":"            self.app.memcache \u003d FakeMemcacheReturnsNone()"},{"line_number":7803,"context_line":"            self.app.account_autocreate \u003d False"},{"line_number":7804,"context_line":"            # Repeat the test for autocreate \u003d False and 404 by all"},{"line_number":7805,"context_line":"            self.assert_status_map(controller.GET,"},{"line_number":7806,"context_line":"                                   (404, 404, 404), 404)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_2a01c405","line":7803,"updated":"2016-10-13 12:28:03.000000000","message":"I think instead of just changing the value to False, we should  test the output when account_autocreate is True, since that is now our default value and the test names (test_GET_autocreate for e.g.) indicate that\u0027s what we intend to test.\nThis applies for changes below as well, where you\u0027ve changed the config value to False, instead of asserting the output when it\u0027s True.","commit_id":"a4896be0ed9f10b13e5e63f100b7e89d6d40d527"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"a4c3d17f50ecd19b222b4207a773ea4d01b88db4","unresolved":false,"context_lines":[{"line_number":7800,"context_line":"        with save_globals():"},{"line_number":7801,"context_line":"            controller \u003d proxy_server.AccountController(self.app, \u0027a\u0027)"},{"line_number":7802,"context_line":"            self.app.memcache \u003d FakeMemcacheReturnsNone()"},{"line_number":7803,"context_line":"            self.app.account_autocreate \u003d False"},{"line_number":7804,"context_line":"            # Repeat the test for autocreate \u003d False and 404 by all"},{"line_number":7805,"context_line":"            self.assert_status_map(controller.GET,"},{"line_number":7806,"context_line":"                                   (404, 404, 404), 404)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_201c83c0","line":7803,"in_reply_to":"fa6399be_0580718a","updated":"2016-10-13 13:07:00.000000000","message":"ah sorry I didn\u0027t observe that there\u0027s a test for True as well in here.\nMy comment belongs below for test_HEAD_autocreate, test_POST_autocreate etc where we\u0027re not testing the True value. And I think the idea was to test the default value which in this case is True.","commit_id":"a4896be0ed9f10b13e5e63f100b7e89d6d40d527"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"c121dff79054593b390b85efd6a2c010a80ebdf8","unresolved":false,"context_lines":[{"line_number":7800,"context_line":"        with save_globals():"},{"line_number":7801,"context_line":"            controller \u003d proxy_server.AccountController(self.app, \u0027a\u0027)"},{"line_number":7802,"context_line":"            self.app.memcache \u003d FakeMemcacheReturnsNone()"},{"line_number":7803,"context_line":"            self.app.account_autocreate \u003d False"},{"line_number":7804,"context_line":"            # Repeat the test for autocreate \u003d False and 404 by all"},{"line_number":7805,"context_line":"            self.assert_status_map(controller.GET,"},{"line_number":7806,"context_line":"                                   (404, 404, 404), 404)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_0580718a","line":7803,"in_reply_to":"fa6399be_2a01c405","updated":"2016-10-13 13:00:30.000000000","message":"I think the one who wrote this test want to show the difference behaviors of \"account_autocreate\u003dFalse\" and \"account_autocreate\u003dTrue\". So I kept both of them.\nYou mean we should delete the tests for \"account_autocreate\u003dFalse\" in test_GET_autocreate?","commit_id":"a4896be0ed9f10b13e5e63f100b7e89d6d40d527"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"4c61d90e4c556e2a0f2cb8a2376ed48e313a4452","unresolved":false,"context_lines":[{"line_number":6819,"context_line":"            test_status_map((200, 201, 201, 201), 201, missing_container\u003dTrue)"},{"line_number":6820,"context_line":"            test_status_map((200, 201, 201, 500), 201, missing_container\u003dTrue)"},{"line_number":6821,"context_line":"            test_status_map((200, 204, 404, 404), 404, missing_container\u003dTrue)"},{"line_number":6822,"context_line":"            test_status_map((200, 204, 500, 404), 503, missing_container\u003dTrue)"},{"line_number":6823,"context_line":"            test_status_map((404, 404, 404), 404, missing_container\u003dTrue)"},{"line_number":6824,"context_line":"            self.app.account_autocreate \u003d False"},{"line_number":6825,"context_line":"            test_status_map((404, 404, 404), 404, missing_container\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_77b9c314","line":6822,"updated":"2016-10-14 04:18:22.000000000","message":"I think I\u0027d put the self.app.account_autocreate \u003d False on line 6823, and then put self.app.account_autocreate \u003d True on what will be line 6825 : just before the last call to test_status_map.  That way, the test cases remain the same as they were before.","commit_id":"361779147175bbc723e25abee4f83953ef13c39b"}]}