)]}'
{"swift/obj/updater.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"fc27ae21e2babcac5eb3cd35278d4014825748d1","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            update[\u0027account\u0027], update[\u0027container\u0027])"},{"line_number":221,"context_line":"        obj \u003d \u0027/%s/%s/%s\u0027 % \\"},{"line_number":222,"context_line":"              (update[\u0027account\u0027], update[\u0027container\u0027], update[\u0027obj\u0027])"},{"line_number":223,"context_line":"        headers_out \u003d HeaderKeyDict(update[\u0027headers\u0027])"},{"line_number":224,"context_line":"        headers_out[\u0027user-agent\u0027] \u003d \u0027object-updater %s\u0027 % os.getpid()"},{"line_number":225,"context_line":"        headers_out.setdefault(\u0027X-Backend-Storage-Policy-Index\u0027,"},{"line_number":226,"context_line":"                               str(int(policy)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6895a0_10182784","line":223,"range":{"start_line":223,"start_character":36,"end_line":223,"end_character":53},"updated":"2016-10-21 10:02:25.000000000","message":"I was wondering update dict from pickle file keeps HeaderKeyDict and it\u0027s true, object-server saves the headers as HeaderKeyDict. However, I think current one is better to ensure the headers_out is an instance of HeaderKeyDict and it ensures the header key is case insensitive","commit_id":"396bdb639dc63fd814f7c9d00168a4eb797ff7aa"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c6cd09b02bd30a9cac08401064f1b0bc2a65f1af","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            update[\u0027account\u0027], update[\u0027container\u0027])"},{"line_number":221,"context_line":"        obj \u003d \u0027/%s/%s/%s\u0027 % \\"},{"line_number":222,"context_line":"              (update[\u0027account\u0027], update[\u0027container\u0027], update[\u0027obj\u0027])"},{"line_number":223,"context_line":"        headers_out \u003d HeaderKeyDict(update[\u0027headers\u0027])"},{"line_number":224,"context_line":"        headers_out[\u0027user-agent\u0027] \u003d \u0027object-updater %s\u0027 % os.getpid()"},{"line_number":225,"context_line":"        headers_out.setdefault(\u0027X-Backend-Storage-Policy-Index\u0027,"},{"line_number":226,"context_line":"                               str(int(policy)))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_b3ac8ba1","line":223,"updated":"2016-11-16 18:22:18.000000000","message":"+1 this also avoids a regression if the object server changed to set a lower case x-backend-storage-policy-index","commit_id":"e166e19b235e1fba8e5eba5720d1c07fe32c40c1"}],"test/unit/obj/test_server.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"789724128ca384f44c59c1b1f6be30e9308757b9","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        actual_headers \u003d mock_update.call_args_list[0][0][4]"},{"line_number":1019,"context_line":"        self.assertTrue("},{"line_number":1020,"context_line":"            actual_headers.pop(\u0027User-Agent\u0027).startswith(\u0027object-updater\u0027))"},{"line_number":1021,"context_line":"        del expected_post_headers[\u0027User-Agent\u0027]"},{"line_number":1022,"context_line":"        self.assertDictEqual(expected_post_headers, actual_headers)"},{"line_number":1023,"context_line":"        self.assertFalse("},{"line_number":1024,"context_line":"            os.listdir(os.path.join("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_ca9053f0","line":1021,"updated":"2016-10-20 05:48:18.000000000","message":"I think, just creating a new expected_post_headers for updaters like\n\n # object updater updates the User-Agent so overwrite the value here as expected.\n expected_post_headers[\u0027User-Agent\u0027] \u003d \u0027object-updater %s\u0027 % os.getpid()\n\nand then\n\n self.assertDictEqual(expected_post_headers, actual_headers)\n\nseems enough.","commit_id":"05e4d389c4e27f024f8b83ff201f61fc1a7ffc01"}]}