)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"20f2142d0b4cb838d45c1c02d66f08684ecd763b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"get_tmp_dir \u003d partial(get_policy_string, TMP_BASE)"},{"line_number":92,"context_line":"MIN_TIME_UPDATE_AUDITOR_STATUS \u003d 60"},{"line_number":93,"context_line":"# This matches rsync tempfiles, like \".\u003ctimestamp\u003e.data.Xy095a\""},{"line_number":94,"context_line":"RE_RSYNC_TEMPFILE \u003d re.compile(r\u0027^\\..*\\.([a-zA-Z0-9_]){6}$\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_filename(fd):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_c36b87b5","line":94,"updated":"2016-11-11 11:48:43.000000000","message":"+1 define it ONCE","commit_id":"4be4181a355ddebd4439b9d41b9fc0d9c39ed360"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"20f2142d0b4cb838d45c1c02d66f08684ecd763b","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        self.pipe_size \u003d None"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        # regex for rsync temp files e.g. \u0027.1472017820.44503.data.QBYCYU\u0027"},{"line_number":567,"context_line":"        self.rsync_temp_file_exp \u003d RE_RSYNC_TEMPFILE"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        conf_wants_splice \u003d config_true_value(conf.get(\u0027splice\u0027, \u0027no\u0027))"},{"line_number":570,"context_line":"        # If the operator wants zero-copy with splice() but we don\u0027t have the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_a3593337","line":567,"updated":"2016-11-11 11:48:43.000000000","message":"no longer used","commit_id":"4be4181a355ddebd4439b9d41b9fc0d9c39ed360"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"341661b429c2fda9d982fe39e17c811e10cda62f","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        self.pipe_size \u003d None"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        # regex for rsync temp files e.g. \u0027.1472017820.44503.data.QBYCYU\u0027"},{"line_number":567,"context_line":"        self.rsync_temp_file_exp \u003d RE_RSYNC_TEMPFILE"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"        conf_wants_splice \u003d config_true_value(conf.get(\u0027splice\u0027, \u0027no\u0027))"},{"line_number":570,"context_line":"        # If the operator wants zero-copy with splice() but we don\u0027t have the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_f4d83555","line":567,"in_reply_to":"9a629dbe_a3593337","updated":"2016-11-11 17:06:31.000000000","message":"nice catch","commit_id":"4be4181a355ddebd4439b9d41b9fc0d9c39ed360"}],"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"20f2142d0b4cb838d45c1c02d66f08684ecd763b","unresolved":false,"context_lines":[{"line_number":786,"context_line":"                        \u0027Unexpected file %s\u0027"},{"line_number":787,"context_line":"                        % os.path.join(datadir, unexpected)))"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"    def test_get_ondisk_files_no_rsync_temp_file_warning(self):"},{"line_number":790,"context_line":"        # get_ondisk_files logs no warnings for rsync temp files"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        class_under_test \u003d self._get_diskfile(POLICIES[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_e3cc0b8b","line":789,"updated":"2016-11-11 11:48:43.000000000","message":"this is overridden by the existing method of same name in TestDiskFileManager but is included in TestECDiskFileManager??? My guess is you intended to delete the method in TestDiskFileManager.","commit_id":"4be4181a355ddebd4439b9d41b9fc0d9c39ed360"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f57afaacf1eb7386e8522f9c4cf7dff766307792","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        class_under_test \u003d self._get_diskfile(POLICIES[0])"},{"line_number":793,"context_line":"        files \u003d ["},{"line_number":794,"context_line":"            \u0027.1472017820.44503.data.QBYCYU\u0027,  # rsync tempfile for a .data"},{"line_number":795,"context_line":"            \u0027.total-bs.abcdef\u0027,   # example of false positive"},{"line_number":796,"context_line":"        ]"},{"line_number":797,"context_line":"        paths \u003d [os.path.join(class_under_test._datadir, f) for f in files]"},{"line_number":798,"context_line":"        expected \u003d {\u0027unexpected\u0027: paths}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_b402b26d","line":795,"updated":"2016-10-31 23:10:40.000000000","message":"Though we\u0027ll totally still clean this up, no?\n\nMaybe we want a more precise regex? Does\n\n r\u0027\\.[0-9]{10}\\.{5}(_[0-9a-f]{16})?\\.(data|ts|meta)\\.[0-9a-zA-Z_]{6}$\u0027\n\ncover us?\n\nOnly, I suppose we still want the auditor to clean up the tempfiles-of-tempfiles fallout from bug 1553995 / bug 1554005... Maybe\n\n r\u0027\\.+[0-9]{10}\\.{5}(_[0-9a-f]{16})?\\..+\\.[0-9a-zA-Z_]{6}$\u0027\n\nis better?","commit_id":"4be4181a355ddebd4439b9d41b9fc0d9c39ed360"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"b5ad4fa6f3e02eba50001f7c3b589e32836daec8","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        class_under_test \u003d self._get_diskfile(POLICIES[0])"},{"line_number":793,"context_line":"        files \u003d ["},{"line_number":794,"context_line":"            \u0027.1472017820.44503.data.QBYCYU\u0027,  # rsync tempfile for a .data"},{"line_number":795,"context_line":"            \u0027.total-bs.abcdef\u0027,   # example of false positive"},{"line_number":796,"context_line":"        ]"},{"line_number":797,"context_line":"        paths \u003d [os.path.join(class_under_test._datadir, f) for f in files]"},{"line_number":798,"context_line":"        expected \u003d {\u0027unexpected\u0027: paths}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_943ccee3","line":795,"in_reply_to":"ba5da102_b402b26d","updated":"2016-10-31 23:32:31.000000000","message":"and it\u0027ll be a constant thorn in our side to keep it updated as we make adjustments to the data file format.  I like the current regex.\n\nI acctually don\u0027t care *that* much if we log a debug message or not.  I\u0027d much prefer to remove the debug message than change the regex if that\u0027s your concern.\n\nMainly I thought it would be useful if down the road I was pissed about some garbage in the datadir and the warning was being skipped (and yes, pulled out after a timeout by the auditor) and I didn\u0027t know *why* it wasn\u0027t warning - turning on debugging would communicate \"ah, the diskfile code is incorrectly classifying as a rsync tempfile\"\n\n... but future me could probably catch that from staring at the code too.","commit_id":"4be4181a355ddebd4439b9d41b9fc0d9c39ed360"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"341661b429c2fda9d982fe39e17c811e10cda62f","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"        class_under_test._get_ondisk_files(files)"},{"line_number":1271,"context_line":"        lines \u003d self.logger.get_lines_for_level(\u0027warning\u0027)"},{"line_number":1272,"context_line":"        self.assertFalse(lines)"},{"line_number":1273,"context_line":""},{"line_number":1274,"context_line":"    def test_verify_ondisk_files(self):"},{"line_number":1275,"context_line":"        # ._verify_ondisk_files should only return False if get_ondisk_files"},{"line_number":1276,"context_line":"        # has produced a bad set of files due to a bug, so to test it we need"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_94c7f962","line":1273,"updated":"2016-11-11 17:06:31.000000000","message":"yes, i was trying to \"move\" this test and then improve it - i\u0027m not sure I really even noticed it was supposed to be running twice - i *must* have noticed it was running *somewhere* when I was developing in (!?)","commit_id":"4be4181a355ddebd4439b9d41b9fc0d9c39ed360"}]}