)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"7c527ae2ca0d867e0e52342b8503321fb5cc36d8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use /var/run/syslog on macosx for syslog tests."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This patch is based on zaictev review."},{"line_number":10,"context_line":"- Fixes bug 1206560."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I41f3d485df41fe443784f803b276712405fe72c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAQn%2F%2FJUE%3D","line":9,"updated":"2013-08-06 13:36:00.000000000","message":"Yes, I see the miss-spelling, but I don\u0027t care. Just letting you know that I read the commit message too.","commit_id":"64756f8d17adf55d8c2cdf2413023a451ea9d566"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"6689a269c229ca9b7a9dfb8fe2a3c9f64ac63caa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use /var/run/syslog on macosx for syslog tests."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This patch is based on zaictev review."},{"line_number":10,"context_line":"- Fixes bug 1206560."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I41f3d485df41fe443784f803b276712405fe72c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAQn%2F%2FJTQ%3D","line":9,"in_reply_to":"AAAAQn%2F%2FJUE%3D","updated":"2013-08-06 13:38:29.000000000","message":"oops... yes that was all part of the plan if you were reading that commit msg :)","commit_id":"64756f8d17adf55d8c2cdf2413023a451ea9d566"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b0297814bd92d721a7309717720016bd26934a41","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        syslog_handler_catcher.LOG_LOCAL3 \u003d orig_sysloghandler.LOG_LOCAL3"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        try:"},{"line_number":431,"context_line":"            log_address \u003d None"},{"line_number":432,"context_line":"            # Use /var/run/syslog on macosx since /dev/log doesn\u0027t"},{"line_number":433,"context_line":"            # exist and the test will fail."},{"line_number":434,"context_line":"            if sys.platform \u003d\u003d \u0027darwin\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FKtM%3D","line":431,"updated":"2013-08-06 03:35:03.000000000","message":"You\u0027re quetly replacing \u0027/dev/log\u0027 with None. How legitimate is this? Is it going to switch to IP?","commit_id":"4b0825127496545342a7c1a2c4e4d6a8b185a719"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"53f1ce25e4171051d5c71dcac3cff7c952ace55c","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        syslog_handler_catcher.LOG_LOCAL3 \u003d orig_sysloghandler.LOG_LOCAL3"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        try:"},{"line_number":431,"context_line":"            log_address \u003d None"},{"line_number":432,"context_line":"            # Use /var/run/syslog on macosx since /dev/log doesn\u0027t"},{"line_number":433,"context_line":"            # exist and the test will fail."},{"line_number":434,"context_line":"            if sys.platform \u003d\u003d \u0027darwin\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FKrw%3D","line":431,"in_reply_to":"AAAAQn%2F%2FKtM%3D","updated":"2013-08-06 03:47:05.000000000","message":"as mentioned here https://github.com/openstack/swift/blob/master/swift/common/utils.py#L920 if log_address is None it will default to /dev/log by the .get thing.","commit_id":"4b0825127496545342a7c1a2c4e4d6a8b185a719"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b0297814bd92d721a7309717720016bd26934a41","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            log_address \u003d None"},{"line_number":432,"context_line":"            # Use /var/run/syslog on macosx since /dev/log doesn\u0027t"},{"line_number":433,"context_line":"            # exist and the test will fail."},{"line_number":434,"context_line":"            if sys.platform \u003d\u003d \u0027darwin\u0027:"},{"line_number":435,"context_line":"                log_address \u003d \u0027/var/run/syslog\u0027"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"            utils.SysLogHandler \u003d syslog_handler_catcher"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FKtE%3D","line":434,"updated":"2013-08-06 03:35:03.000000000","message":"Not testing with os.path.isfile(), why is that? Sure this is future-proof?","commit_id":"4b0825127496545342a7c1a2c4e4d6a8b185a719"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"53f1ce25e4171051d5c71dcac3cff7c952ace55c","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            log_address \u003d None"},{"line_number":432,"context_line":"            # Use /var/run/syslog on macosx since /dev/log doesn\u0027t"},{"line_number":433,"context_line":"            # exist and the test will fail."},{"line_number":434,"context_line":"            if sys.platform \u003d\u003d \u0027darwin\u0027:"},{"line_number":435,"context_line":"                log_address \u003d \u0027/var/run/syslog\u0027"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"            utils.SysLogHandler \u003d syslog_handler_catcher"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FKsA%3D","line":434,"in_reply_to":"AAAAQn%2F%2FKtE%3D","updated":"2013-08-06 03:47:05.000000000","message":"I guess as much /dev/log is future-proof, i can stat.S_ISSOCK in here https://github.com/openstack/swift/blob/master/swift/common/utils.py#L920 if you think that would make it more \u0027bullet-proof\u0027","commit_id":"4b0825127496545342a7c1a2c4e4d6a8b185a719"}]}