)]}'
{"go/client/client.go":[{"author":{"_account_id":23641,"name":"Jeff Li","email":"jafelee@gmail.com","username":"jeffli"},"change_message_id":"0b93300ccd126ebd70a279d14d37ea2807ca3d7c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"\tGetContainer(account string, container string, options map[string]string, headers http.Header) (io.ReadCloser, http.Header, int)"},{"line_number":61,"context_line":"\tHeadContainer(account string, container string, headers http.Header) (http.Header, int)"},{"line_number":62,"context_line":"\tDeleteContainer(account string, container string, headers http.Header) int"},{"line_number":63,"context_line":"\tPutObject(account string, container string, obj string, policy int, headers http.Header, src io.Reader) int"},{"line_number":64,"context_line":"\tPostObject(account string, container string, obj string, policy int, headers http.Header) int"},{"line_number":65,"context_line":"\tGetObject(account string, container string, obj string, policy int, headers http.Header) (io.ReadCloser, http.Header, int)"},{"line_number":66,"context_line":"\tHeadObject(account string, container string, obj string, policy int, headers http.Header) (http.Header, int)"}],"source_content_type":"text/x-go","patch_set":2,"id":"9a629dbe_3bc74865","line":63,"updated":"2016-11-10 05:54:13.000000000","message":"Hi Pete, have you considered to refactor the ProxyClient API with the context facility?  For me, the current API has some issues. First, it is not easy to change the parameter list. Take this patch for example, you have to add an extra parameter which changes the signature of the method thus will causes extra code modification. Second, some headers from the backend servers will be lost. Currently the HTTP handlers can only grab the http status through the ProxyClient API. Take the proxy server\u0027s PUT handler as an example, it does not send back the etag. When I tried to add the etag header, I have to changed the signature of the method and a whole bunch of code has to be taken care of. \nIf we leverage the context facility to carry the request scope data, the API can stay much more stable.","commit_id":"886ab0511280abf3b2b20773bc2a2bd1697b1a2a"}]}