)]}'
{"etc/proxy-server.conf-sample":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d7dc210a94197b26359804e548c6b9389515f8a3","unresolved":false,"context_lines":[{"line_number":808,"context_line":"# If you don\u0027t put it in the pipeline, it will be inserted for you."},{"line_number":809,"context_line":"[filter:copy]"},{"line_number":810,"context_line":"use \u003d egg:swift#copy"},{"line_number":811,"context_line":"# By default, object POST requests only store metadata anew, while the original"},{"line_number":812,"context_line":"# data file is kept in place."},{"line_number":813,"context_line":"# Set this to True to enable the old, slow behavior wherein object POST"},{"line_number":814,"context_line":"# requests are transformed into COPY requests where source and destination are"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ba5201f7_b56cff08","line":811,"updated":"2017-01-06 12:24:53.000000000","message":"nit: the use of \"only\" here could be inferred as a weakness.\n\nmaybe \"By default object POST requests update metadata without modification of the original data file.\"","commit_id":"0b65fd381dacc76af1c050877baf05d8ef6abbb6"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"59802147de6f46fcb51ed7b98a529d9ef8520c3a","unresolved":false,"context_lines":[{"line_number":808,"context_line":"# If you don\u0027t put it in the pipeline, it will be inserted for you."},{"line_number":809,"context_line":"[filter:copy]"},{"line_number":810,"context_line":"use \u003d egg:swift#copy"},{"line_number":811,"context_line":"# By default, object POST requests only store metadata anew, while the original"},{"line_number":812,"context_line":"# data file is kept in place."},{"line_number":813,"context_line":"# Set this to True to enable the old, slow behavior wherein object POST"},{"line_number":814,"context_line":"# requests are transformed into COPY requests where source and destination are"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a3905b3_eb3d24bc","line":811,"in_reply_to":"ba5201f7_b56cff08","updated":"2017-01-20 17:37:36.000000000","message":"Done","commit_id":"0b65fd381dacc76af1c050877baf05d8ef6abbb6"}],"swift/common/middleware/copy.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d7dc210a94197b26359804e548c6b9389515f8a3","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            msg \u003d (\u0027object_post_as_copy\u003dtrue is deprecated; remove it \u0027"},{"line_number":280,"context_line":"                   \u0027from %s to disable this warning. This option will \u0027"},{"line_number":281,"context_line":"                   \u0027be ignored in a future release\u0027 % conf.get("},{"line_number":282,"context_line":"                       \u0027__file__\u0027, \u0027proxy-server.conf\u0027))"},{"line_number":283,"context_line":"            self.logger.warning(msg)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def _load_object_post_as_copy_conf(self, conf):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_c2a46b09","line":282,"updated":"2017-01-06 12:24:53.000000000","message":"hmmm, might be worth mentioning that it should be removed from both the filter:copy and the proxy app sections of conf file. I can imagine an op looking in copy filter section, not seeing the option, and then getting confused, because it is in fact being read from proxy-server section.\n\nOn other hand that is quite verbose :/ A compromise might be s/remove it/remove ALL references to it/","commit_id":"0b65fd381dacc76af1c050877baf05d8ef6abbb6"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"59802147de6f46fcb51ed7b98a529d9ef8520c3a","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            msg \u003d (\u0027object_post_as_copy\u003dtrue is deprecated; remove it \u0027"},{"line_number":280,"context_line":"                   \u0027from %s to disable this warning. This option will \u0027"},{"line_number":281,"context_line":"                   \u0027be ignored in a future release\u0027 % conf.get("},{"line_number":282,"context_line":"                       \u0027__file__\u0027, \u0027proxy-server.conf\u0027))"},{"line_number":283,"context_line":"            self.logger.warning(msg)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def _load_object_post_as_copy_conf(self, conf):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_8bb580ef","line":282,"in_reply_to":"ba5201f7_c2a46b09","updated":"2017-01-20 17:37:36.000000000","message":"Done","commit_id":"0b65fd381dacc76af1c050877baf05d8ef6abbb6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f3eb5f3e654c714f0a50e03d8e44bb673371c08e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"greater than 5GB."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"-------------------"},{"line_number":116,"context_line":"Object Post as Copy"},{"line_number":117,"context_line":"-------------------"},{"line_number":118,"context_line":"Historically, this has been a feature (and a configurable option with default"},{"line_number":119,"context_line":"set to True) in proxy server configuration. This has been moved to server side"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_e396ed3c","line":116,"updated":"2017-01-23 11:14:18.000000000","message":"nit: Add \"(Deprecated)\" to the title\n\nthis really is a nit, ignore unless another patchset is needed for another reason","commit_id":"4ee20dba482e8f8e4b9ea574428c72c5728a10a1"}],"test/unit/common/middleware/test_copy.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d7dc210a94197b26359804e548c6b9389515f8a3","unresolved":false,"context_lines":[{"line_number":1538,"context_line":"        [filter:copy]"},{"line_number":1539,"context_line":"        use \u003d egg:swift#copy"},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"        [app:ye-olde-proxy-server]"},{"line_number":1542,"context_line":"        use \u003d egg:swift#proxy"},{"line_number":1543,"context_line":"        object_post_as_copy \u003d yes"},{"line_number":1544,"context_line":"        \"\"\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_751b7781","line":1541,"updated":"2017-01-06 12:24:53.000000000","message":"love it! very quaint","commit_id":"0b65fd381dacc76af1c050877baf05d8ef6abbb6"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"468b56d54acb8887f2f79bc9c7a398acb504f416","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"            container_ring\u003dFakeRing(), logger\u003dself.logger)"},{"line_number":1570,"context_line":"        self.ssc \u003d copy.filter_factory({"},{"line_number":1571,"context_line":"            \u0027object_post_as_copy\u0027: \u0027yes\u0027,"},{"line_number":1572,"context_line":"        })(self.app)"},{"line_number":1573,"context_line":"        self.ssc.logger \u003d self.app.logger"},{"line_number":1574,"context_line":"        self.policy \u003d POLICIES.default"},{"line_number":1575,"context_line":"        self.app.container_info \u003d dict(self.container_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_bf63c8af","line":1572,"updated":"2017-01-24 16:43:55.000000000","message":"The post-as-copy is being set to true here and at line 96.  Would it be best to switch the default used here to be false, or is the intent to specifically test the copies done for the following posts?  I just wonder if we would rather be performing the bulk of the tests with the default configuration.","commit_id":"4ee20dba482e8f8e4b9ea574428c72c5728a10a1"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"f41b124516415c2eadbf6d7199700204014b11ef","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"            container_ring\u003dFakeRing(), logger\u003dself.logger)"},{"line_number":1570,"context_line":"        self.ssc \u003d copy.filter_factory({"},{"line_number":1571,"context_line":"            \u0027object_post_as_copy\u0027: \u0027yes\u0027,"},{"line_number":1572,"context_line":"        })(self.app)"},{"line_number":1573,"context_line":"        self.ssc.logger \u003d self.app.logger"},{"line_number":1574,"context_line":"        self.policy \u003d POLICIES.default"},{"line_number":1575,"context_line":"        self.app.container_info \u003d dict(self.container_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_f55bb183","line":1572,"in_reply_to":"5a3905b3_bf63c8af","updated":"2017-01-24 17:15:30.000000000","message":"@Janie, I think in this particular case it is ok to leave-as-is because these are testing specifically post-as-copy.\n\nWhat I\u0027d expect in a future release, is that once post-as-copy is removed, then this file would be cleaned-up to remove any references to post as copy and leave only COPY tests.","commit_id":"4ee20dba482e8f8e4b9ea574428c72c5728a10a1"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"9425e80bc98bd9e5e6d29e89356c6251e2b7b044","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"            container_ring\u003dFakeRing(), logger\u003dself.logger)"},{"line_number":1570,"context_line":"        self.ssc \u003d copy.filter_factory({"},{"line_number":1571,"context_line":"            \u0027object_post_as_copy\u0027: \u0027yes\u0027,"},{"line_number":1572,"context_line":"        })(self.app)"},{"line_number":1573,"context_line":"        self.ssc.logger \u003d self.app.logger"},{"line_number":1574,"context_line":"        self.policy \u003d POLICIES.default"},{"line_number":1575,"context_line":"        self.app.container_info \u003d dict(self.container_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_27e6e616","line":1572,"in_reply_to":"5a3905b3_f55bb183","updated":"2017-01-24 20:07:27.000000000","message":"Oh, yes - I see that is true with line 96. but for this setUp method, I think the setting of the post-as-copy could be removed.  This is really a nit, though, as it probably doesn\u0027t change the actual behavior in these particular tests (thus the setting could be removed).","commit_id":"4ee20dba482e8f8e4b9ea574428c72c5728a10a1"}],"tox.ini":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d7dc210a94197b26359804e548c6b9389515f8a3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"commands \u003d ./.functests {posargs}"},{"line_number":69,"context_line":"setenv \u003d SWIFT_TEST_IN_PROCESS\u003d1"},{"line_number":70,"context_line":"         SWIFT_TEST_IN_PROCESS_CONF_LOADER\u003dencryption"},{"line_number":71,"context_line":"         SWIFT_TEST_IN_PROCESS_OBJECT_POST_AS_COPY\u003dTrue"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"[testenv:venv]"},{"line_number":74,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"ba5201f7_82bd03da","line":71,"updated":"2017-01-06 12:24:53.000000000","message":"good thought, but I think I\u0027d prefer to know that encryption was being tested with fast-post from now on, since that is the default config. In fact it would be reassuring to have encryption with default fast-post func tests passing be a condition for this patch to land.\n\nfunc-fast-post is now redundant as it tests same config as testenv:func (albeit in-process) so perhaps we should switch that to func-post-as-copy? Shame that will require a change to infra too purely to make the testenv name sane.\n\nHow about creating testenv:func-post-as-copy in this patch which we can run during review, then enable that in the gate, then remove testenv func-fast-post? There would be a window when we are not testing post-as-copy, but arguably that is preferable to not testing encryption with fast-post.\n\nOR (perhaps better, no lapse of config coverage)...\n\nIn this patch switch func-fast-post to use post-as-copy (!), then we follow up with sequence of patches (swift, infra) to make the naming of the testenv sane.\n\nHappy to help with the infra patches.","commit_id":"0b65fd381dacc76af1c050877baf05d8ef6abbb6"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"59802147de6f46fcb51ed7b98a529d9ef8520c3a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"commands \u003d ./.functests {posargs}"},{"line_number":69,"context_line":"setenv \u003d SWIFT_TEST_IN_PROCESS\u003d1"},{"line_number":70,"context_line":"         SWIFT_TEST_IN_PROCESS_CONF_LOADER\u003dencryption"},{"line_number":71,"context_line":"         SWIFT_TEST_IN_PROCESS_OBJECT_POST_AS_COPY\u003dTrue"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"[testenv:venv]"},{"line_number":74,"context_line":"commands \u003d {posargs}"}],"source_content_type":"text/x-properties","patch_set":5,"id":"5a3905b3_813ba19b","line":71,"in_reply_to":"ba5201f7_82bd03da","updated":"2017-01-20 17:37:36.000000000","message":"ok, so here\u0027s what I\u0027ve done for now:\n  1. Set func-fast-post to actually use post-as-copy.\n  2. created a new testenv called func-post-as-copy\n\nOnce this lands, we can change infra to use the new testenv and remove the old one (i.e., func-fast-post).\n\nThen we can propose a third patch here to just remove the testenv func-fast-post.","commit_id":"0b65fd381dacc76af1c050877baf05d8ef6abbb6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f3eb5f3e654c714f0a50e03d8e44bb673371c08e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"[testenv:func-fast-post]"},{"line_number":63,"context_line":"commands \u003d ./.functests {posargs}"},{"line_number":64,"context_line":"setenv \u003d SWIFT_TEST_IN_PROCESS\u003d1"},{"line_number":65,"context_line":"         SWIFT_TEST_IN_PROCESS_OBJECT_POST_AS_COPY\u003dTrue"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[testenv:func-post-as-copy]"},{"line_number":68,"context_line":"commands \u003d ./.functests {posargs}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"5a3905b3_8301a908","line":65,"updated":"2017-01-23 11:14:18.000000000","message":"ok. this makes this gate job run post-as-copy\u003dtrue, until we replace the gate job with the new func-post-as-copy below, at which point we can delete this test env.","commit_id":"4ee20dba482e8f8e4b9ea574428c72c5728a10a1"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f3eb5f3e654c714f0a50e03d8e44bb673371c08e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"setenv \u003d SWIFT_TEST_IN_PROCESS\u003d1"},{"line_number":65,"context_line":"         SWIFT_TEST_IN_PROCESS_OBJECT_POST_AS_COPY\u003dTrue"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[testenv:func-post-as-copy]"},{"line_number":68,"context_line":"commands \u003d ./.functests {posargs}"},{"line_number":69,"context_line":"setenv \u003d SWIFT_TEST_IN_PROCESS\u003d1"},{"line_number":70,"context_line":"         SWIFT_TEST_IN_PROCESS_OBJECT_POST_AS_COPY\u003dTrue"}],"source_content_type":"text/x-properties","patch_set":6,"id":"5a3905b3_3e156c3f","line":67,"updated":"2017-01-23 11:14:18.000000000","message":"ok , this puts a new test env in place to be referenced in the gate by the follow on patch","commit_id":"4ee20dba482e8f8e4b9ea574428c72c5728a10a1"}]}