)]}'
{"test/unit/common/ring/test_ring.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"eddf7e99f81cc0d29718bd6530d4b69887fbc6fb","unresolved":false,"context_lines":[{"line_number":904,"context_line":"        part \u003d random.randint(0, r.partition_count)"},{"line_number":905,"context_line":"        node_iter \u003d r.get_more_nodes(part)"},{"line_number":906,"context_line":"        next(node_iter)"},{"line_number":907,"context_line":"        self.assertEqual(5, counting_table.count)"},{"line_number":908,"context_line":"        # sanity"},{"line_number":909,"context_line":"        self.assertEqual(1, r._num_regions)"},{"line_number":910,"context_line":"        self.assertEqual(2, r._num_zones)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_4b804f47","side":"PARENT","line":907,"updated":"2017-01-09 16:32:58.000000000","message":"so was it just fortuitous that the \"random\" part chosen before (which was the same part every time) happened to result in 5 calls to the iter\u0027s next() ?","commit_id":"436374e66c21b1ea7974d5c10527e72eca47a738"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"eddf7e99f81cc0d29718bd6530d4b69887fbc6fb","unresolved":false,"context_lines":[{"line_number":528,"context_line":"            part_handoff_counts.add(len(list(r.get_more_nodes(part))))"},{"line_number":529,"context_line":"        self.assertEqual(part_handoff_counts, {105})"},{"line_number":530,"context_line":"        # which less the primaries - is every device in the ring"},{"line_number":531,"context_line":"        self.assertEqual(r._num_devs - len(r._replica2part2dev_id), 105)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        part, devs \u003d r.get_nodes(\u0027a\u0027, \u0027c\u0027, \u0027o\u0027)"},{"line_number":534,"context_line":"        primary_zones \u003d set([d[\u0027zone\u0027] for d in devs])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_05f2b66f","line":531,"updated":"2017-01-09 16:32:58.000000000","message":"could we use the public Ring interface:\n\n  self.assertEqual(len(r.devs) - r.replica_count, 105)\n\nsame in other places","commit_id":"75c35f6093ca09e52d9bff8bce9dc350cd5b4594"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"eddf7e99f81cc0d29718bd6530d4b69887fbc6fb","unresolved":false,"context_lines":[{"line_number":836,"context_line":"            counting_table \u003d CountingRingTable(r._replica2part2dev_id)"},{"line_number":837,"context_line":"            r._replica2part2dev_id \u003d counting_table"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"            part \u003d random.randint(0, r.partition_count)"},{"line_number":840,"context_line":"            node_iter \u003d r.get_more_nodes(part)"},{"line_number":841,"context_line":"            next(node_iter)"},{"line_number":842,"context_line":"            count_counter[counting_table.count] +\u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_4bf76ff5","line":839,"updated":"2017-01-09 16:32:58.000000000","message":"this line should be deleted I think, and then the result becomes predictable...","commit_id":"75c35f6093ca09e52d9bff8bce9dc350cd5b4594"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"eddf7e99f81cc0d29718bd6530d4b69887fbc6fb","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            node_iter \u003d r.get_more_nodes(part)"},{"line_number":841,"context_line":"            next(node_iter)"},{"line_number":842,"context_line":"            count_counter[counting_table.count] +\u003d 1"},{"line_number":843,"context_line":"        self.assertGreater(count_counter[5], r.partition_count // 2)"},{"line_number":844,"context_line":"        # sanity"},{"line_number":845,"context_line":"        self.assertEqual(1, r._num_regions)"},{"line_number":846,"context_line":"        self.assertEqual(2, r._num_zones)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_cb027f0b","line":843,"updated":"2017-01-09 16:32:58.000000000","message":"count_counter \u003d\u003d defaultdict(\u003cclass \u0027int\u0027\u003e, {5: 166, 6: 34, 7: 27, 9: 14, 10: 6, 11: 6, 13: 3}) if we test every partition.\n\nwhy the spread of 5 to 13? might be worth a comment to explain what the test is verifying?","commit_id":"75c35f6093ca09e52d9bff8bce9dc350cd5b4594"}]}