)]}'
{"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"351503f92ca99bebaba650128d87f2c649ffa16d","unresolved":false,"context_lines":[{"line_number":6099,"context_line":"            i \u003d 0"},{"line_number":6100,"context_line":"            while True:"},{"line_number":6101,"context_line":"                df2 \u003d df_mgr.get_diskfile(\u0027sda1\u0027, \u00270\u0027, \u0027a\u0027, \u0027c\u0027, \u0027o%d\u0027 % i,"},{"line_number":6102,"context_line":"                                          policy\u003dpolicy)"},{"line_number":6103,"context_line":"                i +\u003d 1"},{"line_number":6104,"context_line":"                suffix_dir2 \u003d os.path.dirname(df2._datadir)"},{"line_number":6105,"context_line":"                if suffix_dir !\u003d suffix_dir2:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_22db9ded","side":"PARENT","line":6102,"updated":"2017-01-17 10:38:55.000000000","message":"ah, so this used kwarg for policy","commit_id":"6918c7940af47817b776686ead979d79ba583e80"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3aca3983087c430c7a20238a9d077f2e43527053","unresolved":false,"context_lines":[{"line_number":5699,"context_line":"        with self.policy_in_message():"},{"line_number":5700,"context_line":"            unittest.TestCase.assertEqual(self, *args)"},{"line_number":5701,"context_line":""},{"line_number":5702,"context_line":"    def get_different_suffix_df(self, df, df_mgr, device, partition,"},{"line_number":5703,"context_line":"                                account, container, **kwargs):"},{"line_number":5704,"context_line":"        # returns diskfile in the same partition with different suffix"},{"line_number":5705,"context_line":"        suffix_dir \u003d os.path.dirname(df._datadir)"},{"line_number":5706,"context_line":"        i \u003d 0"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e0d7fabc","line":5703,"range":{"start_line":5702,"start_character":42,"end_line":5703,"end_character":60},"updated":"2017-01-20 19:46:15.000000000","message":"It seems like all of these are derived from df; why bother passing them in? Proposed https://review.openstack.org/423501 to have this just take a df.","commit_id":"e772cf95c65b98bb17b094585ff3ff2040c148c9"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"351503f92ca99bebaba650128d87f2c649ffa16d","unresolved":false,"context_lines":[{"line_number":5706,"context_line":"        i \u003d 0"},{"line_number":5707,"context_line":"        while True:"},{"line_number":5708,"context_line":"            df2 \u003d df_mgr.get_diskfile(device, partition, account, container,"},{"line_number":5709,"context_line":"                                      \u0027o%d\u0027 % i, **kwargs)"},{"line_number":5710,"context_line":"            i +\u003d 1"},{"line_number":5711,"context_line":"            suffix_dir2 \u003d os.path.dirname(df2._datadir)"},{"line_number":5712,"context_line":"            if suffix_dir !\u003d suffix_dir2:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_c23f3985","line":5709,"updated":"2017-01-17 10:38:55.000000000","message":"ok, so a positional arg (policy) can be passed as a kwarg, but curious about the choice of style since policy is not an optional arg for get_diskfile","commit_id":"e772cf95c65b98bb17b094585ff3ff2040c148c9"}]}