)]}'
{"id":"openstack%2Fswift~427","triplet_id":"openstack%2Fswift~master~I6f88ca6e4bc4471cd2e878d7f5f6436d65bdf1bf","project":"openstack/swift","branch":"master","topic":"proxycontrollers","hashtags":[],"change_id":"I6f88ca6e4bc4471cd2e878d7f5f6436d65bdf1bf","subject":"separate proxy controllers from server module","status":"ABANDONED","created":"2011-09-13 03:59:32.000000000","updated":"2012-01-04 08:08:25.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"290c630323646cc25cc34a9d077924e572dd735b","_number":427,"virtual_id_number":427,"owner":{"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},"actions":{},"labels":{"Verified":{"all":[{"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"date":"2011-09-16 03:25:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},{"value":0,"date":"2011-09-15 14:26:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-09-15 14:26:29.000000000","updated_by":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"reviewer":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"state":"REVIEWER"}],"messages":[{"id":"bfd587916cb27ed1d8267acf3b4071befa16f663","author":{"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},"date":"2011-09-13 04:16:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a679794a438a54f67dc46addf9b0611eaefb1a83","author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"date":"2011-09-15 14:26:29.000000000","message":"Patch Set 2:\n\nI tried to make a normal github diff \u003c https://github.com/gholt/swift/pull/4/files \u003e to see if that\u0027d help visualize this monster. It didn\u0027t. :/ Somehow there are 1,500 lines of extra stuff than we had before and I\u0027m not sure the refactor is worth it. Is there something else that was done here, or just the separation?","accounts_in_message":[],"_revision_number":2},{"id":"db11e3d49a47880217c58c76c7bbad191a2d1211","author":{"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},"date":"2011-09-16 03:25:12.000000000","message":"Patch Set 2:\n\nIt\u0027s probably from I had to repeat a bunch of setup code from the proxy test module in the individual controller test modules.  All of the changes were pretty mechanical.","accounts_in_message":[],"_revision_number":2},{"id":"f6ef450710915fbbbba7f44ca2d88a6921428c9d","author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"date":"2011-09-27 07:33:48.000000000","message":"Patch Set 2:\n\nJust because nobody else bothered to comment yet ;) I\u0027ll just say I\u0027m\nambivalent about this change. I\u0027m torn whether it really makes things easier to\nread or just makes for a lot of file flipping. It\u0027s only about 100 extra lines,\nmost of which is probably the new file headers, so that concern of mine is\ngone. If others go for it, I won\u0027t oppose, but the following should be fixed:\n\nswift/proxy/controllers/account.py:133:1: W391 blank line at end of file\nswift/proxy/controllers/base.py:536:1: W391 blank line at end of file\nswift/proxy/controllers/container.py:186:1: W391 blank line at end of file\nswift/proxy/controllers/obj.py:203:1: E302 expected 2 blank lines, found 1\nswift/proxy/controllers/obj.py:717:1: W391 blank line at end of file\n\nAnd the docs only show the original swift/proxy/server.py and none of the new\nstuff.","accounts_in_message":[],"_revision_number":2},{"id":"948a3509bfed4e09133dd64ba8df422754b324a8","author":{"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},"date":"2012-01-04 08:08:25.000000000","message":"Patch Set 2: Abandoned\n\nI wish this had happened, but it\u0027d be easier to start from scratch now.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"060dcb74f208d6b9540e4ae45c2fc66b6450753c","revisions":{"92e79c53d5b18d5e55bb46337a82b05fae6abcfc":{"kind":"REWORK","_number":1,"created":"2011-09-13 03:59:32.000000000","uploader":{"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},"ref":"refs/changes/27/427/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/27/427/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/27/427/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/27/427/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/27/427/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/27/427/1"}}},"commit":{"parents":[{"commit":"c3bc288d060e221e85d9d6beaa70928fcef77137","subject":"bumped version to 1.4.4","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c3bc288d060e221e85d9d6beaa70928fcef77137"}]}],"author":{"name":"Mike Barton","email":"mike@weirdlooking.com","date":"2011-09-13 03:44:07.000000000","tz":0},"committer":{"name":"Mike Barton","email":"mike@weirdlooking.com","date":"2011-09-13 04:02:40.000000000","tz":0},"subject":"separate proxy controllers from server module","message":"separate proxy controllers from server module\n\nChange-Id: I6f88ca6e4bc4471cd2e878d7f5f6436d65bdf1bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/92e79c53d5b18d5e55bb46337a82b05fae6abcfc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/92e79c53d5b18d5e55bb46337a82b05fae6abcfc"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c3bc288d060e221e85d9d6beaa70928fcef77137","is_merged_in_target_branch":true,"change_id":"I752def9a6f76f74cfd30c744525dfcccc35782c1","change_number":392,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"060dcb74f208d6b9540e4ae45c2fc66b6450753c":{"kind":"REWORK","_number":2,"created":"2011-09-13 04:16:15.000000000","uploader":{"_account_id":512,"name":"Mike Barton","username":"5UOzf3BLEHnnEzgp","inactive":true},"ref":"refs/changes/27/427/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/27/427/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/27/427/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/27/427/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/27/427/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/27/427/2"}}},"commit":{"parents":[{"commit":"c3bc288d060e221e85d9d6beaa70928fcef77137","subject":"bumped version to 1.4.4","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c3bc288d060e221e85d9d6beaa70928fcef77137"}]}],"author":{"name":"Mike Barton","email":"mike@weirdlooking.com","date":"2011-09-13 03:44:07.000000000","tz":0},"committer":{"name":"Mike Barton","email":"mike@weirdlooking.com","date":"2011-09-13 04:19:30.000000000","tz":0},"subject":"separate proxy controllers from server module","message":"separate proxy controllers from server module\n\nChange-Id: I6f88ca6e4bc4471cd2e878d7f5f6436d65bdf1bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/060dcb74f208d6b9540e4ae45c2fc66b6450753c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/060dcb74f208d6b9540e4ae45c2fc66b6450753c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c3bc288d060e221e85d9d6beaa70928fcef77137","is_merged_in_target_branch":true,"change_id":"I752def9a6f76f74cfd30c744525dfcccc35782c1","change_number":392,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}