)]}'
{"swift/common/middleware/cname_lookup.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"500c05362b370d0242e2943b171768d3df3c7455","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.logger \u003d get_logger(conf, log_route\u003d\u0027cname-lookup\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _domain_endswith_in_storage_domain(self, a_domain):"},{"line_number":105,"context_line":"        for domain in self.storage_domain:"},{"line_number":106,"context_line":"            if a_domain.endswith(domain):"},{"line_number":107,"context_line":"                return True"},{"line_number":108,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_dd2a3de7","line":105,"updated":"2017-02-19 15:36:15.000000000","message":"I think we may want the fix here; something like\n\n a_domain \u003d \u0027.\u0027 + a_domain\n\n? What\u0027s the expected behavior if resolution goes to a storage_domain exactly, rather than a subdomain?","commit_id":"9e764cb648d517d8443e0f9a2b7c9292288befaa"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"61a3775c215eecd809d02c2f11865d9807ec11d5","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.logger \u003d get_logger(conf, log_route\u003d\u0027cname-lookup\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _domain_endswith_in_storage_domain(self, a_domain):"},{"line_number":105,"context_line":"        for domain in self.storage_domain:"},{"line_number":106,"context_line":"            if a_domain.endswith(domain):"},{"line_number":107,"context_line":"                return True"},{"line_number":108,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_60e7e612","line":105,"in_reply_to":"da36d5c6_dd2a3de7","updated":"2017-02-19 17:20:38.000000000","message":"Good question. Right now, it fails. The documentation is a bit ambiguous: \"Middleware that translates an unknown domain in the host header to something that ends with the configured storage_domain\"\n\nDoes \"ending\" means there must be something before?\n\nI don\u0027t see why it shouldn\u0027t work, even if there is no point IMHO (cname_lookup is for hiding Swift URLs behind cool domains, resolving directly to storage_domain would just hide the domain part, not the path part).\n\nWell, your proposal makes it work. I\u0027ll go for that :)","commit_id":"9e764cb648d517d8443e0f9a2b7c9292288befaa"}]}