)]}'
{"swift/common/middleware/cname_lookup.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"af5a3c3c3c8c6675b5ba8a6d36ac6f8c615ff7e8","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    conf.update(local_conf)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    register_swift_info(\u0027cname_lookup\u0027,"},{"line_number":181,"context_line":"                        lookup_depth\u003dint(conf.get(\u0027lookup_depth\u0027, \u00271\u0027)))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def cname_filter(app):"},{"line_number":184,"context_line":"        return CNAMELookupMiddleware(app, conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_1d99356f","line":181,"updated":"2017-02-19 15:25:10.000000000","message":"Is it worth us also exposing storage_domain? What are the pros/cons?","commit_id":"92199e70c0ab03f811fe5c6362f336bfdfe0d9ca"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"be036a2394c2562ddffbd038cbf83b301530db54","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    conf.update(local_conf)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    register_swift_info(\u0027cname_lookup\u0027,"},{"line_number":181,"context_line":"                        lookup_depth\u003dint(conf.get(\u0027lookup_depth\u0027, \u00271\u0027)))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def cname_filter(app):"},{"line_number":184,"context_line":"        return CNAMELookupMiddleware(app, conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_60afe6e3","line":181,"in_reply_to":"da36d5c6_1d99356f","updated":"2017-02-19 16:37:36.000000000","message":"I don\u0027t think it should be. An operator might have multiple endpoints for a cluster, depending on internal/external DNS servers, routing strategy, ... The user already has what he needs with the URL he is using to access the cluster.","commit_id":"92199e70c0ab03f811fe5c6362f336bfdfe0d9ca"}],"test/unit/common/middleware/test_cname_lookup.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"af5a3c3c3c8c6675b5ba8a6d36ac6f8c615ff7e8","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def test_registered_defaults(self):"},{"line_number":249,"context_line":"        cname_lookup.filter_factory({})"},{"line_number":250,"context_line":"        swift_info \u003d utils.get_swift_info()"},{"line_number":251,"context_line":"        self.assertTrue(\u0027cname_lookup\u0027 in swift_info)"},{"line_number":252,"context_line":"        self.assertEqual(swift_info[\u0027cname_lookup\u0027].get(\u0027lookup_depth\u0027), 1)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def test_registered_nondefaults(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_3d9ef956","line":251,"updated":"2017-02-19 15:25:10.000000000","message":"nit: I\u0027ve come to rather prefer the assertIn(\u0027cname_lookup\u0027, swift_info) style, as it tells you what *is* present in the event of a failure.","commit_id":"92199e70c0ab03f811fe5c6362f336bfdfe0d9ca"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"be036a2394c2562ddffbd038cbf83b301530db54","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def test_registered_defaults(self):"},{"line_number":249,"context_line":"        cname_lookup.filter_factory({})"},{"line_number":250,"context_line":"        swift_info \u003d utils.get_swift_info()"},{"line_number":251,"context_line":"        self.assertTrue(\u0027cname_lookup\u0027 in swift_info)"},{"line_number":252,"context_line":"        self.assertEqual(swift_info[\u0027cname_lookup\u0027].get(\u0027lookup_depth\u0027), 1)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def test_registered_nondefaults(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_80acdaee","line":251,"in_reply_to":"da36d5c6_3d9ef956","updated":"2017-02-19 16:37:36.000000000","message":"Done","commit_id":"92199e70c0ab03f811fe5c6362f336bfdfe0d9ca"}]}