)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ac6aac7d9a19d69c5a7a4b952abad84da2284429","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allows admins of systems who use software that"},{"line_number":10,"context_line":"generates/controls swift config files to add items to an existing swift"},{"line_number":11,"context_line":"configuration that uses the conf.d-style without intruding on the"},{"line_number":12,"context_line":"managing system.  This is done by adding a new config file in the"},{"line_number":13,"context_line":"config.d directory with a filter section declared in it, and explicitly"},{"line_number":14,"context_line":"declaring the ordering dependencies of that filter with other items in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAS3%2F%2Fv84%3D","line":11,"updated":"2013-09-20 00:52:02.000000000","message":"So after reading the deployment guide updates, do you mean by \"intruding\" that an admin does not have to modify existing configuration files, just add new ones as long as they are already using .conf.d style configurations?","commit_id":"0391555c15847adba4de5b263bb9a4c572e0defa"}],"doc/manpages/proxy-server.conf.5":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ac6aac7d9a19d69c5a7a4b952abad84da2284429","unresolved":false,"context_lines":[{"line_number":606,"context_line":"    pipelines are enabled, but you cannot use the duplicated filter as a constraint"},{"line_number":607,"context_line":"    in other filters\u0027 before/after declarations."},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"  * You should not name a filter the same name as your pipeline.  (Vanilla"},{"line_number":610,"context_line":"    pastedeploy will allow you to do this, although it can behave unexpectedly in"},{"line_number":611,"context_line":"    certain circumstances when you do, so this is probably a bad idea anyway.)"},{"line_number":612,"context_line":""}],"source_content_type":"text/troff","patch_set":2,"id":"AAAAS3%2F%2Fv80%3D","line":609,"updated":"2013-09-20 00:52:02.000000000","message":"Same comments apply here as were made in the deployment guide...","commit_id":"0391555c15847adba4de5b263bb9a4c572e0defa"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"1e34dcf28f10d2b1c03271cf9a1e2c37690d8233","unresolved":false,"context_lines":[{"line_number":548,"context_line":".RE"},{"line_number":549,"context_line":".PD"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":".SH DIRECTORY-BASED CONFIGURATION AND DYNAMIC PIPELINES"},{"line_number":552,"context_line":".PP"},{"line_number":553,"context_line":"Swift allows its service configurations to be spread across separate files."},{"line_number":554,"context_line":"If the configuration file path supplied to the proxy server is a directory"}],"source_content_type":"text/troff","patch_set":4,"id":"AAAATn%2F%2B3MU%3D","line":551,"updated":"2013-11-19 08:40:57.000000000","message":"+1 for updating the manpage (I actually didn\u0027t know there was a proxy-server.conf manpage) but if you update you maybe want to sync with the documentation from deployment_guide.rst","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"}],"doc/source/deployment_guide.rst":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ac6aac7d9a19d69c5a7a4b952abad84da2284429","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    using the ``set`` syntax or you\u0027ll probably mess up your non-paste.deploy"},{"line_number":305,"context_line":"    configuration files."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Directory-based server configuration and dynamic pipelines"},{"line_number":308,"context_line":"----------------------------------------------------------"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"When directory-based configuration is being used, individual filter sections can"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAS3%2F%2Fv8U%3D","line":307,"updated":"2013-09-20 00:52:02.000000000","message":"So does the name \"dynamic pipelines\" mean that during \"swift-init proxy-server start|reload\" the pipelines will be constructed from multiple configuration files?\n\nIf so, then this does not mean that a live runner proxy-server will dynamically insert a new pipeline into the WSGI context, right?\n\nPerhaps stating explicitly that this will be applied on load or reload might be useful to some folks not familiar with how things work.","commit_id":"0391555c15847adba4de5b263bb9a4c572e0defa"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ac6aac7d9a19d69c5a7a4b952abad84da2284429","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"There are some minor limitations when dynamic pipelines are enabled:"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"You cannot name your filters a name that starts with a \u0027#\u0027.  This symbol is"},{"line_number":376,"context_line":"reserved for use by the dynamic pipeline code."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"You cannot place the same filter in the pipeline twice using dynamic"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAS3%2F%2Fv98%3D","line":375,"updated":"2013-09-20 00:52:02.000000000","message":"\"You cannot name your filters _using_ a name ...\" perhaps?","commit_id":"0391555c15847adba4de5b263bb9a4c572e0defa"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ac6aac7d9a19d69c5a7a4b952abad84da2284429","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"You cannot place the same filter in the pipeline twice using dynamic"},{"line_number":379,"context_line":"constraints.  You *can* place them in the pipeline declaration when dynamic"},{"line_number":380,"context_line":"pipelines are enabled, but you cannot use the duplicated filter as a constraint"},{"line_number":381,"context_line":"in other filters\u0027 before/after declarations."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"You should not name a filter the same name as your pipeline.  (Vanilla"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAS3%2F%2Fv9Q%3D","line":380,"updated":"2013-09-20 00:52:02.000000000","message":"Can you help me understand this last sentence?\n\nAn admin can have a configuration file that specifies proxy-logging twice in the main pipeline, but can is use proxy-logging in a constraint?\n\nAlso, if an admin has a filter in a pipeline already, it seems to be the case that the admin cannot use this feature to then move it in the pipeline, right?\n\nIs there another aspect that the above does not consider?","commit_id":"0391555c15847adba4de5b263bb9a4c572e0defa"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ac6aac7d9a19d69c5a7a4b952abad84da2284429","unresolved":false,"context_lines":[{"line_number":380,"context_line":"pipelines are enabled, but you cannot use the duplicated filter as a constraint"},{"line_number":381,"context_line":"in other filters\u0027 before/after declarations."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"You should not name a filter the same name as your pipeline.  (Vanilla"},{"line_number":384,"context_line":"pastedeploy will allow you to do this, although it can behave unexpectedly in"},{"line_number":385,"context_line":"certain circumstances when you do, so this is probably a bad idea anyway.)"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAS3%2F%2Fv9s%3D","line":383,"updated":"2013-09-20 00:52:02.000000000","message":"Can you move this name constraint up next to the one above?","commit_id":"0391555c15847adba4de5b263bb9a4c572e0defa"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"507f72111f0ad0c1a5db6538cc9f93619de3a331","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    $ swift-object-auditor /etc/swift/object-server.conf "},{"line_number":189,"context_line":"    Unable to find object-auditor config section in /etc/swift/object-server.conf"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"If the configuration path is a directory ending in \u0027.conf.d\u0027, files in"},{"line_number":192,"context_line":"that directory with the file extension \".conf\" will be combined to generate the"},{"line_number":193,"context_line":"configuration object which is delivered to the Swift service.  This is"},{"line_number":194,"context_line":"referred to generally as \"directory based configuration\"."}],"source_content_type":"text/x-rst","patch_set":4,"id":"AAAATn%2F%2F2vk%3D","line":191,"updated":"2013-10-27 19:45:47.000000000","message":"How does this interact with the scheme of having /etc/swift/object-server be a directory containing files, 1.conf and 2.conf which swift-init will use to start two different object-server processes (probably bound to different ports)?\n\nIf they\u0027re mutually exclusive, this could cause trouble for folks using multiple object-servers where one is \"everything-but-replication\" and one is \"just replication\" (i.e. the separate replication network feature).","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"1e34dcf28f10d2b1c03271cf9a1e2c37690d8233","unresolved":false,"context_lines":[{"line_number":313,"context_line":"software or service, allowing administrators to add filters experimentally or"},{"line_number":314,"context_line":"permanently without modifying or interfering with said service."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"To enable dynamic pipelines when using directory-based configuration, add the "},{"line_number":317,"context_line":"following declaration to the [DEFAULT] section of the configuration::"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"AAAATn%2F%2B3Mw%3D","line":316,"updated":"2013-11-19 08:40:57.000000000","message":"maybe want to fix those red stuff if you have to go by an another iteration of this patch.","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"507f72111f0ad0c1a5db6538cc9f93619de3a331","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    [pipeline:main]"},{"line_number":326,"context_line":"    pipeline \u003d healthcheck tempauth proxy-server"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    [app:myapp]"},{"line_number":329,"context_line":"    use \u003d egg:mypkg#myapp"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Now any given filter section may declare what pipeline it goes into and specify"}],"source_content_type":"text/x-rst","patch_set":4,"id":"AAAATn%2F%2F2vw%3D","line":328,"updated":"2013-10-27 19:45:47.000000000","message":"Shouldn\u0027t this be consistent with the pipeline in the same example?  I.e. \"proxy-server\"?","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"507f72111f0ad0c1a5db6538cc9f93619de3a331","unresolved":false,"context_lines":[{"line_number":348,"context_line":"each of those auth systems individually, as in::"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    [filter:tempauth]"},{"line_number":351,"context_line":"    provides \u003d auth authn authz"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    [filter:ratelimit]"},{"line_number":354,"context_line":"    pipeline \u003d main"}],"source_content_type":"text/x-rst","patch_set":4,"id":"AAAATn%2F%2F2vg%3D","line":351,"updated":"2013-10-27 19:45:47.000000000","message":"You should make it very clear that with no \"pipeline \u003d ...\" line, the filter will not appear in any pipeline (it\u0027s ambiguous).","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"}],"swift/common/utils.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ac6aac7d9a19d69c5a7a4b952abad84da2284429","unresolved":false,"context_lines":[{"line_number":2251,"context_line":"    return content_type, parm_list"},{"line_number":2252,"context_line":""},{"line_number":2253,"context_line":""},{"line_number":2254,"context_line":"def bifurcate(predicate, iterable):"},{"line_number":2255,"context_line":"    \"\"\""},{"line_number":2256,"context_line":"    Eagerly separate objects into two groups according to a predicate."},{"line_number":2257,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2Fv8k%3D","line":2254,"updated":"2013-09-20 00:52:02.000000000","message":"Why not just place these in the wsgi module? It seems to be the only place they are used, and the tests for them can just go in the test_wsgi module as well.","commit_id":"0391555c15847adba4de5b263bb9a4c572e0defa"}],"swift/common/wsgi.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"1e34dcf28f10d2b1c03271cf9a1e2c37690d8233","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    a, b \u003d tee(iterable)"},{"line_number":134,"context_line":"    next(b, None)"},{"line_number":135,"context_line":"    return izip(a, b)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def qualify(app, name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B3LM%3D","line":135,"updated":"2013-11-19 08:40:57.000000000","message":"Those functions looks generic enough to sit in swift.common.utils?","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"507f72111f0ad0c1a5db6538cc9f93619de3a331","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        for pipeline_section in pipelines:"},{"line_number":151,"context_line":"            builder \u003d PipelineBuilder(config, pipeline_section)"},{"line_number":152,"context_line":"            pipeline_str \u003d \u0027 \u0027.join(builder.pipeline)"},{"line_number":153,"context_line":"            config.set(pipeline_section, \u0027pipeline\u0027, pipeline_str)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"class PipelineBuilder(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F2Qs%3D","line":153,"updated":"2013-10-27 19:45:47.000000000","message":"It\u0027s hacky to plumb the logging down into here, but it\u0027d be *really* nice for debugging.  Here\u0027s a suggested patch which logs each dynamically-generated pipeline: http://paste.openstack.org/show/y6YeHsx67tZUbLojDjNg/\n\nIt only logs once (adds the logger to the class, then removes it).  Otherwise, you\u0027d get the same thing logged again for every worker process when it loaded the app \"for reals\".","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"cf316028d9db91fda045b48e6c0c3ad07580f45e","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        members.update(s for s in self.config.sections() if is_member(s))"},{"line_number":200,"context_line":"        return members"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _disambiguate(self, pipeline):"},{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":"        If a filter is put into the pipeline multiple times, disambiguate"},{"line_number":205,"context_line":"        subsequent ones as \"filter#2\", \"filter#3\", etc., so that we can"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FUWI%3D","line":202,"updated":"2013-10-17 20:17:50.000000000","message":"This method does appears to be independent of the class, and could be pulled out if we come back to refactor this code for other reasons.","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"507f72111f0ad0c1a5db6538cc9f93619de3a331","unresolved":false,"context_lines":[{"line_number":339,"context_line":"                    roots.add(child)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        if any(graph.values()):"},{"line_number":342,"context_line":"            raise ConfigFileError(\u0027Cycle found for pipeline:%s!\u0027 %"},{"line_number":343,"context_line":"                                  self.pipeline_name)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F2Qo%3D","line":342,"updated":"2013-10-27 19:45:47.000000000","message":"Can you make this\n\n  ...\u0027Cycle found for pipeline \"%s\"!\u0027...\n\nOtherwise, the error looks funny because there\u0027s so many colons-sep strings all run together.","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"507f72111f0ad0c1a5db6538cc9f93619de3a331","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        if any(graph.values()):"},{"line_number":342,"context_line":"            raise ConfigFileError(\u0027Cycle found for pipeline:%s!\u0027 %"},{"line_number":343,"context_line":"                                  self.pipeline_name)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        return result"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F2QE%3D","line":343,"updated":"2013-10-27 19:45:47.000000000","message":"I had a lot of trouble getting rid of a cycle in my initial non-trivial dynamic construction of the pipeline:\n\n  catch_errors healthcheck proxy-logging-1 cache slo swift3 bulk ratelimit tempurl tempauth account-quotas container-quotas proxy-logging-2 proxy-server\n\nI think the root cause of my problem was having\n\n  [filter:cache]\n  ...\n  before \u003d #start\n  after \u003d proxy-logging-1\n\n  [filter:proxy-logging-1]\n  ...\n  after \u003d catch_errors healthcheck\n\nThe bug was that proxy-logging-1 needed to say it was before #start.\n\nIt\u0027s probably hard, but it would be nice if the cycle detection gave you more information about how to get rid of it.","commit_id":"47c21688c5989cf447c656f31f1b9b76c3edcc76"}]}
