)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e166795a97185e26010f45cf607cef0487190ccc","unresolved":false,"context_lines":[{"line_number":2293,"context_line":""},{"line_number":2294,"context_line":"            def extract_response_data(responses, limit\u003dNone):"},{"line_number":2295,"context_line":"                for getter, _parts_iter in responses:"},{"line_number":2296,"context_line":"                    statuses.extend(getter.statuses[:limit])"},{"line_number":2297,"context_line":"                    reasons.extend(getter.reasons[:limit])"},{"line_number":2298,"context_line":"                    bodies.extend(getter.bodies[:limit])"},{"line_number":2299,"context_line":"                    headers.extend(getter.source_headers[:limit])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_71341bde","line":2296,"updated":"2017-03-16 23:22:46.000000000","message":"Why does it make sense to get all statuses in a bucket except the last one?","commit_id":"dcf0dff34976cbe5bdb8e3d047c471de9a5c6d36"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b3cfd472455adbae31b122ccdefbacd38f68cfdc","unresolved":false,"context_lines":[{"line_number":2293,"context_line":""},{"line_number":2294,"context_line":"            def extract_response_data(responses, limit\u003dNone):"},{"line_number":2295,"context_line":"                for getter, _parts_iter in responses:"},{"line_number":2296,"context_line":"                    statuses.extend(getter.statuses[:limit])"},{"line_number":2297,"context_line":"                    reasons.extend(getter.reasons[:limit])"},{"line_number":2298,"context_line":"                    bodies.extend(getter.bodies[:limit])"},{"line_number":2299,"context_line":"                    headers.extend(getter.source_headers[:limit])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_74d15ffb","line":2296,"in_reply_to":"1a1ced50_71341bde","updated":"2017-03-17 09:12:32.000000000","message":"For the bad_bucket, the limit is None so all the statuses are included. For the \"good buckets\" i.e. where the getter ended up with a \"good response\" we don\u0027t want to include that last response in evaluating e.g. we don\u0027t want to include a bunch of 200\u0027s in statuses and end up returning a 200.\n\nHaving said that, I have been reflecting on this some more overnight and whilst I am happy this patch fixes the problem stated in the commit message (every getter ends on 200, but proxy returns 500) I am not sure this change gives the right result for other cases such as when some backends return 3xx or 416. So...I want to write some more tests!","commit_id":"dcf0dff34976cbe5bdb8e3d047c471de9a5c6d36"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b3cfd472455adbae31b122ccdefbacd38f68cfdc","unresolved":false,"context_lines":[{"line_number":2305,"context_line":"                # non-success responses that successful getters may have"},{"line_number":2306,"context_line":"                # ignored on the way to getting a success response."},{"line_number":2307,"context_line":"                extract_response_data("},{"line_number":2308,"context_line":"                    bucket.get_responses(include_duplicates\u003dTrue), limit\u003d-1)"},{"line_number":2309,"context_line":""},{"line_number":2310,"context_line":"            if buckets.buckets and not statuses:"},{"line_number":2311,"context_line":"                # this combination of some successful responses, but no bad"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_37ca89a2","line":2308,"updated":"2017-03-17 09:12:32.000000000","message":"I\u0027m concerned that this may be too biased - in scenarios other than the one described in the commit message, this could cause a bunch of handoff 404s in one getter to outweigh 3xx or 416 from other getters.\n\nI\u0027m not convinced there is test coverage for those other scenarios :(","commit_id":"dcf0dff34976cbe5bdb8e3d047c471de9a5c6d36"}]}
