)]}'
{"swift/cli/info.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"2f977711606eec75804dc55651113609541fcc23","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if options.policy_name:"},{"line_number":50,"context_line":"        if POLICIES.get_by_name(options.policy_name) is None:"},{"line_number":51,"context_line":"            raise InfoSystemExit(\u0027No policy named %r\u0027 % options.policy_name)"},{"line_number":52,"context_line":"    elif args and args[0].endswith(\u0027.ring.gz\u0027):"},{"line_number":53,"context_line":"        if os.path.exists(args[0]):"},{"line_number":54,"context_line":"            ring_path \u003d args.pop(0)"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_88b04e45","line":52,"updated":"2017-03-20 02:52:56.000000000","message":"NIT: This change doesn\u0027t seem to be really needed. As in why it _needed_ to grew a \u0027.\u0027.","commit_id":"99412d48309e071eb190a2f4735df577a22cdb87"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b4ede08fee4f35e95efd81cf3dae094a023eb121","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if options.policy_name:"},{"line_number":50,"context_line":"        if POLICIES.get_by_name(options.policy_name) is None:"},{"line_number":51,"context_line":"            raise InfoSystemExit(\u0027No policy named %r\u0027 % options.policy_name)"},{"line_number":52,"context_line":"    elif args and args[0].endswith(\u0027.ring.gz\u0027):"},{"line_number":53,"context_line":"        if os.path.exists(args[0]):"},{"line_number":54,"context_line":"            ring_path \u003d args.pop(0)"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_f1cd26b8","line":52,"in_reply_to":"1a1ced50_88b04e45","updated":"2017-03-20 09:45:52.000000000","message":"I can see how the change makes things consistent - ring_path gets returned to swift-get-nodes where \u0027.ring.gz\u0027 is stripped off the end so it is assumed that ring_path ends with \u0027.ring.gz\u0027\n\nIdeally I\u0027d like to see a corresponding change to tighten up a unit test in test_info.py, i.e. to verify that objectring.gz would no longer be acceptable.","commit_id":"99412d48309e071eb190a2f4735df577a22cdb87"}]}