)]}'
{"doc/source/deployment_guide.rst":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"dcb73980ba1f661db9ada986221ae9952f821deb","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                                               clients"},{"line_number":783,"context_line":"memcache_servers              127.0.0.1:11211  Comma separated list of"},{"line_number":784,"context_line":"                                               memcached servers ip:port"},{"line_number":785,"context_line":"memcache_max_connections      2                Max number of connections to"},{"line_number":786,"context_line":"                                               each memcached server per"},{"line_number":787,"context_line":"                                               worker"},{"line_number":788,"context_line":"node_timeout                  10               Request timeout to external"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAS3%2F%2F4qs%3D","line":785,"updated":"2013-09-17 17:59:45.000000000","message":"So this is per-worker process. If max_clients is set to 1024 (default), won\u0027t this default setting cause requests handle to throttle here?  Is there some recommendation we can offer for tuning this?\n\nFor example: if your memcached servers are dedicated, set the max connections  based on (average requests/sec, max req/s, ports available, ...)\n\nIf your memcached servers are shared with your proxy servers, set the max connections based on ...\n\nDo we know what these kinds of recommendations yet?","commit_id":"6eee38e6c7565731d6d2e73e5b174f6ef1c30ac7"}],"swift/common/memcached.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"dcb73980ba1f661db9ada986221ae9952f821deb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def __init__(self, servers, connect_timeout\u003dCONN_TIMEOUT,"},{"line_number":131,"context_line":"                 io_timeout\u003dIO_TIMEOUT, tries\u003dTRY_COUNT,"},{"line_number":132,"context_line":"                 allow_pickle\u003dFalse, allow_unpickle\u003dFalse,"},{"line_number":133,"context_line":"                 max_conns\u003d2):"},{"line_number":134,"context_line":"        self._ring \u003d {}"},{"line_number":135,"context_line":"        self._errors \u003d dict(((serv, []) for serv in servers))"},{"line_number":136,"context_line":"        self._error_limited \u003d dict(((serv, 0) for serv in servers))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F4qg%3D","line":133,"updated":"2013-09-17 17:59:45.000000000","message":"Should we use a constant here instead of a naked 2?","commit_id":"6eee38e6c7565731d6d2e73e5b174f6ef1c30ac7"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ba47e9ddd8c416cf28da212b7136889b835c6eee","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                with Timeout(self._io_timeout):"},{"line_number":374,"context_line":"                    sock.sendall(\u0027delete %s\\r\\n\u0027 % key)"},{"line_number":375,"context_line":"                    # Wait for the delete to compelte"},{"line_number":376,"context_line":"                    fp.readline()"},{"line_number":377,"context_line":"                    self._return_conn(server, fp, sock)"},{"line_number":378,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAS3%2F%2FTbA%3D","line":375,"updated":"2013-09-30 15:39:23.000000000","message":"If you end up back here, *complete*","commit_id":"d2bdc07d0fc5c2944254b216c1cfd5f6da893f0f"}],"swift/common/middleware/memcache.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"dcb73980ba1f661db9ada986221ae9952f821deb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.app \u003d app"},{"line_number":29,"context_line":"        self.memcache_servers \u003d conf.get(\u0027memcache_servers\u0027)"},{"line_number":30,"context_line":"        serialization_format \u003d conf.get(\u0027memcache_serialization_support\u0027)"},{"line_number":31,"context_line":"        max_conns \u003d int(conf.get(\u0027max_connections\u0027, 2))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        if not self.memcache_servers or serialization_format is None:"},{"line_number":34,"context_line":"            path \u003d os.path.join(conf.get(\u0027swift_dir\u0027, \u0027/etc/swift\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2F4qY%3D","line":31,"updated":"2013-09-17 17:59:45.000000000","message":"Perhaps a constant instead of a naked 2?","commit_id":"6eee38e6c7565731d6d2e73e5b174f6ef1c30ac7"}],"test/unit/common/test_memcached.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"ff1827d03e6f918d0b8c9133185e95783ae14168","unresolved":false,"context_lines":[{"line_number":383,"context_line":"                sleep(0.1)"},{"line_number":384,"context_line":"                self.assertEquals(2, len(connected))"},{"line_number":385,"context_line":"            # finish up"},{"line_number":386,"context_line":"            for i in range(8):"},{"line_number":387,"context_line":"                connections.put(None)"},{"line_number":388,"context_line":"            self.assertEquals(2, len(connected))"},{"line_number":389,"context_line":"            p.waitall()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FwRs%3D","line":386,"updated":"2013-09-19 21:27:32.000000000","message":"Are we sure we need to do this eight times?\n\nIf I just do this once, now we have two clients that were allowed to connect. Once they both connect, no other connections should be created.\n\nHere is a patch to consider the demonstrates a change to this test to verify its behavior: http://paste.openstack.org/show/47288/","commit_id":"8d1526cdc06c1bbc3038b434198fb011e2365fdc"}]}