)]}'
{"test/unit/common/ring/test_composite_builder.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"000568865bc8a3e37263e080b33010a36385892a","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        self.assertFalse(error_lines[1:])"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        # make first version of composite ring"},{"line_number":461,"context_line":"        os.unlink(self.output_ring)"},{"line_number":462,"context_line":"        write_composite_ring(used_builders, self.output_ring)"},{"line_number":463,"context_line":"        # sanity"},{"line_number":464,"context_line":"        self.check_composite_ring(Ring(self.output_ring), builders[:2])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_3151e137","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":35},"updated":"2017-04-25 09:20:07.000000000","message":"nits) I like move the unlink above for the comment at L460 because this is cleanup for the test L453-L458.","commit_id":"7f65a697f84d52cb503d53510fc3ce2d1491e78c"}],"test/unit/common/ring/test_ring.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"000568865bc8a3e37263e080b33010a36385892a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            got \u003d ring.RingData.load(ring_fname)"},{"line_number":188,"context_line":"            self.assertEqual(metadata, got.composite_metadata)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        test_pattern \u003d (None, \u0027string\u0027, dict(), list(),"},{"line_number":191,"context_line":"                        {\u0027nest\u0027: {\u0027of\u0027: \u0027dict\u0027}})"},{"line_number":192,"context_line":"        for metadata in test_pattern:"},{"line_number":193,"context_line":"            test_metadata(metadata)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_6ca8ac1e","line":191,"range":{"start_line":190,"start_character":0,"end_line":191,"end_character":49},"updated":"2017-04-25 09:20:07.000000000","message":"Not sure if it actually addresses Clay\u0027s intention but if we assume the user of metadata is only composite ring, maybe we need some validations for the format, right?\n\nStrong constraint may block the future improvement but sort of None, empty dict, empty list seems meaningless for the *composite_metadata*. Once I made this assertion originally, I intended any format for the metadata so I didn\u0027t validate it but... I\u0027m realizing, small validation could be worth for now.","commit_id":"7f65a697f84d52cb503d53510fc3ce2d1491e78c"}]}