)]}'
{"doc/source/overview_ring.rst":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dc630ceaa69ca00269e619ef48b26cbd57907578","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The ring uses a configurable number of bits from a path\u0027s MD5 hash as a"},{"line_number":12,"context_line":"partition index that designates a device. The number of bits kept from the hash"},{"line_number":13,"context_line":"is known as the partition power, and 2 to the partition power indicates the"},{"line_number":14,"context_line":"partition count. Partitioning the full MD5 hash ring allows other parts of the"},{"line_number":15,"context_line":"cluster to work in batches of items at once which ends up either more efficient"},{"line_number":16,"context_line":"or at least less complex than working with each item separately or the entire"},{"line_number":17,"context_line":"cluster all at once."}],"source_content_type":"text/x-rst","patch_set":1,"id":"df140735_ee70f9a7","line":14,"range":{"start_line":14,"start_character":66,"end_line":14,"end_character":71},"updated":"2017-06-01 11:19:48.000000000","message":"These parts aren\u0027t partitions, at least that is how I read this - here, part \u003d\u003d a component of the system. Suggest changing to \u0027components\u0027 for clarity.","commit_id":"90edbc4ecef93493fbcf658414900ea54657e96a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dc630ceaa69ca00269e619ef48b26cbd57907578","unresolved":false,"context_lines":[{"line_number":12,"context_line":"partition index that designates a device. The number of bits kept from the hash"},{"line_number":13,"context_line":"is known as the partition power, and 2 to the partition power indicates the"},{"line_number":14,"context_line":"partition count. Partitioning the full MD5 hash ring allows other parts of the"},{"line_number":15,"context_line":"cluster to work in batches of items at once which ends up either more efficient"},{"line_number":16,"context_line":"or at least less complex than working with each item separately or the entire"},{"line_number":17,"context_line":"cluster all at once."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df140735_4e5fe50d","line":15,"range":{"start_line":15,"start_character":43,"end_line":15,"end_character":44},"updated":"2017-06-01 11:19:48.000000000","message":"nit: can we have at leats a comma if not a new sentence","commit_id":"90edbc4ecef93493fbcf658414900ea54657e96a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dc630ceaa69ca00269e619ef48b26cbd57907578","unresolved":false,"context_lines":[{"line_number":17,"context_line":"cluster all at once."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Another configurable value is the replica count, which indicates how many"},{"line_number":20,"context_line":"devices to assign for each partition in the ring. By having multiple devices"},{"line_number":21,"context_line":"responsible for each partition, the cluster can recover from drive or network"},{"line_number":22,"context_line":"failures."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df140735_2bbf0362","line":20,"updated":"2017-06-01 11:19:48.000000000","message":"nit: \u0027assign for\u0027 -\u003e \u0027assign to\u0027 ... it works either way I suppose","commit_id":"90edbc4ecef93493fbcf658414900ea54657e96a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dc630ceaa69ca00269e619ef48b26cbd57907578","unresolved":false,"context_lines":[{"line_number":22,"context_line":"failures."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Devices are added to the ring to describe the capacity available for"},{"line_number":25,"context_line":"part-replica assignments.  Devices are placed into failure domains consisting"},{"line_number":26,"context_line":"of region, zone, and server.  Regions can be used to describe geographical"},{"line_number":27,"context_line":"systems characterized by lower bandwidth or higher latency between machines in"},{"line_number":28,"context_line":"different regions.  Many rings will consist of only a single region.  Zones"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df140735_cb3e47d9","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":12},"updated":"2017-06-01 11:19:48.000000000","message":"first use of \u0027part-replica\u0027 - should we spell out partition rather than use \u0027part\u0027, here and elsewhere?","commit_id":"90edbc4ecef93493fbcf658414900ea54657e96a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dc630ceaa69ca00269e619ef48b26cbd57907578","unresolved":false,"context_lines":[{"line_number":30,"context_line":"network separations, or any other attribute that would lessen multiple"},{"line_number":31,"context_line":"replicas being unavailable at the same time."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Devices are given a weight which describes relative weight of the device in"},{"line_number":34,"context_line":"comparison to other devices."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"When building a ring, replicas for each part will be assigned to devices"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df140735_aedd6171","line":33,"range":{"start_line":33,"start_character":42,"end_line":33,"end_character":43},"updated":"2017-06-01 11:19:48.000000000","message":"insert \u0027the\u0027","commit_id":"90edbc4ecef93493fbcf658414900ea54657e96a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"dc630ceaa69ca00269e619ef48b26cbd57907578","unresolved":false,"context_lines":[{"line_number":30,"context_line":"network separations, or any other attribute that would lessen multiple"},{"line_number":31,"context_line":"replicas being unavailable at the same time."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Devices are given a weight which describes relative weight of the device in"},{"line_number":34,"context_line":"comparison to other devices."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"When building a ring, replicas for each part will be assigned to devices"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df140735_aeafa1e1","line":33,"range":{"start_line":33,"start_character":52,"end_line":33,"end_character":58},"updated":"2017-06-01 11:19:48.000000000","message":"nit: s/weight/storage capacity/","commit_id":"90edbc4ecef93493fbcf658414900ea54657e96a"}],"swift/common/ring/composite_builder.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"40de55ad1b0363996220d9de6a9136d257081075","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    achieved by, for example::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        swift-ring-builder \u003cbuilder-file\u003e rebalance --force"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"import copy"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_58321612","line":89,"updated":"2017-06-14 01:23:57.000000000","message":"I wonder if we need to note that device IDs for devices in composite rings can change between rebalances (or composes or whatever we are calling it), as the offset will change the IDs of all component rings after the first, when devices are added or removed.\n\nThis doesn\u0027t effect the usage of swift as devices will stay in the right place, and operators should be dealing with the builder files of the component rings for device management which will have persistent device IDs. However if one looks at composite rings this _could_ be confusing for operators? Just a thought.","commit_id":"b5ee8c88d09edc5579b139f0dfe5afe6b455ff15"}]}