)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"617b5164eac1039ab9a085e21b2317a4f2cfe715","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in a follow up patch to add some tests for the report tool."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It also fixes a bug when using the \"--dump-json\" option - until now it"},{"line_number":14,"context_line":"returned the policy name and made the JSON invalid."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie0d52a1a54fc152bb72cbb3f84dcc36a8dad972a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f436f4f_fd3f4e22","line":14,"updated":"2017-08-14 17:40:32.000000000","message":"Maybe we should have it print to stderr instead of suppressing entirely?","commit_id":"aa59758cf129c1d3636755f9b534b73496cbd305"}],"swift/cli/dispersion_report.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"617b5164eac1039ab9a085e21b2317a4f2cfe715","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    if options.insecure:"},{"line_number":357,"context_line":"        conf[\u0027keystone_api_insecure\u0027] \u003d \u0027yes\u0027"},{"line_number":358,"context_line":"    if options.partitions:"},{"line_number":359,"context_line":"        conf[\u0027partitions\u0027] \u003d \u0027yes\u0027"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    output \u003d generate_report(conf, options.policy_name)"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_3daf167e","line":359,"updated":"2017-08-14 17:40:32.000000000","message":"So we grew a new config option... probably good that we don\u0027t have CLI-only options now.","commit_id":"aa59758cf129c1d3636755f9b534b73496cbd305"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"617b5164eac1039ab9a085e21b2317a4f2cfe715","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        if policy is None:"},{"line_number":375,"context_line":"            exit(\u0027Unable to find policy: %s\u0027 % policy_name)"},{"line_number":376,"context_line":"    if not json_output:"},{"line_number":377,"context_line":"        print(\u0027Using storage policy: %s \u0027 % policy.name)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    swift_dir \u003d conf.get(\u0027swift_dir\u0027, \u0027/etc/swift\u0027)"},{"line_number":380,"context_line":"    retries \u003d int(conf.get(\u0027retries\u0027, 5))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_bdc66667","line":377,"updated":"2017-08-14 17:40:32.000000000","message":"If the idea is for this to be importable... I kinda wonder if we should grab a logger instead of printing directly.\n\nBut I suppose container_dispersion_report and object_dispersion_report already have direct prints... future work, maybe?","commit_id":"aa59758cf129c1d3636755f9b534b73496cbd305"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bb5a1ffa040829ed19db35249ff6045a09cec1e3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from swift.common.storage_policy import POLICIES"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"unmounted \u003d []"},{"line_number":41,"context_line":"notfound \u003d []"},{"line_number":42,"context_line":"json_output \u003d False"},{"line_number":43,"context_line":"debug \u003d False"},{"line_number":44,"context_line":"insecure \u003d False"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_error_log(prefix):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_50a57703","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":16},"updated":"2017-09-13 06:11:43.000000000","message":"How many of these are still strictly needed? `debug`, certainly; what about the others? Can we get rid of them?","commit_id":"b77de5393f540973685095cf087b3f839a55ba9f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bb5a1ffa040829ed19db35249ff6045a09cec1e3","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"def generate_report(conf, policy_name\u003dNone):"},{"line_number":368,"context_line":"    global json_output"},{"line_number":369,"context_line":"    json_output \u003d config_true_value(conf.get(\u0027dump_json\u0027, \u0027no\u0027))"},{"line_number":370,"context_line":"    if policy_name is None:"},{"line_number":371,"context_line":"        policy \u003d POLICIES.default"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_90763fa4","line":368,"updated":"2017-09-13 06:11:43.000000000","message":"I\u0027m not super keen on the global here... I kinda get it with debug (I\u0027m sure that guy\u0027s plumbed all over), but this seems to just be here to pass back to main() -- why not just have\n\n if config_true_value(conf.get(\u0027dump_json\u0027, \u0027no\u0027)):\n     print(json.dumps(output))\n\nabove?","commit_id":"b77de5393f540973685095cf087b3f839a55ba9f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bb5a1ffa040829ed19db35249ff6045a09cec1e3","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        if policy is None:"},{"line_number":375,"context_line":"            exit(\u0027Unable to find policy: %s\u0027 % policy_name)"},{"line_number":376,"context_line":"    if not json_output:"},{"line_number":377,"context_line":"        print(\u0027Using storage policy: %s \u0027 % policy.name)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    swift_dir \u003d conf.get(\u0027swift_dir\u0027, \u0027/etc/swift\u0027)"},{"line_number":380,"context_line":"    retries \u003d int(conf.get(\u0027retries\u0027, 5))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_d063a7db","line":377,"updated":"2017-09-13 06:11:43.000000000","message":"Still wouldn\u0027t mind seeing this go to stderr... but maybe other people don\u0027t care?","commit_id":"b77de5393f540973685095cf087b3f839a55ba9f"}]}