)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"67d11c089481822beb56177c59c0bf5225f516a4","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                conn_timeout\u003dself.app.conn_timeout,"},{"line_number":760,"context_line":"                node_timeout\u003dself.app.node_timeout,"},{"line_number":761,"context_line":"                logger\u003dself.app.logger,"},{"line_number":762,"context_line":"                chunked\u003dte.endswith(\u0027,chunked\u0027))"},{"line_number":763,"context_line":"        return putter"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def _transfer_data(self, req, data_source, putters, nodes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_ad08f890","line":762,"range":{"start_line":762,"start_character":24,"end_line":762,"end_character":47},"updated":"2018-02-19 05:08:50.000000000","message":"In my understanding, this is not needed to be changed.\nBecause req.is_chunked is property method which is calculated from \u0027Transfer-Encoding\u0027 header, isn\u0027t it?","commit_id":"122c787e630da1c676f40e99c13d317670d5f888"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8d4dba01853b2b34a8188ee75b93feea7da76d5b","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                conn_timeout\u003dself.app.conn_timeout,"},{"line_number":760,"context_line":"                node_timeout\u003dself.app.node_timeout,"},{"line_number":761,"context_line":"                logger\u003dself.app.logger,"},{"line_number":762,"context_line":"                chunked\u003dte.endswith(\u0027,chunked\u0027))"},{"line_number":763,"context_line":"        return putter"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def _transfer_data(self, req, data_source, putters, nodes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_8ed6b94e","line":762,"range":{"start_line":762,"start_character":24,"end_line":762,"end_character":47},"in_reply_to":"3fa0c359_2391be52","updated":"2018-02-26 13:15:44.000000000","message":"Whelp, turns out we still need it. Up above, we\u0027re setting transfer-encoding for the *putter headers* not the *request*, which explains the failures on patchset 4:\n\n- http://logs.openstack.org/92/476992/4/check/swift-tox-func/02fe871/job-output.txt.gz#_2018-02-26_12_31_26_233300\n- http://logs.openstack.org/92/476992/4/check/swift-tox-py27/d36f519/job-output.txt.gz#_2018-02-26_12_34_00_725581\n\nI\u0027m hesitant to change the request headers, as that may cause changes in how eventlet handles the wsgi input, so I think this is the most-reasonable way to do what we want.","commit_id":"122c787e630da1c676f40e99c13d317670d5f888"},{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"32246838df64d2b8e9fa16cf76eb063f0d58ee9e","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                conn_timeout\u003dself.app.conn_timeout,"},{"line_number":760,"context_line":"                node_timeout\u003dself.app.node_timeout,"},{"line_number":761,"context_line":"                logger\u003dself.app.logger,"},{"line_number":762,"context_line":"                chunked\u003dte.endswith(\u0027,chunked\u0027))"},{"line_number":763,"context_line":"        return putter"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def _transfer_data(self, req, data_source, putters, nodes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f9dbf25_aa626fd7","line":762,"range":{"start_line":762,"start_character":24,"end_line":762,"end_character":47},"in_reply_to":"3fa0c359_8ed6b94e","updated":"2018-02-27 14:12:36.000000000","message":"I see. Thank you for explanation!","commit_id":"122c787e630da1c676f40e99c13d317670d5f888"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d8acf6813f3bac66c41f400969cefc460a36b5aa","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                conn_timeout\u003dself.app.conn_timeout,"},{"line_number":760,"context_line":"                node_timeout\u003dself.app.node_timeout,"},{"line_number":761,"context_line":"                logger\u003dself.app.logger,"},{"line_number":762,"context_line":"                chunked\u003dte.endswith(\u0027,chunked\u0027))"},{"line_number":763,"context_line":"        return putter"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def _transfer_data(self, req, data_source, putters, nodes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_2391be52","line":762,"range":{"start_line":762,"start_character":24,"end_line":762,"end_character":47},"in_reply_to":"3fa0c359_ad08f890","updated":"2018-02-26 12:22:54.000000000","message":"Good point.","commit_id":"122c787e630da1c676f40e99c13d317670d5f888"}]}