)]}'
{"swift/common/ring/composite_builder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8ae9681bdf6a65485723b9eaa23deb07f5b06466","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        builder_files \u003d builder_files or self._builder_files"},{"line_number":509,"context_line":"        self.builders \u003d builders \u003d ["},{"line_number":510,"context_line":"            CooperativeRingBuilder.load(f, composite_builder\u003dself)"},{"line_number":511,"context_line":"            for f in builder_files]"},{"line_number":512,"context_line":"        check_builder_ids(builders)"},{"line_number":513,"context_line":"        new_metadata \u003d _make_composite_metadata(builders)"},{"line_number":514,"context_line":"        if self.components and self._builder_files and not force:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_29c88b53","line":511,"updated":"2017-06-29 14:01:26.000000000","message":"+1 for passing whatever ref to cobuilders via load()","commit_id":"030ddd77c1206d38abca32741b37f60aa8ac636a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8ae9681bdf6a65485723b9eaa23deb07f5b06466","unresolved":false,"context_lines":[{"line_number":629,"context_line":"    def _cobuilders(self):"},{"line_number":630,"context_line":"        if not self.composite_builder:"},{"line_number":631,"context_line":"            return {self}"},{"line_number":632,"context_line":"        return self.composite_builder.builders or {self}"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"    @classmethod"},{"line_number":635,"context_line":"    def load(cls, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_69032d0f","line":632,"range":{"start_line":632,"start_character":15,"end_line":632,"end_character":46},"updated":"2017-06-29 14:01:26.000000000","message":"hmmm, so if we made CompositeRingBuilder support iteration (over its builders) then we could be ambivalent here about cobuilders be a set, list or a CompositeRingBuilder.\n\nI\u0027m not *yet* convinced about CooperativeRingBuilder digging back into CompositeRingBuilder.","commit_id":"030ddd77c1206d38abca32741b37f60aa8ac636a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8ae9681bdf6a65485723b9eaa23deb07f5b06466","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        off that bad boy so we can get at our cobuilders."},{"line_number":639,"context_line":"        \"\"\""},{"line_number":640,"context_line":"        composite_builder \u003d kwargs.pop(\u0027composite_builder\u0027)"},{"line_number":641,"context_line":"        rv \u003d cls.load(*args, **kwargs)"},{"line_number":642,"context_line":"        rv.composite_builder \u003d composite_builder"},{"line_number":643,"context_line":"        return rv"},{"line_number":644,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_8e132fb9","line":641,"range":{"start_line":641,"start_character":13,"end_line":641,"end_character":22},"updated":"2017-06-29 14:01:26.000000000","message":"yep, I was going to head this way with setting cobuilders, so something like this WFM whichever interface we end up with. But,\n\n  super(CooperativeRingBuilder, cls).load(...)\n\ncouldn\u0027t we just make RingBuilder.load accepts *args, **kwargs and have them passed through to the __init__, rather than popping here \u0027composite_builder\u0027 ?","commit_id":"030ddd77c1206d38abca32741b37f60aa8ac636a"}]}