)]}'
{"swift/common/middleware/x_profile/html_viewer.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"38aafaed7844866a5009a1d42c0c2cce2892abc5","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                                --\u003e\u003c/a\u003e\u003c/td\u003e\u003c/tr\u003e\u0027 % (app_path,"},{"line_number":531,"context_line":"                                                      profile_id, nfls))"},{"line_number":532,"context_line":"        except Exception as ex:"},{"line_number":533,"context_line":"            html.append(\"Exception:\" % six.text_type(ex))"},{"line_number":534,"context_line":"        return \u0027\u0027.join(html)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_e35f2c3f","line":533,"range":{"start_line":533,"start_character":39,"end_line":533,"end_character":52},"updated":"2017-07-13 13:08:10.000000000","message":"Why six.text_type rather than str(ex). I\u0027m concerned that if html has encoded non-ascii characters then we\u0027ll get a unicode error when the html list is joined:\n\n  \u0027\u0027.join([\u0027ĝ\u0027, six.text_type(\u0027foo\u0027)])\nUnicodeDecodeError: \u0027ascii\u0027 codec can\u0027t decode byte 0xc4 in position 0: ordinal not in range(128)","commit_id":"8cd67b53ca8b8920effa2bc199638fac86dc5916"}]}