)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"18660b5d389de5d850ae2662fe9275a3bf5fb15b","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes the get_local_devices to return empty set even when no ec config"},{"line_number":15,"context_line":"in swift.conf without errors."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic121fb547966787a43f9eae83c91bb2bf640c4be"},{"line_number":18,"context_line":"Related-Change: 701a172afac37229b85ea762f20428f6f422d29b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_36d7c2f0","line":16,"updated":"2017-07-31 09:33:04.000000000","message":"add\n\n  Closes-Bug: #1707595","commit_id":"a684f8ab5a5b4e1004937b7063f7ca5b4c5dbe95"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"422a294192a5db238272d93c9cc2949ac20c5190","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes the get_local_devices to return empty set even when no ec config"},{"line_number":15,"context_line":"in swift.conf without errors."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic121fb547966787a43f9eae83c91bb2bf640c4be"},{"line_number":18,"context_line":"Related-Change: 701a172afac37229b85ea762f20428f6f422d29b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_c1a9cedf","line":16,"in_reply_to":"df3967d1_36d7c2f0","updated":"2017-07-31 09:48:25.000000000","message":"Done","commit_id":"a684f8ab5a5b4e1004937b7063f7ca5b4c5dbe95"}],"swift/obj/reconstructor.py":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"d5f734765d37894b47b2d504b3c9d41385d6db68","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        if policy2devices:"},{"line_number":1037,"context_line":"            return reduce(set.union, ("},{"line_number":1038,"context_line":"                set(d[\u0027device\u0027] for d in devices)"},{"line_number":1039,"context_line":"                for devices in policy2devices.values()))"},{"line_number":1040,"context_line":"        else:"},{"line_number":1041,"context_line":"            return set()"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_96d0aef9","line":1039,"updated":"2017-07-31 09:32:44.000000000","message":"please provide an initial value here instead of an if reduce allows initial values: https://docs.python.org/2/library/functions.html#reduce","commit_id":"a684f8ab5a5b4e1004937b7063f7ca5b4c5dbe95"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"422a294192a5db238272d93c9cc2949ac20c5190","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        if policy2devices:"},{"line_number":1037,"context_line":"            return reduce(set.union, ("},{"line_number":1038,"context_line":"                set(d[\u0027device\u0027] for d in devices)"},{"line_number":1039,"context_line":"                for devices in policy2devices.values()))"},{"line_number":1040,"context_line":"        else:"},{"line_number":1041,"context_line":"            return set()"},{"line_number":1042,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_616342de","line":1039,"in_reply_to":"df3967d1_96d0aef9","updated":"2017-07-31 09:48:25.000000000","message":"Done","commit_id":"a684f8ab5a5b4e1004937b7063f7ca5b4c5dbe95"}],"test/unit/obj/test_reconstructor.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"18660b5d389de5d850ae2662fe9275a3bf5fb15b","unresolved":false,"context_lines":[{"line_number":3865,"context_line":"        # even no ec_policy found on the server, it runs just like as"},{"line_number":3866,"context_line":"        # no ec device found"},{"line_number":3867,"context_line":"        self.policy \u003d POLICIES.default"},{"line_number":3868,"context_line":"        self._configure_reconstructor()"},{"line_number":3869,"context_line":"        local_devs \u003d self.reconstructor.get_local_devices()"},{"line_number":3870,"context_line":"        self.assertEqual(set(), local_devs)"},{"line_number":3871,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_16ddde13","line":3868,"updated":"2017-07-31 09:33:04.000000000","message":"maybe add a sanity check that there are no policies?","commit_id":"a684f8ab5a5b4e1004937b7063f7ca5b4c5dbe95"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"422a294192a5db238272d93c9cc2949ac20c5190","unresolved":false,"context_lines":[{"line_number":3865,"context_line":"        # even no ec_policy found on the server, it runs just like as"},{"line_number":3866,"context_line":"        # no ec device found"},{"line_number":3867,"context_line":"        self.policy \u003d POLICIES.default"},{"line_number":3868,"context_line":"        self._configure_reconstructor()"},{"line_number":3869,"context_line":"        local_devs \u003d self.reconstructor.get_local_devices()"},{"line_number":3870,"context_line":"        self.assertEqual(set(), local_devs)"},{"line_number":3871,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_01a0f6f3","line":3868,"in_reply_to":"df3967d1_16ddde13","updated":"2017-07-31 09:48:25.000000000","message":"Done","commit_id":"a684f8ab5a5b4e1004937b7063f7ca5b4c5dbe95"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"217f4679cbcbc544d81f31c652039723e1e5a429","unresolved":false,"context_lines":[{"line_number":3864,"context_line":"    def test_get_local_devices_with_no_ec_policy_env(self):"},{"line_number":3865,"context_line":"        # even no ec_policy found on the server, it runs just like as"},{"line_number":3866,"context_line":"        # no ec device found"},{"line_number":3867,"context_line":"        self.policy \u003d POLICIES.default"},{"line_number":3868,"context_line":"        self._configure_reconstructor()"},{"line_number":3869,"context_line":"        self.assertEqual([], self.reconstructor.policies)"},{"line_number":3870,"context_line":"        local_devs \u003d self.reconstructor.get_local_devices()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_5e2b6fea","line":3867,"updated":"2017-07-31 17:25:55.000000000","message":"This is unused, yeah?","commit_id":"45cc1d02d06f33530cefe742465828f5d0d5cd12"}]}
