)]}'
{"swift/proxy/controllers/base.py":[{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"67ee0587a7c075633c2ca8e4081167f1d9060ea1","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \u0027container_count\u0027: headers.get(\u0027x-account-container-count\u0027),"},{"line_number":145,"context_line":"        \u0027total_object_count\u0027: headers.get(\u0027x-account-object-count\u0027),"},{"line_number":146,"context_line":"        \u0027bytes\u0027: headers.get(\u0027x-account-bytes-used\u0027),"},{"line_number":147,"context_line":"        \u0027storage_policies\u0027: {policy.name: {"},{"line_number":148,"context_line":"            \u0027container_count\u0027: headers.get("},{"line_number":149,"context_line":"                \u0027x-account-storage-policy-{}-container-count\u0027.format("},{"line_number":150,"context_line":"                    policy.name)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_0d31f2ec","line":147,"updated":"2017-08-11 15:15:21.000000000","message":"I think I would prefer to access the values by policy index. policy name seems only used for display. AFAIK, internally, only index is used everywhere","commit_id":"9590da414a8b97c24661b7fc045c5f93d36fd779"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"67ee0587a7c075633c2ca8e4081167f1d9060ea1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        \u0027total_object_count\u0027: headers.get(\u0027x-account-object-count\u0027),"},{"line_number":146,"context_line":"        \u0027bytes\u0027: headers.get(\u0027x-account-bytes-used\u0027),"},{"line_number":147,"context_line":"        \u0027storage_policies\u0027: {policy.name: {"},{"line_number":148,"context_line":"            \u0027container_count\u0027: headers.get("},{"line_number":149,"context_line":"                \u0027x-account-storage-policy-{}-container-count\u0027.format("},{"line_number":150,"context_line":"                    policy.name)),"},{"line_number":151,"context_line":"            \u0027total_object_count\u0027: headers.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_4d0eda32","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":42},"updated":"2017-08-11 15:15:21.000000000","message":"Could you cast the values as integer?","commit_id":"9590da414a8b97c24661b7fc045c5f93d36fd779"},{"author":{"_account_id":17245,"name":"Christopher Bartz","email":"bartz@dkrz.de","username":"cbartz"},"change_message_id":"1bd7629ad85d30b41c2949881a29826de09bf4e3","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        \u0027total_object_count\u0027: headers.get(\u0027x-account-object-count\u0027),"},{"line_number":146,"context_line":"        \u0027bytes\u0027: headers.get(\u0027x-account-bytes-used\u0027),"},{"line_number":147,"context_line":"        \u0027storage_policies\u0027: {policy.name: {"},{"line_number":148,"context_line":"            \u0027container_count\u0027: headers.get("},{"line_number":149,"context_line":"                \u0027x-account-storage-policy-{}-container-count\u0027.format("},{"line_number":150,"context_line":"                    policy.name)),"},{"line_number":151,"context_line":"            \u0027total_object_count\u0027: headers.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_1f7c5470","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":42},"in_reply_to":"9f436f4f_4d0eda32","updated":"2017-08-14 09:40:08.000000000","message":"First I was also think of doing that, but after reading the commentary (Lines 140 - 143) and seeing that its done no where else here, I didn\u0027t. \n\nNevertheless, in the new patchset I\u0027ll submit I\u0027\u0027 cast it, because it is new code and should not break previous behaviour.","commit_id":"9590da414a8b97c24661b7fc045c5f93d36fd779"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"67ee0587a7c075633c2ca8e4081167f1d9060ea1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027container_count\u0027: headers.get("},{"line_number":149,"context_line":"                \u0027x-account-storage-policy-{}-container-count\u0027.format("},{"line_number":150,"context_line":"                    policy.name)),"},{"line_number":151,"context_line":"            \u0027total_object_count\u0027: headers.get("},{"line_number":152,"context_line":"                \u0027x-account-storage-policy-{}-object-count\u0027.format("},{"line_number":153,"context_line":"                    policy.name)),"},{"line_number":154,"context_line":"            \u0027bytes\u0027: headers.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_3208932a","line":151,"range":{"start_line":151,"start_character":13,"end_line":151,"end_character":31},"updated":"2017-08-11 15:15:21.000000000","message":"object_count seems more suited for that name","commit_id":"9590da414a8b97c24661b7fc045c5f93d36fd779"},{"author":{"_account_id":17245,"name":"Christopher Bartz","email":"bartz@dkrz.de","username":"cbartz"},"change_message_id":"1bd7629ad85d30b41c2949881a29826de09bf4e3","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027container_count\u0027: headers.get("},{"line_number":149,"context_line":"                \u0027x-account-storage-policy-{}-container-count\u0027.format("},{"line_number":150,"context_line":"                    policy.name)),"},{"line_number":151,"context_line":"            \u0027total_object_count\u0027: headers.get("},{"line_number":152,"context_line":"                \u0027x-account-storage-policy-{}-object-count\u0027.format("},{"line_number":153,"context_line":"                    policy.name)),"},{"line_number":154,"context_line":"            \u0027bytes\u0027: headers.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_dfdecc6b","line":151,"range":{"start_line":151,"start_character":13,"end_line":151,"end_character":31},"in_reply_to":"9f436f4f_3208932a","updated":"2017-08-14 09:40:08.000000000","message":"Its discussible. I believe the total means \u003d all containers .","commit_id":"9590da414a8b97c24661b7fc045c5f93d36fd779"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"67ee0587a7c075633c2ca8e4081167f1d9060ea1","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                    policy.name)),"},{"line_number":154,"context_line":"            \u0027bytes\u0027: headers.get("},{"line_number":155,"context_line":"                \u0027x-account-storage-policy-{}-bytes-used\u0027.format(policy.name))}"},{"line_number":156,"context_line":"            for policy in POLICIES"},{"line_number":157,"context_line":"        },"},{"line_number":158,"context_line":"        \u0027meta\u0027: meta,"},{"line_number":159,"context_line":"        \u0027sysmeta\u0027: sysmeta,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_0d18d272","line":156,"updated":"2017-08-11 15:15:21.000000000","message":"Are we sure all policies will always have a value in headers (especially after account creation, when no containers exist yet) ?\nMay be it is worth it to put 0 as a default values.","commit_id":"9590da414a8b97c24661b7fc045c5f93d36fd779"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"67ee0587a7c075633c2ca8e4081167f1d9060ea1","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            # Test the internal representation in memcache"},{"line_number":327,"context_line":"            # \u0027container_count\u0027 changed from int to str"},{"line_number":328,"context_line":"            cache_key \u003d get_cache_key(self.account)"},{"line_number":329,"context_line":"            container_info \u003d {\u0027status\u0027: 200,"},{"line_number":330,"context_line":"                              \u0027account_really_exists\u0027: True,"},{"line_number":331,"context_line":"                              \u0027container_count\u0027: \u002712345\u0027,"},{"line_number":332,"context_line":"                              \u0027total_object_count\u0027: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_6daf5ee3","line":329,"range":{"start_line":329,"start_character":12,"end_line":329,"end_character":26},"updated":"2017-08-11 15:15:21.000000000","message":"huh, am I missing something or this variable is badly named?\nwe should fix it in a separate review","commit_id":"9590da414a8b97c24661b7fc045c5f93d36fd779"},{"author":{"_account_id":17245,"name":"Christopher Bartz","email":"bartz@dkrz.de","username":"cbartz"},"change_message_id":"1bd7629ad85d30b41c2949881a29826de09bf4e3","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            # Test the internal representation in memcache"},{"line_number":327,"context_line":"            # \u0027container_count\u0027 changed from int to str"},{"line_number":328,"context_line":"            cache_key \u003d get_cache_key(self.account)"},{"line_number":329,"context_line":"            container_info \u003d {\u0027status\u0027: 200,"},{"line_number":330,"context_line":"                              \u0027account_really_exists\u0027: True,"},{"line_number":331,"context_line":"                              \u0027container_count\u0027: \u002712345\u0027,"},{"line_number":332,"context_line":"                              \u0027total_object_count\u0027: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_a490a1ee","line":329,"range":{"start_line":329,"start_character":12,"end_line":329,"end_character":26},"in_reply_to":"9f436f4f_6daf5ee3","updated":"2017-08-14 09:40:08.000000000","message":"I was also confused by this.","commit_id":"9590da414a8b97c24661b7fc045c5f93d36fd779"}]}