)]}'
{"test/unit/proxy/controllers/test_obj.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"69278d1daa2fa2a1711a8be693cd3e72d1d06947","unresolved":false,"context_lines":[{"line_number":2843,"context_line":"            if fi is not None:"},{"line_number":2844,"context_line":"                collected_indexes[fi].append(conn)"},{"line_number":2845,"context_line":"        self.assertEqual(len(collected_indexes), self.policy.ec_ndata - 1)"},{"line_number":2846,"context_line":"        self.assertEqual({obj1[\u0027etag\u0027], None}, collected_etags)"},{"line_number":2847,"context_line":""},{"line_number":2848,"context_line":"    def test_GET_with_missing_and_mixed_frags_may_503(self):"},{"line_number":2849,"context_line":"        obj1 \u003d self._make_ec_object_stub(pattern\u003d\u0027obj1\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_ac049a7f","side":"PARENT","line":2846,"updated":"2017-08-17 20:43:00.000000000","message":"We lost this assertion... but I guess it wasn\u0027t a terribly good/useful assertion to begin with?","commit_id":"f9cacb37409d2d7aab03ef5f2aab5038cc283377"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a7a4579424ddece56fed34a778bdcdb94a8c3fa4","unresolved":false,"context_lines":[{"line_number":2843,"context_line":"            if fi is not None:"},{"line_number":2844,"context_line":"                collected_indexes[fi].append(conn)"},{"line_number":2845,"context_line":"        self.assertEqual(len(collected_indexes), self.policy.ec_ndata - 1)"},{"line_number":2846,"context_line":"        self.assertEqual({obj1[\u0027etag\u0027], None}, collected_etags)"},{"line_number":2847,"context_line":""},{"line_number":2848,"context_line":"    def test_GET_with_missing_and_mixed_frags_may_503(self):"},{"line_number":2849,"context_line":"        obj1 \u003d self._make_ec_object_stub(pattern\u003d\u0027obj1\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_80a86ddb","side":"PARENT","line":2846,"in_reply_to":"9f436f4f_ac049a7f","updated":"2017-08-18 08:00:38.000000000","message":"hmmm, I confess that was not intentional (to drop the assertion on etags), I had not noticed that difference between the two implementation of this test. Of the four similar tests that were refactored, the etag collection and assertion was for some reason unique to this one. However, I don\u0027t think it matters - we do similar assertions in other tests e.g. line 2713 above (this version):\n\n  self.assertEqual(len(collected_responses), 3)\n\nthe expected count of 3 being due to etag(obj1), etag(obj2) and None from 404\u0027s","commit_id":"f9cacb37409d2d7aab03ef5f2aab5038cc283377"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e8ea1433c65388398774d53ce7099bcce6dc8a1e","unresolved":false,"context_lines":[{"line_number":4212,"context_line":""},{"line_number":4213,"context_line":"        # proxy will access randomly to a node in the second set"},{"line_number":4214,"context_line":"        # so to ensure the GET fragment meets what it needs."},{"line_number":4215,"context_line":"        node_frags +\u003d [{\u0027obj\u0027: obj1, \u0027frag\u0027: 5}]"},{"line_number":4216,"context_line":"        # rests are 404s"},{"line_number":4217,"context_line":"        node_frags +\u003d [[]] * (self.replicas() - len(node_frags))"},{"line_number":4218,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_1376503f","side":"PARENT","line":4215,"range":{"start_line":4215,"start_character":8,"end_line":4215,"end_character":48},"updated":"2017-08-16 11:25:21.000000000","message":"this was cause of intermittent test failure - this is on a primary node so it is possible for sufficient unique frags to be fetched without using ec_n_unique_fragments primaries.\n\nAFAICT the intent was for this final unique frag to be on the first handoff.","commit_id":"f9cacb37409d2d7aab03ef5f2aab5038cc283377"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"fd333343c44a7d3464d0fcb1d62983e1bb50298b","unresolved":false,"context_lines":[{"line_number":1625,"context_line":""},{"line_number":1626,"context_line":"    def _fake_ec_node_response(self, node_frags):"},{"line_number":1627,"context_line":"        return fake_ec_node_response(node_frags, self.policy)"},{"line_number":1628,"context_line":""},{"line_number":1629,"context_line":"    def test_GET_with_duplicate_but_sufficient_frag_indexes(self):"},{"line_number":1630,"context_line":"        obj1 \u003d self._make_ec_object_stub()"},{"line_number":1631,"context_line":"        # proxy should ignore duplicated frag indexes and continue search for"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_38cfd229","line":1628,"updated":"2017-08-17 11:32:03.000000000","message":"This is moved from BaseObjectControllerMixin because it is needed only for EC Tests, nice.","commit_id":"88252cdfd6c1e446f4d1cde6cc07a9c67b701e65"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"fd333343c44a7d3464d0fcb1d62983e1bb50298b","unresolved":false,"context_lines":[{"line_number":1645,"context_line":"            {\u0027obj\u0027: obj1, \u0027frag\u0027: 11},"},{"line_number":1646,"context_line":"            {\u0027obj\u0027: obj1, \u0027frag\u0027: 12},"},{"line_number":1647,"context_line":"            {\u0027obj\u0027: obj1, \u0027frag\u0027: 13},"},{"line_number":1648,"context_line":"        ] * self.policy.ec_duplication_factor"},{"line_number":1649,"context_line":"        node_frags.append({\u0027obj\u0027: obj1, \u0027frag\u0027: 5})  # first handoff"},{"line_number":1650,"context_line":""},{"line_number":1651,"context_line":"        fake_response \u003d self._fake_ec_node_response(node_frags)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_b8a98224","line":1648,"range":{"start_line":1648,"start_character":10,"end_line":1648,"end_character":45},"updated":"2017-08-17 11:32:03.000000000","message":"Make sense. this is what we need!","commit_id":"88252cdfd6c1e446f4d1cde6cc07a9c67b701e65"}]}