)]}'
{"test/unit/cli/test_ringbuilder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f366b71d1f3602a3ea67715b064dbf8e8c511a68","unresolved":false,"context_lines":[{"line_number":2104,"context_line":"        fake_balance \u003d 6"},{"line_number":2105,"context_line":""},{"line_number":2106,"context_line":"        def fake_rebalance(builder_instance, *args, **kwargs):"},{"line_number":2107,"context_line":"            parts, balance, removed_devs \u003d orig_rebalance(builder_instance)"},{"line_number":2108,"context_line":"            return parts, fake_balance, removed_devs"},{"line_number":2109,"context_line":""},{"line_number":2110,"context_line":"        argv \u003d [\"\", self.tmpfile, \"rebalance\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_ba594cff","line":2107,"range":{"start_line":2107,"start_character":43,"end_line":2107,"end_character":57},"updated":"2017-09-11 17:37:35.000000000","message":"And here I was hoping that we\u0027d skip a real rebalance entirely :-( *shrug*","commit_id":"079be1d5cddcaafbae0cae983cd908bac351d33b"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f1d54efd1468f9afdf61470467c0ce1e8adfd26c","unresolved":false,"context_lines":[{"line_number":2104,"context_line":"        fake_balance \u003d 6"},{"line_number":2105,"context_line":""},{"line_number":2106,"context_line":"        def fake_rebalance(builder_instance, *args, **kwargs):"},{"line_number":2107,"context_line":"            parts, balance, removed_devs \u003d orig_rebalance(builder_instance)"},{"line_number":2108,"context_line":"            return parts, fake_balance, removed_devs"},{"line_number":2109,"context_line":""},{"line_number":2110,"context_line":"        argv \u003d [\"\", self.tmpfile, \"rebalance\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_1a2bc094","line":2107,"range":{"start_line":2107,"start_character":43,"end_line":2107,"end_character":57},"in_reply_to":"5f2577a7_ba594cff","updated":"2017-09-11 18:02:01.000000000","message":"we need to do the rebabalnce or another post-rebalance check fails before we get to checking the balance","commit_id":"079be1d5cddcaafbae0cae983cd908bac351d33b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f366b71d1f3602a3ea67715b064dbf8e8c511a68","unresolved":false,"context_lines":[{"line_number":2113,"context_line":"            self.assertSystemExit(EXIT_WARNING, ringbuilder.main, argv)"},{"line_number":2114,"context_line":""},{"line_number":2115,"context_line":"        # even when some overload is allowed"},{"line_number":2116,"context_line":"        self.create_sample_ring(overload\u003d0.05)"},{"line_number":2117,"context_line":"        argv \u003d [\"\", self.tmpfile, \"rebalance\"]"},{"line_number":2118,"context_line":"        with mock.patch(\"swift.common.ring.builder.RingBuilder.rebalance\","},{"line_number":2119,"context_line":"                        fake_rebalance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_da32d8a7","line":2116,"range":{"start_line":2116,"start_character":41,"end_line":2116,"end_character":45},"updated":"2017-09-11 17:37:35.000000000","message":"So if it was more than 6, we\u0027d be OK?","commit_id":"079be1d5cddcaafbae0cae983cd908bac351d33b"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f1d54efd1468f9afdf61470467c0ce1e8adfd26c","unresolved":false,"context_lines":[{"line_number":2113,"context_line":"            self.assertSystemExit(EXIT_WARNING, ringbuilder.main, argv)"},{"line_number":2114,"context_line":""},{"line_number":2115,"context_line":"        # even when some overload is allowed"},{"line_number":2116,"context_line":"        self.create_sample_ring(overload\u003d0.05)"},{"line_number":2117,"context_line":"        argv \u003d [\"\", self.tmpfile, \"rebalance\"]"},{"line_number":2118,"context_line":"        with mock.patch(\"swift.common.ring.builder.RingBuilder.rebalance\","},{"line_number":2119,"context_line":"                        fake_rebalance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_7a0d243d","line":2116,"range":{"start_line":2116,"start_character":41,"end_line":2116,"end_character":45},"in_reply_to":"5f2577a7_da32d8a7","updated":"2017-09-11 18:02:01.000000000","message":"yes as per line 2139 on, balance \u003d\u003d 6 and overload \u003d 0.06 is ok","commit_id":"079be1d5cddcaafbae0cae983cd908bac351d33b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f366b71d1f3602a3ea67715b064dbf8e8c511a68","unresolved":false,"context_lines":[{"line_number":2137,"context_line":""},{"line_number":2138,"context_line":"        # ...or balance is within permitted overload"},{"line_number":2139,"context_line":"        self.create_sample_ring(overload\u003d0.06)"},{"line_number":2140,"context_line":"        fake_balance \u003d 6"},{"line_number":2141,"context_line":"        argv \u003d [\"\", self.tmpfile, \"rebalance\"]"},{"line_number":2142,"context_line":"        with mock.patch(\"swift.common.ring.builder.RingBuilder.rebalance\","},{"line_number":2143,"context_line":"                        fake_rebalance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_dad77823","line":2140,"updated":"2017-09-11 17:37:35.000000000","message":"And here, if the balance was any higher, or the overload was any lower, we\u0027d get a warning again.","commit_id":"079be1d5cddcaafbae0cae983cd908bac351d33b"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f1d54efd1468f9afdf61470467c0ce1e8adfd26c","unresolved":false,"context_lines":[{"line_number":2137,"context_line":""},{"line_number":2138,"context_line":"        # ...or balance is within permitted overload"},{"line_number":2139,"context_line":"        self.create_sample_ring(overload\u003d0.06)"},{"line_number":2140,"context_line":"        fake_balance \u003d 6"},{"line_number":2141,"context_line":"        argv \u003d [\"\", self.tmpfile, \"rebalance\"]"},{"line_number":2142,"context_line":"        with mock.patch(\"swift.common.ring.builder.RingBuilder.rebalance\","},{"line_number":2143,"context_line":"                        fake_rebalance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_1a04e016","line":2140,"in_reply_to":"5f2577a7_dad77823","updated":"2017-09-11 18:02:01.000000000","message":"yes","commit_id":"079be1d5cddcaafbae0cae983cd908bac351d33b"}]}