)]}'
{"swift/proxy/controllers/base.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bedf7a73d56c9fa199a88360c76e56205159f3b5","unresolved":false,"context_lines":[{"line_number":1980,"context_line":"            pivot_range[\u0027timestamp\u0027] \u003d pivot_range[\u0027created_at\u0027]"},{"line_number":1981,"context_line":"            del pivot_range[\u0027created_at\u0027]"},{"line_number":1982,"context_line":""},{"line_number":1983,"context_line":"        return [PivotRange(**pivot_range) for pivot_range in pivot_range_list]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_74dba7ec","line":1983,"range":{"start_line":1983,"start_character":16,"end_line":1983,"end_character":41},"updated":"2017-09-14 07:29:41.000000000","message":"I worry a bit about this causing trouble if we ever need to add more fields to the response dicts... an upgraded container server could start emitting new keys that cause this to raise a TypeError.\n\nMight be better to be defensive and whitelist the kwargs we know about?","commit_id":"6863133a8c2a49075782b24777afc39babfa6037"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cfc3e3a523efed44f27370a21543ab2ed9606e7e","unresolved":false,"context_lines":[{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"        if not is_success(response.status_int):"},{"line_number":1986,"context_line":"            self.app.logger.debug("},{"line_number":1987,"context_line":"                \"Failed to fetch shard ranges from /%s; status\u003d%s.\" %"},{"line_number":1988,"context_line":"                (path, response.status_int))"},{"line_number":1989,"context_line":"            # TODO: return [] or None to indicate failure?"},{"line_number":1990,"context_line":"            return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_286f8bc6","line":1987,"range":{"start_line":1987,"start_character":51,"end_line":1987,"end_character":52},"updated":"2017-09-19 22:44:17.000000000","message":"Doesn\u0027t path already start with a \u0027/\u0027?","commit_id":"4128e6910ea2f343924e3fedb693c6d79851f266"}],"test/unit/proxy/controllers/test_base.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bedf7a73d56c9fa199a88360c76e56205159f3b5","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"        with mock.patch("},{"line_number":1041,"context_line":"                \u0027swift.proxy.controllers.base.http_connect\u0027,"},{"line_number":1042,"context_line":"                fake_http_connect(200, 200, 200,"},{"line_number":1043,"context_line":"                                  body\u003djson.dumps(pivot_ranges),"},{"line_number":1044,"context_line":"                                  give_connect\u003don_connect)):"},{"line_number":1045,"context_line":"            actual \u003d base._get_pivot_ranges(req, \u0027a\u0027, \u0027c\u0027)"},{"line_number":1046,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_3493dffc","line":1043,"updated":"2017-09-14 07:29:41.000000000","message":"Hmm... what if they don\u0027t all respond with the same pivots?","commit_id":"6863133a8c2a49075782b24777afc39babfa6037"}]}