)]}'
{"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b4ddb18d991562779242f7e434c8fb658b9c708f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                        node[\u0027replication_ip\u0027],"},{"line_number":150,"context_line":"                                        node[\u0027replication_port\u0027]):"},{"line_number":151,"context_line":"                results.add(node[\u0027device\u0027])"},{"line_number":152,"context_line":"                self._local_device_ids.add(node[\u0027id\u0027])"},{"line_number":153,"context_line":"        return results"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _get_shard_ranges(self, account, container, newest\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_62a2259d","line":152,"updated":"2017-09-19 20:21:53.000000000","message":"Speaking of self._local_device_ids, this always struck me as a weird side-effect... but I guess it\u0027s never called?","commit_id":"f65b6631cfd7e85e44b1ff610b566767e83eeaed"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b4ddb18d991562779242f7e434c8fb658b9c708f","unresolved":false,"context_lines":[{"line_number":648,"context_line":"            if node and is_local_device(self.ips, self.port,"},{"line_number":649,"context_line":"                                        node[\u0027replication_ip\u0027],"},{"line_number":650,"context_line":"                                        node[\u0027replication_port\u0027]):"},{"line_number":651,"context_line":"                if self.mount_check and not ismount("},{"line_number":652,"context_line":"                        os.path.join(self.root, node[\u0027device\u0027])):"},{"line_number":653,"context_line":"                    self.logger.warn("},{"line_number":654,"context_line":"                        \u0027Skipping %(device)s as it is not mounted\u0027 % node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_024c89c5","line":651,"range":{"start_line":651,"start_character":44,"end_line":651,"end_character":51},"updated":"2017-09-19 20:21:53.000000000","message":"Offtopic: I wonder if we\u0027ll want to change this to use check_drive... see\n\n* https://review.openstack.org/#/c/458070/ and\n* https://review.openstack.org/#/c/500158/\n\n(Probably need to wait on a merge from master, though)","commit_id":"f65b6631cfd7e85e44b1ff610b566767e83eeaed"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b4ddb18d991562779242f7e434c8fb658b9c708f","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                    continue"},{"line_number":656,"context_line":"                datadir \u003d os.path.join(self.root, node[\u0027device\u0027], self.datadir)"},{"line_number":657,"context_line":"                if os.path.isdir(datadir):"},{"line_number":658,"context_line":"                    # TODO: do we need self._local_device_ids?"},{"line_number":659,"context_line":"                    self._local_device_ids.add(node[\u0027id\u0027])"},{"line_number":660,"context_line":"                    dirs.append((datadir, node[\u0027id\u0027]))"},{"line_number":661,"context_line":"        for part, path, node_id, node_idx in self.roundrobin_datadirs(dirs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_e205f57b","line":658,"updated":"2017-09-19 20:21:53.000000000","message":"Yes -- otherwise find_local_handoff_for_part in _get_shard_broker will fail.\n\nMight be worth pulling out the common bits of run_once between the sharder and replicator though?","commit_id":"f65b6631cfd7e85e44b1ff610b566767e83eeaed"}]}