)]}'
{"swift/container/backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"dc4c2c0080836428dcf943640a4c4a946f31a205","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            # Ensure account/container get populated"},{"line_number":1720,"context_line":"            self.get_info()"},{"line_number":1721,"context_line":"        path, ts \u003d self.metadata.get(\u0027X-Container-Sysmeta-Shard-Root\u0027,"},{"line_number":1722,"context_line":"                                     (\u0027/\u0027, None))"},{"line_number":1723,"context_line":"        account, container \u003d path.split(\u0027/\u0027)"},{"line_number":1724,"context_line":"        return account or self.account, container or self.container"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f5c4f37_b13509fa","line":1722,"range":{"start_line":1722,"start_character":38,"end_line":1722,"end_character":41},"updated":"2017-09-21 17:12:19.000000000","message":"So if we *actually* have \u0027/\u0027 stored for the root... we point to self? I was kinda thinking we should raise an error or something... Or return empty strings and probably trip an error elsewhere...\n\nMeh.","commit_id":"d58dfaa000f73a036b925d6e490af73841f8933b"}],"swift/obj/server.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"157198805ce3eaa75ca7805acabb1a9d8a075a87","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        acct \u003d cont \u003d None"},{"line_number":268,"context_line":"        if headers_out.get(\u0027X-Backend-Shard-Root\u0027):"},{"line_number":269,"context_line":"            acct, cont \u003d headers_out[\u0027X-Backend-Shard-Root\u0027].split(\u0027/\u0027)"},{"line_number":270,"context_line":"        full_path \u003d \u0027/%s/%s/%s\u0027 % (acct or account, cont or container, obj)"},{"line_number":271,"context_line":"        if all([host, partition, contdevice]):"},{"line_number":272,"context_line":"            try:"},{"line_number":273,"context_line":"                with ConnectionTimeout(self.conn_timeout):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f5c4f37_ececc8f4","line":270,"updated":"2017-09-21 16:53:26.000000000","message":"should we do:\n\n  if headers_out.get(\u0027X-Backend-Shard-Root\u0027):\n            acct, cont \u003d headers_out[\u0027X-Backend-Shard-Root\u0027].split(\u0027/\u0027)\n        full_path \u003d \u0027/%s/%s\u0027 % (headers_out[\u0027X-Backend-Shard-Root\u0027], obj)\n  else:\n      full_path \u003d \u0027/%s/%s/%s\u0027 % (account, container, obj)\n\nso we never mangle an acct with a container or an account with a cont?","commit_id":"d58dfaa000f73a036b925d6e490af73841f8933b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"db5bfc7f88d9420c2b8e0ebce79f13864881b385","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        acct \u003d cont \u003d None"},{"line_number":268,"context_line":"        if headers_out.get(\u0027X-Backend-Shard-Root\u0027):"},{"line_number":269,"context_line":"            acct, cont \u003d headers_out[\u0027X-Backend-Shard-Root\u0027].split(\u0027/\u0027)"},{"line_number":270,"context_line":"        full_path \u003d \u0027/%s/%s/%s\u0027 % (acct or account, cont or container, obj)"},{"line_number":271,"context_line":"        if all([host, partition, contdevice]):"},{"line_number":272,"context_line":"            try:"},{"line_number":273,"context_line":"                with ConnectionTimeout(self.conn_timeout):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f5c4f37_876f67c4","line":270,"in_reply_to":"9f5c4f37_ececc8f4","updated":"2017-09-21 17:14:13.000000000","message":"Yeah, I had a similar thought looking it over. I\u0027ll go back through some review comments I left while approving recently and push up some general cleanups today.","commit_id":"d58dfaa000f73a036b925d6e490af73841f8933b"}],"swift/proxy/controllers/obj.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"dc4c2c0080836428dcf943640a4c4a946f31a205","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                overide_prefix \u003d \u0027X-Backend-Container-Update-Override\u0027"},{"line_number":245,"context_line":"                root_path \u003d \u0027%s/%s\u0027 % (shard_acct, shard)"},{"line_number":246,"context_line":"                container_meta \u003d {"},{"line_number":247,"context_line":"                    \u0027%s-Backend-Shard-Root\u0027 % overide_prefix: root_path"},{"line_number":248,"context_line":"                }"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"                return partition, nodes, container_meta"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f5c4f37_6ce1f8fe","line":247,"range":{"start_line":247,"start_character":24,"end_line":247,"end_character":31},"updated":"2017-09-21 17:12:19.000000000","message":"Oh... I hadn\u0027t really noticed that before... so the complete header is\n\n X-Backend-Container-Update-Override-Backend-Shard-Root\n\n? Feels kinda silly saying Backend twice...","commit_id":"d58dfaa000f73a036b925d6e490af73841f8933b"}]}
