)]}'
{"doc/source/overview_container_sharding.rst":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"e77c832aaa590c6c8e4f2e211170f34d5b8c870b","unresolved":false,"context_lines":[{"line_number":553,"context_line":"objects. This is done with a GET to the container server, but with the"},{"line_number":554,"context_line":"items\u003dshard parameter set::"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"  GET /acc/cont?items\u003dshard\u0026format\u003djson"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"You can then build a list of shardRange objects. An example of how this is done"},{"line_number":559,"context_line":"can be seen in the _get_shard_ranges method in the container sharder daemon."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_e89d8e57","line":556,"range":{"start_line":556,"start_character":27,"end_line":556,"end_character":39},"updated":"2017-09-26 07:10:55.000000000","message":"this part shouldn\u0027t be required anymore thanks to Tim\u0027s extracting the listing formats into middleware. Everything should be talking json by default.","commit_id":"5e078ebd7adc66d8c1f0544c6603455ce4a8d795"}],"swift/container/backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4c66face6fdfcbdcf1c85d4d8798e0ef14118da0","unresolved":false,"context_lines":[{"line_number":1475,"context_line":"        \"\"\""},{"line_number":1476,"context_line":"        shard_ranges \u003d [ShardRange(*row)"},{"line_number":1477,"context_line":"                        for row in self.get_shard_range_rows()]"},{"line_number":1478,"context_line":"        if includes:"},{"line_number":1479,"context_line":"            shard_range \u003d find_shard_range(includes, shard_ranges)"},{"line_number":1480,"context_line":"            shard_ranges \u003d [shard_range] if shard_range else []"},{"line_number":1481,"context_line":"        if reverse:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_9138693d","line":1478,"updated":"2017-09-27 00:05:49.000000000","message":"Would we ever want to pass\n\n includes\u003d\u0027\u0027\n\n? Might be useful as a shorthand for \"give me the first shard\" ... but you could just as well use\n\n includes\u003d\u0027\\x00\u0027\n\n... Just debating about whether to make the condition\n\n if includes is not None:\n\n\nI suppose it probably doesn\u0027t really matter much.","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2c3aec2e8bf39042684ae541cbc835486926fb5a","unresolved":false,"context_lines":[{"line_number":1475,"context_line":"        \"\"\""},{"line_number":1476,"context_line":"        shard_ranges \u003d [ShardRange(*row)"},{"line_number":1477,"context_line":"                        for row in self.get_shard_range_rows()]"},{"line_number":1478,"context_line":"        if includes:"},{"line_number":1479,"context_line":"            shard_range \u003d find_shard_range(includes, shard_ranges)"},{"line_number":1480,"context_line":"            shard_ranges \u003d [shard_range] if shard_range else []"},{"line_number":1481,"context_line":"        if reverse:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_7602753f","line":1478,"in_reply_to":"7f515b1d_9138693d","updated":"2017-09-27 11:11:01.000000000","message":"could be confusing? should includes\u003d\u0027\u0027 return the first or last? \u0027\u0027 is in the final shard range, not the first, if we stick with the documented property that a shard includes the upper but not the lower.\n\nturns out that ShardRange considers \u0027\u0027 to be in \u0027\u0027 to \u0027foo\u0027 and not in \u0027foo\u0027 to \u0027\u0027 which is anomalous. https://trello.com/c/pyczXxij/99-fix-shardrange-contains-for","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4c66face6fdfcbdcf1c85d4d8798e0ef14118da0","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"                        for row in self.get_shard_range_rows()]"},{"line_number":1478,"context_line":"        if includes:"},{"line_number":1479,"context_line":"            shard_range \u003d find_shard_range(includes, shard_ranges)"},{"line_number":1480,"context_line":"            shard_ranges \u003d [shard_range] if shard_range else []"},{"line_number":1481,"context_line":"        if reverse:"},{"line_number":1482,"context_line":"            shard_ranges.reverse()"},{"line_number":1483,"context_line":"            marker, end_marker \u003d end_marker, marker"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_71d16dfb","line":1480,"updated":"2017-09-27 00:05:49.000000000","message":"Maybe just go ahead and return here? Reversing either of these has no effect, and we don\u0027t do anything with marker/end_marker if we have includes.","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2c3aec2e8bf39042684ae541cbc835486926fb5a","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"                        for row in self.get_shard_range_rows()]"},{"line_number":1478,"context_line":"        if includes:"},{"line_number":1479,"context_line":"            shard_range \u003d find_shard_range(includes, shard_ranges)"},{"line_number":1480,"context_line":"            shard_ranges \u003d [shard_range] if shard_range else []"},{"line_number":1481,"context_line":"        if reverse:"},{"line_number":1482,"context_line":"            shard_ranges.reverse()"},{"line_number":1483,"context_line":"            marker, end_marker \u003d end_marker, marker"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_569099ed","line":1480,"in_reply_to":"7f515b1d_71d16dfb","updated":"2017-09-27 11:11:01.000000000","message":"Done","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"}],"swift/container/server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4c66face6fdfcbdcf1c85d4d8798e0ef14118da0","unresolved":false,"context_lines":[{"line_number":647,"context_line":"            if reverse:"},{"line_number":648,"context_line":"                container_list.reverse()"},{"line_number":649,"context_line":"            if obj:"},{"line_number":650,"context_line":"                container_list \u003d [find_shard_range(obj, container_list)]"},{"line_number":651,"context_line":"            elif marker or end_marker:"},{"line_number":652,"context_line":"                def piv_filter(piv):"},{"line_number":653,"context_line":"                    end \u003d start \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_9149898c","side":"PARENT","line":650,"range":{"start_line":650,"start_character":34,"end_line":650,"end_character":50},"updated":"2017-09-27 00:05:49.000000000","message":"Good catch on this returning None","commit_id":"8e1f1a8760e1f685fc52fb6aa0f8c2737a9aba2a"}],"test/unit/container/test_server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4c66face6fdfcbdcf1c85d4d8798e0ef14118da0","unresolved":false,"context_lines":[{"line_number":2143,"context_line":"        # with end marker"},{"line_number":2144,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027, params\u003d\u0027\u0026end_marker\u003dcheese\u0027)"},{"line_number":2145,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027,"},{"line_number":2146,"context_line":"                        params\u003d\u0027\u0026marker\u003dcheese\u0026reverse\u003dtrue\u0027)"},{"line_number":2147,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027, params\u003d\u0027\u0026end_marker\u003dham\u0027)"},{"line_number":2148,"context_line":"        check_shard_GET(reversed(shard_ranges), \u0027a/c\u0027,"},{"line_number":2149,"context_line":"                        params\u003d\u0027\u0026end_marker\u003dham\u0026reverse\u003dtrue\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_11723912","line":2146,"range":{"start_line":2146,"start_character":33,"end_line":2146,"end_character":39},"updated":"2017-09-27 00:05:49.000000000","message":"end_marker?","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2c3aec2e8bf39042684ae541cbc835486926fb5a","unresolved":false,"context_lines":[{"line_number":2143,"context_line":"        # with end marker"},{"line_number":2144,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027, params\u003d\u0027\u0026end_marker\u003dcheese\u0027)"},{"line_number":2145,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027,"},{"line_number":2146,"context_line":"                        params\u003d\u0027\u0026marker\u003dcheese\u0026reverse\u003dtrue\u0027)"},{"line_number":2147,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027, params\u003d\u0027\u0026end_marker\u003dham\u0027)"},{"line_number":2148,"context_line":"        check_shard_GET(reversed(shard_ranges), \u0027a/c\u0027,"},{"line_number":2149,"context_line":"                        params\u003d\u0027\u0026end_marker\u003dham\u0026reverse\u003dtrue\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_7675d5ca","line":2146,"range":{"start_line":2146,"start_character":33,"end_line":2146,"end_character":39},"in_reply_to":"7f515b1d_11723912","updated":"2017-09-27 11:11:01.000000000","message":"Done","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4c66face6fdfcbdcf1c85d4d8798e0ef14118da0","unresolved":false,"context_lines":[{"line_number":2145,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027,"},{"line_number":2146,"context_line":"                        params\u003d\u0027\u0026marker\u003dcheese\u0026reverse\u003dtrue\u0027)"},{"line_number":2147,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027, params\u003d\u0027\u0026end_marker\u003dham\u0027)"},{"line_number":2148,"context_line":"        check_shard_GET(reversed(shard_ranges), \u0027a/c\u0027,"},{"line_number":2149,"context_line":"                        params\u003d\u0027\u0026end_marker\u003dham\u0026reverse\u003dtrue\u0027)"},{"line_number":2150,"context_line":"        check_shard_GET(shard_ranges[:2], \u0027a/c\u0027, params\u003d\u0027\u0026end_marker\u003dpickle\u0027)"},{"line_number":2151,"context_line":"        check_shard_GET(reversed(shard_ranges[1:]), \u0027a/c\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_31fe5537","line":2148,"range":{"start_line":2148,"start_character":33,"end_line":2148,"end_character":45},"updated":"2017-09-27 00:05:49.000000000","message":"Should this one include the first range? It includes ham as that\u0027s the upper, but end_marker isn\u0027t inclusive.","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2c3aec2e8bf39042684ae541cbc835486926fb5a","unresolved":false,"context_lines":[{"line_number":2145,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027,"},{"line_number":2146,"context_line":"                        params\u003d\u0027\u0026marker\u003dcheese\u0026reverse\u003dtrue\u0027)"},{"line_number":2147,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027, params\u003d\u0027\u0026end_marker\u003dham\u0027)"},{"line_number":2148,"context_line":"        check_shard_GET(reversed(shard_ranges), \u0027a/c\u0027,"},{"line_number":2149,"context_line":"                        params\u003d\u0027\u0026end_marker\u003dham\u0026reverse\u003dtrue\u0027)"},{"line_number":2150,"context_line":"        check_shard_GET(shard_ranges[:2], \u0027a/c\u0027, params\u003d\u0027\u0026end_marker\u003dpickle\u0027)"},{"line_number":2151,"context_line":"        check_shard_GET(reversed(shard_ranges[1:]), \u0027a/c\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_314f676c","line":2148,"range":{"start_line":2148,"start_character":33,"end_line":2148,"end_character":45},"in_reply_to":"7f515b1d_31fe5537","updated":"2017-09-27 11:11:01.000000000","message":"I\u0027m going to punt on this and add a TODO and trello card to revisit - we are also treating marker as inclusive which I am not sure is right or not - the API docs for object listing suggests neither marker nor end_marker are inclusive.\n\nhttps://trello.com/c/viKH6VmW/100-check-and-maybe-fix-handling-of-marker-and-endmarker-in-broker-getshardranges\n\ngood catch","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4c66face6fdfcbdcf1c85d4d8798e0ef14118da0","unresolved":false,"context_lines":[{"line_number":2160,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027,"},{"line_number":2161,"context_line":"                        params\u003d\u0027\u0026marker\u003dcheese\u0026end_marker\u003degg\u0027)"},{"line_number":2162,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027,"},{"line_number":2163,"context_line":"                        params\u003d\u0027\u0026marker\u003dcheese\u0026end_marker\u003degg\u0026reverse\u003dtrue\u0027)"},{"line_number":2164,"context_line":"        check_shard_GET(shard_ranges[:2], \u0027a/c\u0027,"},{"line_number":2165,"context_line":"                        params\u003d\u0027\u0026marker\u003degg\u0026end_marker\u003djam\u0027)"},{"line_number":2166,"context_line":"        check_shard_GET(reversed(shard_ranges[:2]), \u0027a/c\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_d1c141e6","line":2163,"updated":"2017-09-27 00:05:49.000000000","message":"Should this include anything? If it were an object listing it wouldn\u0027t, since we\u0027ve got reverse and marker \u003c end_marker.","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2c3aec2e8bf39042684ae541cbc835486926fb5a","unresolved":false,"context_lines":[{"line_number":2160,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027,"},{"line_number":2161,"context_line":"                        params\u003d\u0027\u0026marker\u003dcheese\u0026end_marker\u003degg\u0027)"},{"line_number":2162,"context_line":"        check_shard_GET(shard_ranges[:1], \u0027a/c\u0027,"},{"line_number":2163,"context_line":"                        params\u003d\u0027\u0026marker\u003dcheese\u0026end_marker\u003degg\u0026reverse\u003dtrue\u0027)"},{"line_number":2164,"context_line":"        check_shard_GET(shard_ranges[:2], \u0027a/c\u0027,"},{"line_number":2165,"context_line":"                        params\u003d\u0027\u0026marker\u003degg\u0026end_marker\u003djam\u0027)"},{"line_number":2166,"context_line":"        check_shard_GET(reversed(shard_ranges[:2]), \u0027a/c\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_f1542f00","line":2163,"in_reply_to":"7f515b1d_d1c141e6","updated":"2017-09-27 11:11:01.000000000","message":"ditto","commit_id":"58407474807679b11d5318ee1c82d47dd04f6bc5"}]}
