)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9bd1ca56852b731d87d6543f115a9b8d8e7f71ae","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * we\u0027re passing root_account, root_container around between methods"},{"line_number":10,"context_line":"   as well as broker, but i don;t think we expect them to ever change"},{"line_number":11,"context_line":"   during lifetime of a broker instance, so make them cached properties."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* change condition for is_root_container."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_6b075184","line":11,"updated":"2017-10-12 18:35:24.000000000","message":"+1","commit_id":"8d9cde95f766a68fc02a766940215087d0cafcb2"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9bd1ca56852b731d87d6543f115a9b8d8e7f71ae","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* with above two changes it would be possible to disable sharding"},{"line_number":21,"context_line":"  on a shard container, if ever required,  without removing"},{"line_number":22,"context_line":"  important sysmeta like it\u0027s root path"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Id25eb65f3d55d28fec55fb9d864f397a6885045c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_ebfa2173","line":22,"updated":"2017-10-12 18:35:24.000000000","message":"Yeah, that seems like a sane option to want to have.","commit_id":"8d9cde95f766a68fc02a766940215087d0cafcb2"}],"swift/container/backend.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9bd1ca56852b731d87d6543f115a9b8d8e7f71ae","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"        if self.container is None:"},{"line_number":1687,"context_line":"            # Ensure account/container get populated"},{"line_number":1688,"context_line":"            self.get_info()"},{"line_number":1689,"context_line":"        return self.root_container \u003d\u003d self.container"},{"line_number":1690,"context_line":""},{"line_number":1691,"context_line":"    def _get_next_shard_range_upper(self, shard_size, last_upper\u003dNone,"},{"line_number":1692,"context_line":"                                    connection\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_8b03ad0f","line":1689,"updated":"2017-10-12 18:35:24.000000000","message":"I\u0027m having a hard time imagining a scenario where it would be a problem, but I think I\u0027d still be happier if this was\n\n return (self.root_account \u003d\u003d self.account and\n         self.root_container \u003d\u003d self.container)","commit_id":"8d9cde95f766a68fc02a766940215087d0cafcb2"}],"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9bd1ca56852b731d87d6543f115a9b8d8e7f71ae","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                 \u0027Meta-Timestamp\u0027: shard_range.meta_timestamp.internal})"},{"line_number":231,"context_line":"            broker.update_metadata({"},{"line_number":232,"context_line":"                \u0027X-Container-Sysmeta-Sharding\u0027:"},{"line_number":233,"context_line":"                    (True, Timestamp.now().internal)})"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def _misplaced_objects(self, broker, node, own_shard_range):"},{"line_number":236,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_c693dca2","line":233,"range":{"start_line":233,"start_character":21,"end_line":233,"end_character":25},"updated":"2017-10-12 18:35:24.000000000","message":"We should probably make this a string. I could swear I\u0027ve seen some tracebacks at some point because our metadata values weren\u0027t strings...","commit_id":"8d9cde95f766a68fc02a766940215087d0cafcb2"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9bd1ca56852b731d87d6543f115a9b8d8e7f71ae","unresolved":false,"context_lines":[{"line_number":655,"context_line":"            # Need to do something here."},{"line_number":656,"context_line":"            return None, node_idx"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    def _update_shard_ranges(self, broker, op, shard_ranges):"},{"line_number":659,"context_line":"        part, nodes \u003d self.ring.get_nodes(broker.root_account,"},{"line_number":660,"context_line":"                                          broker.root_container)"},{"line_number":661,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_a65580c8","line":658,"range":{"start_line":658,"start_character":47,"end_line":658,"end_character":59},"updated":"2017-10-12 18:35:24.000000000","message":"I wonder if we should make this optional, defaulting to broker.get_shard_ranges()...\n\n*shrug*","commit_id":"8d9cde95f766a68fc02a766940215087d0cafcb2"}]}