)]}'
{"swift/container/sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"addd5f93f466818bf9d96867910dc69c106c8dd2","unresolved":false,"context_lines":[{"line_number":556,"context_line":"                    # but I think it is still ok to send these updates because"},{"line_number":557,"context_line":"                    # the meta_timestamp should prevent these updates undoing"},{"line_number":558,"context_line":"                    # any newer updates at the root from the actual shards."},{"line_number":559,"context_line":"                    # *It would be good to have a test to verify that.*"},{"line_number":560,"context_line":"                    self._update_shard_ranges(broker, \u0027PUT\u0027,"},{"line_number":561,"context_line":"                                              broker.get_shard_ranges())"},{"line_number":562,"context_line":"                    own_shard_range \u003d broker.get_own_shard_range()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_29a705aa","line":559,"updated":"2017-10-13 15:22:29.000000000","message":"Makes sense. I think you\u0027re right -- both that we should be safe on sending our (potentially out-of-date) shard ranges, and that we should have a test to verify it :-)","commit_id":"36231b0369b6f8a13f571b9596c333f4b57804b4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"addd5f93f466818bf9d96867910dc69c106c8dd2","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                if not broker.is_root_container():"},{"line_number":570,"context_line":"                    # update the root container with this shard\u0027s usage stats"},{"line_number":571,"context_line":"                    own_shard_range \u003d broker.get_own_shard_range()"},{"line_number":572,"context_line":"                    self._update_shard_ranges(broker, \u0027PUT\u0027, [own_shard_range])"},{"line_number":573,"context_line":"        finally:"},{"line_number":574,"context_line":"            self.logger.increment(\u0027scanned\u0027)"},{"line_number":575,"context_line":"            self.stats[\u0027containers_scanned\u0027] +\u003d 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_e9d9ed56","line":572,"updated":"2017-10-13 15:22:29.000000000","message":"Yeah, I like the placement here better :-)","commit_id":"36231b0369b6f8a13f571b9596c333f4b57804b4"}]}
