)]}'
{"test/unit/common/test_utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2b5d624717d2106856bc27e1d76fcd8ac90d9e76","unresolved":false,"context_lines":[{"line_number":979,"context_line":"                with utils.lock_path(tmpdir):"},{"line_number":980,"context_line":"                    with utils.lock_path(tmpdir):"},{"line_number":981,"context_line":"                        pass"},{"line_number":982,"context_line":"        except Exception as e:"},{"line_number":983,"context_line":"            exception_raised[0] \u003d True"},{"line_number":984,"context_line":"            self.assertTrue(\u0027sleep time changed\u0027 in str(e))"},{"line_number":985,"context_line":"        self.assertEqual(num_short_calls[0], 11)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_9ebdf1d9","line":982,"updated":"2017-10-24 18:49:24.000000000","message":"At some point we may want to replace this with an assertRaises, too.","commit_id":"e0244dd30d1974db1c522c3b4a2982eaed6c5297"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2759e4765cc549c74248e9bff9c494d66184a907","unresolved":false,"context_lines":[{"line_number":979,"context_line":"                with utils.lock_path(tmpdir):"},{"line_number":980,"context_line":"                    with utils.lock_path(tmpdir):"},{"line_number":981,"context_line":"                        pass"},{"line_number":982,"context_line":"        except Exception as e:"},{"line_number":983,"context_line":"            exception_raised[0] \u003d True"},{"line_number":984,"context_line":"            self.assertTrue(\u0027sleep time changed\u0027 in str(e))"},{"line_number":985,"context_line":"        self.assertEqual(num_short_calls[0], 11)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_2870d107","line":982,"in_reply_to":"3f4b6375_9ebdf1d9","updated":"2017-10-26 09:20:41.000000000","message":"huh, I missed that one :(","commit_id":"e0244dd30d1974db1c522c3b4a2982eaed6c5297"}],"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2b5d624717d2106856bc27e1d76fcd8ac90d9e76","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"        with self.df_mgr.replication_lock(self.existing_device):"},{"line_number":1026,"context_line":"            with self.assertRaises(ReplicationLockTimeout):"},{"line_number":1027,"context_line":"                with self.df_mgr.replication_lock(self.existing_device):"},{"line_number":1028,"context_line":"                    success \u003d True"},{"line_number":1029,"context_line":"        self.assertFalse(success)"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"    def test_replication_lock_off(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_dec6c968","line":1028,"updated":"2017-10-24 18:49:24.000000000","message":"Seeing this pattern a few times, I wonder if this would be better with a self.fail() at the heart of the onion?","commit_id":"e0244dd30d1974db1c522c3b4a2982eaed6c5297"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2759e4765cc549c74248e9bff9c494d66184a907","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"        with self.df_mgr.replication_lock(self.existing_device):"},{"line_number":1026,"context_line":"            with self.assertRaises(ReplicationLockTimeout):"},{"line_number":1027,"context_line":"                with self.df_mgr.replication_lock(self.existing_device):"},{"line_number":1028,"context_line":"                    success \u003d True"},{"line_number":1029,"context_line":"        self.assertFalse(success)"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"    def test_replication_lock_off(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_88dd85e1","line":1028,"in_reply_to":"3f4b6375_dec6c968","updated":"2017-10-26 09:20:41.000000000","message":"yeah that would work","commit_id":"e0244dd30d1974db1c522c3b4a2982eaed6c5297"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2b5d624717d2106856bc27e1d76fcd8ac90d9e76","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"            try:"},{"line_number":1040,"context_line":"                with self.df_mgr.replication_lock(self.existing_device):"},{"line_number":1041,"context_line":"                    success \u003d True"},{"line_number":1042,"context_line":"            except ReplicationLockTimeout as err:"},{"line_number":1043,"context_line":"                self.fail(\u0027Unexpected exception: %s\u0027 % err)"},{"line_number":1044,"context_line":"        self.assertTrue(success)"},{"line_number":1045,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_9e905145","line":1042,"updated":"2017-10-24 18:49:24.000000000","message":"Maybe better without the try/except?","commit_id":"e0244dd30d1974db1c522c3b4a2982eaed6c5297"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2759e4765cc549c74248e9bff9c494d66184a907","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"            try:"},{"line_number":1040,"context_line":"                with self.df_mgr.replication_lock(self.existing_device):"},{"line_number":1041,"context_line":"                    success \u003d True"},{"line_number":1042,"context_line":"            except ReplicationLockTimeout as err:"},{"line_number":1043,"context_line":"                self.fail(\u0027Unexpected exception: %s\u0027 % err)"},{"line_number":1044,"context_line":"        self.assertTrue(success)"},{"line_number":1045,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_a8eba175","line":1042,"in_reply_to":"3f4b6375_9e905145","updated":"2017-10-26 09:20:41.000000000","message":"I left the try/except because it results in a Fail rather than Error if there is a regression. IDK how big a deal that is.","commit_id":"e0244dd30d1974db1c522c3b4a2982eaed6c5297"}]}