)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9382d476c7971600062c9f063525db65be7ab4f1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added the man page for container-reconciler.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updated the review comments received on Patch Set 2"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic7fc6ddca2ab564b31156fa84b362bc9963825f1"},{"line_number":12,"context_line":"Closes-Bug: #1607025"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f4b6375_67ca56a1","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":51},"updated":"2017-10-27 08:45:21.000000000","message":"nit: it is not necessary to add this commentary to the commit message - the commit message only needs to describe the patch. The comments on gerrit can be used to record the history of the patch review.","commit_id":"9e27e8f4301601f5db0fa6fadb63e7c8f3f5b81a"}],"doc/manpages/container-reconciler.conf.5":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"3bc01a50a5987e0c5afa7db9f6fe12fb962901b5","unresolved":false,"context_lines":[{"line_number":174,"context_line":"More in depth documentation in regards to"},{"line_number":175,"context_line":".BI swift-container-reconciler"},{"line_number":176,"context_line":"and also about OpenStack Swift as a whole can be found at"},{"line_number":177,"context_line":".BI https://docs.openstack.org/newton/config-reference/object-storage/container-reconciler.html"},{"line_number":178,"context_line":"and"},{"line_number":179,"context_line":".BI https://docs.openstack.org/swift/latest/"},{"line_number":180,"context_line":""}],"source_content_type":"text/troff","patch_set":1,"id":"3f4b6375_ff55e3fa","line":177,"updated":"2017-10-25 16:22:04.000000000","message":"I would prefer dropping the link to Newton. I found that Pike excludes swift from configuration reference, so there\u0027s no up-to-date version of that page. But linking back to Newton is no good either. Let\u0027s just refer to top page for Swift alone.","commit_id":"e0b92cd36102a1d4746198fb7d1fe00164b863a0"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"032d16b52998e2b060de2947fee759b36ee02b64","unresolved":false,"context_lines":[{"line_number":174,"context_line":"More in depth documentation in regards to"},{"line_number":175,"context_line":".BI swift-container-reconciler"},{"line_number":176,"context_line":"and also about OpenStack Swift as a whole can be found at"},{"line_number":177,"context_line":".BI https://docs.openstack.org/newton/config-reference/object-storage/container-reconciler.html"},{"line_number":178,"context_line":"and"},{"line_number":179,"context_line":".BI https://docs.openstack.org/swift/latest/"},{"line_number":180,"context_line":""}],"source_content_type":"text/troff","patch_set":1,"id":"3f4b6375_e8ee3920","line":177,"in_reply_to":"3f4b6375_31ea80d7","updated":"2017-10-26 08:49:10.000000000","message":"My opinion would be to not have any reference to any release in the man page because it then needs to be updated with every release. I\u0027m not even sure what generates https://docs.openstack.org/newton/config-reference/object-storage/container-reconciler.html\n\nAn alternative link would be:\n\nhttps://docs.openstack.org/swift/latest/overview_policies.html#container-reconciler","commit_id":"e0b92cd36102a1d4746198fb7d1fe00164b863a0"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"2801f0b2127aaa49494480c71419fb22908932fe","unresolved":false,"context_lines":[{"line_number":174,"context_line":"More in depth documentation in regards to"},{"line_number":175,"context_line":".BI swift-container-reconciler"},{"line_number":176,"context_line":"and also about OpenStack Swift as a whole can be found at"},{"line_number":177,"context_line":".BI https://docs.openstack.org/newton/config-reference/object-storage/container-reconciler.html"},{"line_number":178,"context_line":"and"},{"line_number":179,"context_line":".BI https://docs.openstack.org/swift/latest/"},{"line_number":180,"context_line":""}],"source_content_type":"text/troff","patch_set":1,"id":"3f4b6375_31ea80d7","line":177,"in_reply_to":"3f4b6375_ff55e3fa","updated":"2017-10-26 05:15:00.000000000","message":"Do we need to add this link then:\nhttps://docs.openstack.org/swift/pike/\n\nOr any other link of swift needs to be referred here?\n\nPlease confirm.","commit_id":"e0b92cd36102a1d4746198fb7d1fe00164b863a0"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"1364740285fde55d3810e95b203ed7f8daedf772","unresolved":false,"context_lines":[{"line_number":174,"context_line":"More in depth documentation in regards to"},{"line_number":175,"context_line":".BI swift-container-reconciler"},{"line_number":176,"context_line":"and also about OpenStack Swift as a whole can be found at"},{"line_number":177,"context_line":".BI https://docs.openstack.org/newton/config-reference/object-storage/container-reconciler.html"},{"line_number":178,"context_line":"and"},{"line_number":179,"context_line":".BI https://docs.openstack.org/swift/latest/"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".SH \"SEE ALSO\""},{"line_number":182,"context_line":".BR swift-container-reconciler(1)"}],"source_content_type":"text/troff","patch_set":1,"id":"3f4b6375_c36ebec7","line":179,"range":{"start_line":177,"start_character":0,"end_line":179,"end_character":44},"updated":"2017-10-26 09:09:33.000000000","message":"As suggested by Alistair, we think it is better to put the below URL:\n\nhttps://docs.openstack.org/swift/latest/overview_policies.html","commit_id":"e0b92cd36102a1d4746198fb7d1fe00164b863a0"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"b6729b3c6b0334c2cbe6d435a35121ac78be5fa8","unresolved":false,"context_lines":[{"line_number":174,"context_line":"More in depth documentation in regards to"},{"line_number":175,"context_line":".BI swift-container-reconciler"},{"line_number":176,"context_line":"and also about OpenStack Swift as a whole can be found at"},{"line_number":177,"context_line":".BI https://docs.openstack.org/newton/config-reference/object-storage/container-reconciler.html"},{"line_number":178,"context_line":"and"},{"line_number":179,"context_line":".BI https://docs.openstack.org/swift/latest/"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":".SH \"SEE ALSO\""},{"line_number":182,"context_line":".BR swift-container-reconciler(1)"}],"source_content_type":"text/troff","patch_set":1,"id":"3f4b6375_63d82aee","line":179,"range":{"start_line":177,"start_character":0,"end_line":179,"end_character":44},"in_reply_to":"3f4b6375_c36ebec7","updated":"2017-10-26 09:30:52.000000000","message":"As confirmed by Alistair over IRC, we have added the single URL as below\n\nhttps://docs.openstack.org/swift/latest/overview_policies.html.\n\nP.S.: The long URL will also lead to manpage format errors.","commit_id":"e0b92cd36102a1d4746198fb7d1fe00164b863a0"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ac0b3018bc1c4a86c03b53dc34a9ba2c68f9a240","unresolved":false,"context_lines":[{"line_number":68,"context_line":".IP \"\\fBlog_statsd_port\\fR\""},{"line_number":69,"context_line":"The port value for the StatsD server. The default is 8125."},{"line_number":70,"context_line":".IP \"\\fBlog_statsd_sample_rate_factor\\fR\""},{"line_number":71,"context_line":"This is not recommended to set this to a value less than 1.0, if frequency of"},{"line_number":72,"context_line":"logging is too high, tune the log_statsd_default_sample_rate instead."},{"line_number":73,"context_line":"The default value is 1.0."},{"line_number":74,"context_line":".IP \"\\fBlog_udp_host\\fR\""}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_d8eb4875","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":4},"updated":"2017-10-26 11:00:32.000000000","message":"s/This/It/","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ac0b3018bc1c4a86c03b53dc34a9ba2c68f9a240","unresolved":false,"context_lines":[{"line_number":122,"context_line":"This is normally \\fBegg:swift#proxy\\fR."},{"line_number":123,"context_line":".RE"},{"line_number":124,"context_line":".PD"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".SH FILTER SECTIONS"},{"line_number":128,"context_line":".PD 1"}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_eba3d0fe","line":125,"updated":"2017-10-26 11:00:32.000000000","message":"for each of these sections (APP SECTION and FILTER SECTIONS) it might be best to just cross-reference to the proxy-server.conf.5 manpage\n\nFor example, insert here:\n\n  For details of the available options see proxy-server.conf.5","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"bbd392acbdaf309ab0ddcb174c8153a6b6861699","unresolved":false,"context_lines":[{"line_number":122,"context_line":"This is normally \\fBegg:swift#proxy\\fR."},{"line_number":123,"context_line":".RE"},{"line_number":124,"context_line":".PD"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".SH FILTER SECTIONS"},{"line_number":128,"context_line":".PD 1"}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_fb9ca56a","line":125,"in_reply_to":"3f4b6375_eba3d0fe","updated":"2017-10-27 06:16:44.000000000","message":"Done","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"b297cd4c0b5f1aef2c94251968bd393001426588","unresolved":false,"context_lines":[{"line_number":122,"context_line":"This is normally \\fBegg:swift#proxy\\fR."},{"line_number":123,"context_line":".RE"},{"line_number":124,"context_line":".PD"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".SH FILTER SECTIONS"},{"line_number":128,"context_line":".PD 1"}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_5b0f3987","line":125,"in_reply_to":"3f4b6375_fb9ca56a","updated":"2017-10-27 06:25:59.000000000","message":"We have added the line to refer the proxy-server.conf.5 in beginning of APP SECTION, which seems more relevant.","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ac0b3018bc1c4a86c03b53dc34a9ba2c68f9a240","unresolved":false,"context_lines":[{"line_number":129,"context_line":".RS 0"},{"line_number":130,"context_line":"Any section that has its name prefixed by \"filter:\" indicates a filter section."},{"line_number":131,"context_line":"Filters are used to specify configuration parameters for specific swift middlewares."},{"line_number":132,"context_line":"Below are the filters available and respective acceptable parameters."},{"line_number":133,"context_line":".RS 0"},{"line_number":134,"context_line":".IP \"\\fB[filter:cache]\\fR\""},{"line_number":135,"context_line":".RE"}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_2b02080b","line":132,"updated":"2017-10-26 11:00:32.000000000","message":"Similar to above, here you could add:\n\n  For details of the available options for each filter section see proxy-server.conf.5\n\nand then in this manpage only show the essential \u0027use\u0027 option for each filter","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"bbd392acbdaf309ab0ddcb174c8153a6b6861699","unresolved":false,"context_lines":[{"line_number":129,"context_line":".RS 0"},{"line_number":130,"context_line":"Any section that has its name prefixed by \"filter:\" indicates a filter section."},{"line_number":131,"context_line":"Filters are used to specify configuration parameters for specific swift middlewares."},{"line_number":132,"context_line":"Below are the filters available and respective acceptable parameters."},{"line_number":133,"context_line":".RS 0"},{"line_number":134,"context_line":".IP \"\\fB[filter:cache]\\fR\""},{"line_number":135,"context_line":".RE"}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_3b97dd4a","line":132,"in_reply_to":"3f4b6375_2b02080b","updated":"2017-10-27 06:16:44.000000000","message":"We have added the text as suggested at the end of complete filter section as that place is more relevant for this line rather than adding it to middle.","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"b297cd4c0b5f1aef2c94251968bd393001426588","unresolved":false,"context_lines":[{"line_number":129,"context_line":".RS 0"},{"line_number":130,"context_line":"Any section that has its name prefixed by \"filter:\" indicates a filter section."},{"line_number":131,"context_line":"Filters are used to specify configuration parameters for specific swift middlewares."},{"line_number":132,"context_line":"Below are the filters available and respective acceptable parameters."},{"line_number":133,"context_line":".RS 0"},{"line_number":134,"context_line":".IP \"\\fB[filter:cache]\\fR\""},{"line_number":135,"context_line":".RE"}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_1b254109","line":132,"in_reply_to":"3f4b6375_3b97dd4a","updated":"2017-10-27 06:25:59.000000000","message":"We have added the line to refer the proxy-server.conf.5 in beginning of FILTER SECTION, which seems more relevant.","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ac0b3018bc1c4a86c03b53dc34a9ba2c68f9a240","unresolved":false,"context_lines":[{"line_number":157,"context_line":".RS 0"},{"line_number":158,"context_line":".IP \"\\fB[filter:proxy-logging]\\fR\""},{"line_number":159,"context_line":".RE"},{"line_number":160,"context_line":"Logging for the proxy server now lives in this middleware."},{"line_number":161,"context_line":"If the access_* variables are not set, logging directives from [DEFAULT]"},{"line_number":162,"context_line":"without \"access_\" will be used."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":".RS 3"},{"line_number":165,"context_line":".IP \"\\fBuse\\fR\""}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_0b7cec80","line":162,"range":{"start_line":160,"start_character":0,"end_line":162,"end_character":31},"updated":"2017-10-26 11:00:32.000000000","message":"I would suggest deleting this. It is not clear what the access_* variables are. They are described in proxy-server.conf.5 so adding a reference to that (as above) should be sufficient","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"},{"author":{"_account_id":26690,"name":"HCLTech-SSW","email":"hcl_ss_oss@hcl.com","username":"hcltech-ssw"},"change_message_id":"bbd392acbdaf309ab0ddcb174c8153a6b6861699","unresolved":false,"context_lines":[{"line_number":157,"context_line":".RS 0"},{"line_number":158,"context_line":".IP \"\\fB[filter:proxy-logging]\\fR\""},{"line_number":159,"context_line":".RE"},{"line_number":160,"context_line":"Logging for the proxy server now lives in this middleware."},{"line_number":161,"context_line":"If the access_* variables are not set, logging directives from [DEFAULT]"},{"line_number":162,"context_line":"without \"access_\" will be used."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":".RS 3"},{"line_number":165,"context_line":".IP \"\\fBuse\\fR\""}],"source_content_type":"text/troff","patch_set":2,"id":"3f4b6375_bbbe2dd2","line":162,"range":{"start_line":160,"start_character":0,"end_line":162,"end_character":31},"in_reply_to":"3f4b6375_0b7cec80","updated":"2017-10-27 06:16:44.000000000","message":"Done","commit_id":"8986acb69b30994ba3e4ce2fc34ed725de7748f8"}]}