)]}'
{"swift/cli/ringbuilder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b167cb3e5ec5722483c0357f543e32667dc4d386","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        )):"},{"line_number":533,"context_line":"            flags \u003d \u0027DEL\u0027 if dev in builder._remove_devs else \u0027\u0027"},{"line_number":534,"context_line":"            print_dev_f(dev, balance_per_dev[dev[\u0027id\u0027]], flags)"},{"line_number":535,"context_line":"        if i \u003d\u003d -1:"},{"line_number":536,"context_line":"            print(\u0027There are no devices in this ring\u0027)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        # Print some helpful info if partition power increase in progress"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_ba6a217e","line":535,"updated":"2018-01-08 23:14:50.000000000","message":"Couldn\u0027t we just use\n\n if ring_empty_error:\n\n? Well, assuming that we set it again in the except block.\n\nIf we do *that*, how useful is this message? Aren\u0027t we going to double-up messages with the\n\n print(ring_empty_error)\n\nbelow?\n\n---\n\nMaybe we should mash both patches together? Drop the\n\n if builder.devs:\n\naround line 480, always try to get the balance and catch the EmptyRingError, then down here say something like\n\n if ring_empty_error:\n     balance_per_dev \u003d defaultdict(int)\n else:\n     balance_per_dev \u003d builder._build_balance_per_dev()","commit_id":"8389e7f2fdb8ca038605f85851534109272c738c"}]}