)]}'
{"swift/common/constraints.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"0f1e796bcc43f17a0722db48afb9242ed7815212","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                 body\u003d\u0027Non-integer X-Delete-After\u0027)"},{"line_number":322,"context_line":"        actual_del_time \u003d utils.normalize_delete_at_timestamp("},{"line_number":323,"context_line":"            now + x_delete_after)"},{"line_number":324,"context_line":"        if int(actual_del_time) \u003c now:"},{"line_number":325,"context_line":"            raise HTTPBadRequest(request\u003drequest,"},{"line_number":326,"context_line":"                                 content_type\u003d\u0027text/plain\u0027,"},{"line_number":327,"context_line":"                                 body\u003d\u0027X-Delete-After in past\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_7ff919c6","line":324,"range":{"start_line":324,"start_character":11,"end_line":324,"end_character":31},"updated":"2018-01-05 18:06:46.000000000","message":"Note: just this change is sufficient -- but I think I like the idea of moving up the call to normalize_delete_at_timestamp.","commit_id":"e2051b6cd346b2ef18de6509a492a08c7efdb2fa"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0b683c48271ca06191f4e16e44e68ad99c10b7de","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                 body\u003d\u0027Non-integer X-Delete-After\u0027)"},{"line_number":322,"context_line":"        actual_del_time \u003d utils.normalize_delete_at_timestamp("},{"line_number":323,"context_line":"            now + x_delete_after)"},{"line_number":324,"context_line":"        if int(actual_del_time) \u003c now:"},{"line_number":325,"context_line":"            raise HTTPBadRequest(request\u003drequest,"},{"line_number":326,"context_line":"                                 content_type\u003d\u0027text/plain\u0027,"},{"line_number":327,"context_line":"                                 body\u003d\u0027X-Delete-After in past\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_27be10d5","line":324,"range":{"start_line":324,"start_character":11,"end_line":324,"end_character":31},"in_reply_to":"9f91af0f_331745f0","updated":"2018-01-08 10:39:27.000000000","message":"Good point, certainly now that the docs have been clarified to say that x-delete-after should be a *positive* integer then 0 should be disallowed. \n\nI think when working on this change I was focussed on consistency with line 339 where the inappropriately annotated error was raised before when x-delete-after\u003d0 resulted in x-delete-at \u003c now.","commit_id":"e2051b6cd346b2ef18de6509a492a08c7efdb2fa"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"d73bed15d1501424c6328cf53f829c484cc23c1f","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                                 body\u003d\u0027Non-integer X-Delete-After\u0027)"},{"line_number":322,"context_line":"        actual_del_time \u003d utils.normalize_delete_at_timestamp("},{"line_number":323,"context_line":"            now + x_delete_after)"},{"line_number":324,"context_line":"        if int(actual_del_time) \u003c now:"},{"line_number":325,"context_line":"            raise HTTPBadRequest(request\u003drequest,"},{"line_number":326,"context_line":"                                 content_type\u003d\u0027text/plain\u0027,"},{"line_number":327,"context_line":"                                 body\u003d\u0027X-Delete-After in past\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_331745f0","line":324,"range":{"start_line":324,"start_character":11,"end_line":324,"end_character":31},"in_reply_to":"9f91af0f_7ff919c6","updated":"2018-01-06 01:28:23.000000000","message":"Oh! I wonder if this should be \u003c\u003d ... I seem to remember seeing some bug once where the resolution of time.time was only hundredths of a second, in which case, there\u0027s actually a reasonable chance of x-delete-after:0 being allowed because int(actual_del_time) \u003d\u003d now","commit_id":"e2051b6cd346b2ef18de6509a492a08c7efdb2fa"}]}
