)]}'
{"swift/cli/ringbuilder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3d9b540ef016c334618abb1736490d6fa17bca7a","unresolved":false,"context_lines":[{"line_number":549,"context_line":"            print(ring_empty_error)"},{"line_number":550,"context_line":"            exit(EXIT_SUCCESS)"},{"line_number":551,"context_line":"        else:"},{"line_number":552,"context_line":"            exit(EXIT_SUCCESS)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    @staticmethod"},{"line_number":555,"context_line":"    def search():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_d8ef95ae","line":552,"updated":"2018-01-10 20:02:06.000000000","message":"nit:\n\n if ring_empty_error:\n     print(ring_empty_error)\n exit(EXIT_SUCCESS)","commit_id":"5c624a02c61bc5d72763c2a8199df67d47c5acb9"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"623dcd3ac0a8dc6c359267bb4766f3e3ef27f93b","unresolved":false,"context_lines":[{"line_number":549,"context_line":"            print(ring_empty_error)"},{"line_number":550,"context_line":"            exit(EXIT_SUCCESS)"},{"line_number":551,"context_line":"        else:"},{"line_number":552,"context_line":"            exit(EXIT_SUCCESS)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    @staticmethod"},{"line_number":555,"context_line":"    def search():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_283bc438","line":552,"in_reply_to":"7f96bb07_d8ef95ae","updated":"2018-01-10 22:00:15.000000000","message":"I agree","commit_id":"5c624a02c61bc5d72763c2a8199df67d47c5acb9"}],"test/unit/cli/test_ringbuilder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3d9b540ef016c334618abb1736490d6fa17bca7a","unresolved":false,"context_lines":[{"line_number":1885,"context_line":"                self.assertSystemExit(EXIT_SUCCESS, ringbuilder.main, argv)"},{"line_number":1886,"context_line":"        ring_invalid_re \u003d re.compile(\"Ring file .*\\.ring\\.gz is invalid\")"},{"line_number":1887,"context_line":"        self.assertTrue(ring_invalid_re.findall(mock_stdout.getvalue()))"},{"line_number":1888,"context_line":"    def test_default_no_device_ring_without_exception(self):"},{"line_number":1889,"context_line":"        self.create_sample_ring()"},{"line_number":1890,"context_line":""},{"line_number":1891,"context_line":"        # remove devices from ring file"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_b82089f9","line":1888,"updated":"2018-01-10 20:02:06.000000000","message":"I think pep8 will complain about the missing newline","commit_id":"5c624a02c61bc5d72763c2a8199df67d47c5acb9"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"623dcd3ac0a8dc6c359267bb4766f3e3ef27f93b","unresolved":false,"context_lines":[{"line_number":1885,"context_line":"                self.assertSystemExit(EXIT_SUCCESS, ringbuilder.main, argv)"},{"line_number":1886,"context_line":"        ring_invalid_re \u003d re.compile(\"Ring file .*\\.ring\\.gz is invalid\")"},{"line_number":1887,"context_line":"        self.assertTrue(ring_invalid_re.findall(mock_stdout.getvalue()))"},{"line_number":1888,"context_line":"    def test_default_no_device_ring_without_exception(self):"},{"line_number":1889,"context_line":"        self.create_sample_ring()"},{"line_number":1890,"context_line":""},{"line_number":1891,"context_line":"        # remove devices from ring file"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_a87d94e8","line":1888,"in_reply_to":"7f96bb07_b82089f9","updated":"2018-01-10 22:00:15.000000000","message":"It did\n\ntest/unit/cli/test_ringbuilder.py:1888:5: E301 expected 1 blank line, found 0\n    def test_default_no_device_ring_without_exception(self):","commit_id":"5c624a02c61bc5d72763c2a8199df67d47c5acb9"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"49f47c6b97dfa02d2775ce7d8925ac040263eb4e","unresolved":false,"context_lines":[{"line_number":1917,"context_line":"        output \u003d mock_stdout.getvalue()"},{"line_number":1918,"context_line":"        self.assertIn(\"64 partitions\", output)"},{"line_number":1919,"context_line":"        self.assertIn(\"all devices have been deleted\", output)"},{"line_number":1920,"context_line":"        self.assertIn(\"all devices have been deleted\", output)"},{"line_number":1921,"context_line":"        self.assertIn(deleted_dev_list, output)"},{"line_number":1922,"context_line":""},{"line_number":1923,"context_line":"    def test_empty_ring(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_fb72887c","line":1920,"range":{"start_line":1920,"start_character":8,"end_line":1920,"end_character":62},"updated":"2018-01-10 22:20:08.000000000","message":"I wish we could\u0027ve removed the obvious accidental copy paste I made here in this patch.. but maybe next time someone touches this file :)","commit_id":"9754a2ebe3f0ef66efd6fe0ff6c32fbb2e992617"}]}