)]}'
{"swift/common/utils.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"539ec548979257bc4eddb3cdecad30c87fd6b1eb","unresolved":false,"context_lines":[{"line_number":1756,"context_line":"            elif exc.errno \u003d\u003d errno.EHOSTUNREACH:"},{"line_number":1757,"context_line":"                emsg \u003d _(\u0027Host unreachable\u0027)"},{"line_number":1758,"context_line":"            elif exc.errno \u003d\u003d errno.ENETUNREACH:"},{"line_number":1759,"context_line":"                emsg \u003d _(\u0027Network unreachable\u0027)"},{"line_number":1760,"context_line":"            elif exc.errno \u003d\u003d errno.ETIMEDOUT:"},{"line_number":1761,"context_line":"                emsg \u003d _(\u0027Connection timeout\u0027)"},{"line_number":1762,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_17a7c751","line":1759,"updated":"2018-01-26 19:48:00.000000000","message":"I guess this is ok, we suppress traceback for ECONNREFUSED","commit_id":"47ea2d39f8f74ec66e977179b68afe654920ca81"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"539ec548979257bc4eddb3cdecad30c87fd6b1eb","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"            else:"},{"line_number":1763,"context_line":"                call \u003d self._exception"},{"line_number":1764,"context_line":"        elif isinstance(exc, httplib.BadStatusLine):"},{"line_number":1765,"context_line":"            pass  # Use error(); not really exceptional"},{"line_number":1766,"context_line":"        elif isinstance(exc, eventlet.Timeout):"},{"line_number":1767,"context_line":"            emsg \u003d exc.__class__.__name__"},{"line_number":1768,"context_line":"            if hasattr(exc, \u0027seconds\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_57722fe5","line":1765,"updated":"2018-01-26 19:48:00.000000000","message":"yeah, this makes sense - typically a read on closed socket that\u0027s ben makefile\u0027d returning \u0027\u0027 (empty string)","commit_id":"47ea2d39f8f74ec66e977179b68afe654920ca81"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"09665c702afaecd67aa57c6ca61cccd033aa41d0","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"            else:"},{"line_number":1762,"context_line":"                call \u003d self._exception"},{"line_number":1763,"context_line":"        elif isinstance(exc, http_client.BadStatusLine):"},{"line_number":1764,"context_line":"            pass  # Use error(); not really exceptional"},{"line_number":1765,"context_line":"        elif isinstance(exc, eventlet.Timeout):"},{"line_number":1766,"context_line":"            emsg \u003d exc.__class__.__name__"},{"line_number":1767,"context_line":"            if hasattr(exc, \u0027seconds\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_1dc8a8a3","line":1764,"updated":"2018-04-03 23:50:34.000000000","message":"Shoot! Pretty sure I shoulda done something like\n\n emsg \u003d str(exc)\n\nhere...","commit_id":"b50101f4368c32c8d35e788e1b229aab19303f43"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"23a9b50030d92f68eda7344c54e44a0d93889d32","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"                call \u003d self._exception"},{"line_number":1763,"context_line":"        elif isinstance(exc, http_client.BadStatusLine):"},{"line_number":1764,"context_line":"            # Use error(); not really exceptional"},{"line_number":1765,"context_line":"            emsg \u003d \u0027%s: %s\u0027 % (exc.__class__.__name__, exc.line)"},{"line_number":1766,"context_line":"        elif isinstance(exc, eventlet.Timeout):"},{"line_number":1767,"context_line":"            emsg \u003d exc.__class__.__name__"},{"line_number":1768,"context_line":"            if hasattr(exc, \u0027seconds\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_448168c2","line":1765,"updated":"2018-04-04 04:54:01.000000000","message":"You are checking for an instance of BadStatusLine, so unless you expect to catch more errors that are children of this class. Do we need to reach into exc via dunder methods or just:\n\n  emsg \u003d \u0027BadStatusLine: %s\u0027 % (exc.line)\n\nAlthough all the other previous catches have been given human readable names.. so maybe:\n\n  emsg \u003d \u0027Bad status line: %s\u0027 % (exc.line)","commit_id":"5d20411a3ff23288e33f4d72cc7154574c7d6e7d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a58d37d1b9256e0037342b0e6f163b0e19942e97","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"                call \u003d self._exception"},{"line_number":1763,"context_line":"        elif isinstance(exc, http_client.BadStatusLine):"},{"line_number":1764,"context_line":"            # Use error(); not really exceptional"},{"line_number":1765,"context_line":"            emsg \u003d \u0027%s: %s\u0027 % (exc.__class__.__name__, exc.line)"},{"line_number":1766,"context_line":"        elif isinstance(exc, eventlet.Timeout):"},{"line_number":1767,"context_line":"            emsg \u003d exc.__class__.__name__"},{"line_number":1768,"context_line":"            if hasattr(exc, \u0027seconds\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_a4f5e458","line":1765,"in_reply_to":"bf659307_448168c2","updated":"2018-04-04 04:59:49.000000000","message":"On the off-chance that CPython loses its damn mind and starts throwing up subclasses of BadStatusLine (and, y\u0027know, we actually get on a modern version of CPython so we\u0027d actually be exposed to it)... I\u0027d rather have the actual exception. It\u0027s similar to what we do with Timeout below.","commit_id":"5d20411a3ff23288e33f4d72cc7154574c7d6e7d"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"3207ed803438f5276cd1afb142cbb705df3a4769","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"                call \u003d self._exception"},{"line_number":1763,"context_line":"        elif isinstance(exc, http_client.BadStatusLine):"},{"line_number":1764,"context_line":"            # Use error(); not really exceptional"},{"line_number":1765,"context_line":"            emsg \u003d \u0027%s: %s\u0027 % (exc.__class__.__name__, exc.line)"},{"line_number":1766,"context_line":"        elif isinstance(exc, eventlet.Timeout):"},{"line_number":1767,"context_line":"            emsg \u003d exc.__class__.__name__"},{"line_number":1768,"context_line":"            if hasattr(exc, \u0027seconds\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_27da3677","line":1765,"in_reply_to":"bf659307_a4f5e458","updated":"2018-04-04 05:35:53.000000000","message":"Oh yeah, just look below and we have a precidence.. cool. We\u0027ve done it before. and for some reason when looking I failed to see 2 lines below :P","commit_id":"5d20411a3ff23288e33f4d72cc7154574c7d6e7d"}]}