)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a91945793cb5af29241bac5d5821c6583ebdc1ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ratelimit: ignore requests with invalid API versions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you\u0027ve got things like domain_remap, swift3, or other such"},{"line_number":10,"context_line":"middlewares in your pipeline, you wind up with requests that aren\u0027t of"},{"line_number":11,"context_line":"the form \"/v1/\u003caccount\u003e/\u003ccontainer\u003e/\u003cobject\u003e\". When encountering such"},{"line_number":12,"context_line":"an oddball request, it\u0027s not useful to call get_account_info() on the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_d042370f","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":38},"updated":"2018-02-01 19:56:26.000000000","message":"Do we offer any guidance on where to place domain_remap in the pipeline? Or cname_lookup, for that matter...\n\nI think it\u0027s actually fairly reasonable to have those toward the front, ahead of ratelimit, in which case it won\u0027t really be a problem.\n\nCome to think of it, do we have any explicit reasons for ratelimit\u0027s current recommended placement? All I see is\n\n pipeline \u003d ... bulk tempurl ratelimit tempauth copy ...\n\nwhich doesn\u0027t give me any real indication of *why*, or even which other middlewares we *think* might influence where it should go...","commit_id":"9da3992a7e8f7aa899d7456d359dbe740c3def28"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"fcc9d187b0a5fa96eb55045ba70c8e4ec3a2ef46","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ratelimit: ignore requests with invalid API versions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you\u0027ve got things like domain_remap, swift3, or other such"},{"line_number":10,"context_line":"middlewares in your pipeline, you wind up with requests that aren\u0027t of"},{"line_number":11,"context_line":"the form \"/v1/\u003caccount\u003e/\u003ccontainer\u003e/\u003cobject\u003e\". When encountering such"},{"line_number":12,"context_line":"an oddball request, it\u0027s not useful to call get_account_info() on the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_895d657a","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":38},"in_reply_to":"5f93b717_d042370f","updated":"2018-02-01 23:28:17.000000000","message":"Yeah, that\u0027s pretty fair. I was mostly going off the bug report which said that these things goof it up.\n\nI guess that you\u0027d want to place ratelimit to the right of anything giving you a non-Swift-API endpoint. That includes stuff like swift3, tempauth, domain_remap, and so on... basically anything where your URL paths are not of the form \"/v1/a/c/o\".\n\nYou\u0027d probably want it to the left of symlinks so you don\u0027t get extra limited for using those... or maybe you want it to the right so that you do. :shrug:\n\nIMO it\u0027s still a good idea to do this in case there are middleware configurations that require ratelimit to be in a place where it sees weird requests. My brain isn\u0027t working terribly well today, though, so I don\u0027t have an example ready.","commit_id":"9da3992a7e8f7aa899d7456d359dbe740c3def28"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a91945793cb5af29241bac5d5821c6583ebdc1ee","unresolved":false,"context_lines":[{"line_number":17,"context_line":"handled, but they won\u0027t be rate-limited."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9980cd0e902610ac99d13a502ae955bca2d99df3"},{"line_number":20,"context_line":"Closes-Bug: 1669888"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_10909f49","line":20,"updated":"2018-02-01 19:56:26.000000000","message":"Closes-Bug: 1695273, too?","commit_id":"9da3992a7e8f7aa899d7456d359dbe740c3def28"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"fcc9d187b0a5fa96eb55045ba70c8e4ec3a2ef46","unresolved":false,"context_lines":[{"line_number":17,"context_line":"handled, but they won\u0027t be rate-limited."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9980cd0e902610ac99d13a502ae955bca2d99df3"},{"line_number":20,"context_line":"Closes-Bug: 1669888"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_0942b5ab","line":20,"in_reply_to":"5f93b717_10909f49","updated":"2018-02-01 23:28:17.000000000","message":"Sure, why not?","commit_id":"9da3992a7e8f7aa899d7456d359dbe740c3def28"}]}