)]}'
{"swift/common/manager.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"68f02d9a602e34932d37d7ac2fe43312290c11cf","unresolved":false,"context_lines":[{"line_number":682,"context_line":"            if proc.stdout:"},{"line_number":683,"context_line":"                output \u003d proc.stdout.read()"},{"line_number":684,"context_line":"                proc.stdout.close()"},{"line_number":685,"context_line":"                proc.stdout \u003d None"},{"line_number":686,"context_line":"            else:"},{"line_number":687,"context_line":"                output \u003d \u0027\u0027"},{"line_number":688,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_49f81648","line":685,"updated":"2018-02-09 04:57:21.000000000","message":"Ugh. Is it really safe to just assign None? I looked at the source at Cpython\u0027s Lib/subprocess.py and it\u0027s a little murky, especially towards the future. Referencing a Popen.stdout is definitely permitted, I\u0027m okay with even closing it (because it\u0027s hard to imagine Popen.communicate() that does not do exactly that in the end). But just killing it...?","commit_id":"dd55555e32acd129284b7a6701f352981019e4a8"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8b12041399f70d0d301b28384fefa23897a562e2","unresolved":false,"context_lines":[{"line_number":682,"context_line":"            if proc.stdout:"},{"line_number":683,"context_line":"                output \u003d proc.stdout.read()"},{"line_number":684,"context_line":"                proc.stdout.close()"},{"line_number":685,"context_line":"                proc.stdout \u003d None"},{"line_number":686,"context_line":"            else:"},{"line_number":687,"context_line":"                output \u003d \u0027\u0027"},{"line_number":688,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_f6af64e0","line":685,"in_reply_to":"3fa0c359_49f81648","updated":"2018-02-09 20:38:04.000000000","message":"Done","commit_id":"dd55555e32acd129284b7a6701f352981019e4a8"}]}