)]}'
{".functests":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"328b189d8db5c3ef426973fe22c801dbb8ba3914","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"cd ${SRC_DIR}"},{"line_number":9,"context_line":"export TESTS_DIR\u003d${SRC_DIR}/test/functional"},{"line_number":10,"context_line":"ostestr --serial --pretty $@"},{"line_number":11,"context_line":"rvalue\u003d$?"},{"line_number":12,"context_line":"cd -"},{"line_number":13,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_26cbf772","side":"PARENT","line":10,"updated":"2018-02-14 19:54:08.000000000","message":"Let\u0027s just do\n\n    ARGS\u003d${@:-\"--serial --pretty\"}\n\nand keep default behavior but let the caller explicitly pass the specific args they want, if any...","commit_id":"b33941feda95b8e37c5bb68a2a5cdfe2007e3a4d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f54a3c938a67f4736536d15da27d5012135ae3de","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"cd ${SRC_DIR}"},{"line_number":9,"context_line":"export TESTS_DIR\u003d${SRC_DIR}/test/functional"},{"line_number":10,"context_line":"ostestr --serial --pretty $@"},{"line_number":11,"context_line":"rvalue\u003d$?"},{"line_number":12,"context_line":"cd -"},{"line_number":13,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_c6e253a1","side":"PARENT","line":10,"in_reply_to":"3fa0c359_26cbf772","updated":"2018-02-14 20:05:23.000000000","message":"I think that --serial is pretty important, though. Like, our setUp/tearDown methods will get you into a pretty terrible state if you try to run tests in parallel... Maybe something more like\n\n ARGS\u003d\"--serial ${@:-\"--pretty\"}\"\n\n?","commit_id":"b33941feda95b8e37c5bb68a2a5cdfe2007e3a4d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"328b189d8db5c3ef426973fe22c801dbb8ba3914","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    local e"},{"line_number":11,"context_line":"    for e in \"${@:2}\"; do [[ \"$e\" \u003d\u003d \"$1\" ]] \u0026\u0026 return 0; done"},{"line_number":12,"context_line":"    return 1"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"cd ${SRC_DIR} \u003e /dev/null"},{"line_number":16,"context_line":"export TESTS_DIR\u003d${SRC_DIR}/test/functional"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_06f7dbd6","line":13,"updated":"2018-02-14 19:54:08.000000000","message":"this is too much bash for my blood","commit_id":"01f10467763dd24f66b17dcd0782aa859935c1a4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ebc3ac131ebba882ecabf772081a76026fea5aff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# How-To debug functional tests:"},{"line_number":4,"context_line":"# SWIFT_TEST_IN_PROCESS\u003d1 tox -e func -- --pdb test.functional.tests.TestFile.testCopy"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"SRC_DIR\u003d$(python -c \"import os; print os.path.dirname(os.path.realpath(\u0027$0\u0027))\")"},{"line_number":7,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_924a4181","line":4,"updated":"2018-02-14 23:04:02.000000000","message":"Good news: this still works!\n\nBad news: this doesn\u0027t:\n\n SWIFT_TEST_IN_PROCESS\u003d1 tox -e func -- --pdb \u0027test.functional.tests.TestFile testCopy\u0027\n\nIt breaks up what was intended to be a single arg into two:\n\n + ARGS\u003d\u0027--serial --pdb test.functional.tests.TestFile testCopy\u0027\n + ostestr --serial --pdb test.functional.tests.TestFile testCopy\n\nGood (?) news: it was already broken like that. The\n\n $@\n\nshould have been a\n\n \"$@\"\n\nBetter news: I can\u0027t think of any reason that you\u0027d *want* to pass an arg with spaces or backslashes or any other funny characters in it to ostestr. Between that and the fact that it seems tricky to get the quoting right to make this *not* suck, I say ship it!","commit_id":"57306181f1ffde3da1849c6d27e0b001d3bf5ea3"}]}